From 20d7df3c3ff0000678a208b25fcf7ddf90c5abe4 Mon Sep 17 00:00:00 2001 From: Adrian Roos Date: Tue, 12 Jan 2016 18:59:43 +0100 Subject: Crash dialog improvements, move crash code to AppErrors Factors out the crash and ANR handling code into separate class and allows clearing cache and restarting app from crash dialog. Bug: 22692162 Change-Id: I2a08a4255ea02ab3c7441d351bf278128fcf5a5d --- core/res/res/layout/app_error_dialog.xml | 70 ++ .../layout/app_error_dialog_dont_show_again.xml | 40 - core/res/res/values/strings.xml | 29 +- core/res/res/values/styles.xml | 10 + core/res/res/values/symbols.xml | 12 +- .../java/com/android/server/am/ActiveServices.java | 2 +- .../android/server/am/ActivityManagerService.java | 796 +---------------- .../java/com/android/server/am/ActivityStack.java | 66 +- .../android/server/am/ActivityStackSupervisor.java | 10 +- .../java/com/android/server/am/AppErrorDialog.java | 141 +-- .../core/java/com/android/server/am/AppErrors.java | 964 +++++++++++++++++++++ .../android/server/am/AppNotRespondingDialog.java | 2 +- .../java/com/android/server/am/BroadcastQueue.java | 2 +- .../server/am/StrictModeViolationDialog.java | 1 - 14 files changed, 1235 insertions(+), 910 deletions(-) create mode 100644 core/res/res/layout/app_error_dialog.xml delete mode 100644 core/res/res/layout/app_error_dialog_dont_show_again.xml create mode 100644 services/core/java/com/android/server/am/AppErrors.java diff --git a/core/res/res/layout/app_error_dialog.xml b/core/res/res/layout/app_error_dialog.xml new file mode 100644 index 000000000000..aaa2dbc389dc --- /dev/null +++ b/core/res/res/layout/app_error_dialog.xml @@ -0,0 +1,70 @@ + + + + + + + + + + + + + + + + + diff --git a/core/res/res/layout/app_error_dialog_dont_show_again.xml b/core/res/res/layout/app_error_dialog_dont_show_again.xml deleted file mode 100644 index ba79ecd1fa8c..000000000000 --- a/core/res/res/layout/app_error_dialog_dont_show_again.xml +++ /dev/null @@ -1,40 +0,0 @@ - - - - - - - diff --git a/core/res/res/values/strings.xml b/core/res/res/values/strings.xml index 28c76bb2d38d..2f2c5e447d1e 100644 --- a/core/res/res/values/strings.xml +++ b/core/res/res/values/strings.xml @@ -2588,16 +2588,27 @@ No apps can perform this action. - - - Unfortunately, %1$s has stopped. - - Unfortunately, the process %1$s has - stopped. - - Silence crashes from %1$s - until reboot. + %1$s has stopped + + %1$s has + stopped + + %1$s is repeatedly stopping + + %1$s is + repeatedly stopping + + Restart app + + Reset and restart app + + Send feedback + + Close + + Mute + diff --git a/core/res/res/values/styles.xml b/core/res/res/values/styles.xml index d5349b2ee9f8..b660277847c4 100644 --- a/core/res/res/values/styles.xml +++ b/core/res/res/values/styles.xml @@ -1397,6 +1397,16 @@ please see styles_device_defaults.xml. @drawable/pointer_grabbing_large_icon + + +