From e8d65c8d90032ccdb561d9c998cacce3aed20d43 Mon Sep 17 00:00:00 2001 From: Julia Tuttle Date: Wed, 18 Dec 2024 12:38:41 -0500 Subject: Make ServerFlagReaderFake namespace-aware Flag: EXEMPT bugfix Test: presubmit Change-Id: Ie07c3e7551b8412c227aad37e63d8687f1b363a2 --- .../src/com/android/systemui/flags/ServerFlagReader.kt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/flags/ServerFlagReader.kt b/packages/SystemUI/src/com/android/systemui/flags/ServerFlagReader.kt index eaf5eac155ef..73968da38088 100644 --- a/packages/SystemUI/src/com/android/systemui/flags/ServerFlagReader.kt +++ b/packages/SystemUI/src/com/android/systemui/flags/ServerFlagReader.kt @@ -126,24 +126,24 @@ interface ServerFlagReaderModule { } class ServerFlagReaderFake : ServerFlagReader { - private val flagMap: MutableMap = mutableMapOf() + private val flagMap: MutableMap, Boolean> = mutableMapOf() private val listeners = mutableListOf>>>() override fun hasOverride(namespace: String, name: String): Boolean { - return flagMap.containsKey(name) + return flagMap.containsKey(namespace to name) } override fun readServerOverride(namespace: String, name: String, default: Boolean): Boolean { - return flagMap.getOrDefault(name, default) + return flagMap.getOrDefault(namespace to name, default) } fun setFlagValue(namespace: String, name: String, value: Boolean) { - flagMap.put(name, value) + flagMap.put(namespace to name, value) for ((listener, flags) in listeners) { flagLoop@ for (flag in flags) { - if (name == flag.name) { + if (namespace == flag.namespace && name == flag.name) { listener.onChange(flag, if (value) "true" else "false") break@flagLoop } @@ -152,13 +152,13 @@ class ServerFlagReaderFake : ServerFlagReader { } fun eraseFlag(namespace: String, name: String) { - flagMap.remove(name) + flagMap.remove(namespace to name) } override fun listenForChanges( flags: Collection>, listener: ServerFlagReader.ChangeListener ) { - listeners.add(Pair(listener, flags)) + listeners.add(listener to flags) } } -- cgit v1.2.3-59-g8ed1b