From e8bbbbe2ac714f903f6f790a75de10848cf1bb1d Mon Sep 17 00:00:00 2001 From: Grace Cheng Date: Wed, 20 Mar 2024 20:22:27 +0000 Subject: Remove unused layout file and specify removed lottie listener Remove layout file from deleted screenshot test, and change removeAllLottieOnCompositionLoadedListeners call to remove specific listener in order to prevent removing IdlingResource compositionLoaded listeners used in screenshot tests Flag: NONE Bug: 287311775 Test: N/A Change-Id: Ie2fc5b304f79cc11925fe61f0363170327a6ef6f --- .../SystemUI/res/layout/auth_biometric_icon.xml | 26 ---------------------- .../biometrics/ui/binder/PromptIconViewBinder.kt | 17 +++++++++++--- 2 files changed, 14 insertions(+), 29 deletions(-) delete mode 100644 packages/SystemUI/res/layout/auth_biometric_icon.xml diff --git a/packages/SystemUI/res/layout/auth_biometric_icon.xml b/packages/SystemUI/res/layout/auth_biometric_icon.xml deleted file mode 100644 index b2df63dab700..000000000000 --- a/packages/SystemUI/res/layout/auth_biometric_icon.xml +++ /dev/null @@ -1,26 +0,0 @@ - - - - - \ No newline at end of file diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/PromptIconViewBinder.kt b/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/PromptIconViewBinder.kt index 66b7d7afb8c4..d9d3715f0a30 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/PromptIconViewBinder.kt +++ b/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/PromptIconViewBinder.kt @@ -26,6 +26,7 @@ import androidx.constraintlayout.widget.ConstraintSet import androidx.lifecycle.Lifecycle import androidx.lifecycle.repeatOnLifecycle import com.airbnb.lottie.LottieAnimationView +import com.airbnb.lottie.LottieOnCompositionLoadedListener import com.android.settingslib.widget.LottieColorUtils import com.android.systemui.Flags.constraintBp import com.android.systemui.biometrics.ui.viewmodel.PromptIconViewModel @@ -77,6 +78,8 @@ object PromptIconViewBinder { } launch { + var lottieOnCompositionLoadedListener: LottieOnCompositionLoadedListener? = null + combine(viewModel.activeAuthType, viewModel.iconSize, ::Pair).collect { (activeAuthType, iconSize) -> // Every time after bp shows, [isIconViewLoaded] is set to false in @@ -94,10 +97,18 @@ object PromptIconViewBinder { * TODO(b/288175072): May be able to remove this once constraint * layout is implemented */ - iconView.removeAllLottieOnCompositionLoadedListener() - iconView.addLottieOnCompositionLoadedListener { - promptViewModel.setIsIconViewLoaded(true) + if (lottieOnCompositionLoadedListener != null) { + iconView.removeLottieOnCompositionLoadedListener( + lottieOnCompositionLoadedListener!! + ) } + lottieOnCompositionLoadedListener = + LottieOnCompositionLoadedListener { + promptViewModel.setIsIconViewLoaded(true) + } + iconView.addLottieOnCompositionLoadedListener( + lottieOnCompositionLoadedListener!! + ) } AuthType.Face -> { /** -- cgit v1.2.3-59-g8ed1b