From cae61a70e648fbb70b3e354a0a8249fd36f73c65 Mon Sep 17 00:00:00 2001 From: hughchen Date: Wed, 27 May 2020 17:18:40 +0800 Subject: Update MediaDevice icon - This CL update MediaDevice icon. - Update test case. Bug: 157208551 Test: make -j42 RunSettingsLibRoboTests Change-Id: I1030ca9cbd0a4c05b3f56a463b83bb6b4d3b7756 --- packages/SettingsLib/res/drawable/ic_headphone.xml | 29 +++++++++++++++++++ .../SettingsLib/res/drawable/ic_media_device.xml | 33 ---------------------- .../res/drawable/ic_media_display_device.xml | 30 ++++++++++++++++++++ .../res/drawable/ic_media_group_device.xml | 16 +++++++---- .../res/drawable/ic_media_speaker_device.xml | 30 ++++++++++++++++++++ .../SettingsLib/res/drawable/ic_smartphone.xml | 7 ++--- .../settingslib/media/BluetoothMediaDevice.java | 10 +++++-- .../android/settingslib/media/InfoMediaDevice.java | 4 ++- .../settingslib/media/InfoMediaDeviceTest.java | 6 ++-- 9 files changed, 117 insertions(+), 48 deletions(-) create mode 100644 packages/SettingsLib/res/drawable/ic_headphone.xml delete mode 100644 packages/SettingsLib/res/drawable/ic_media_device.xml create mode 100644 packages/SettingsLib/res/drawable/ic_media_display_device.xml create mode 100644 packages/SettingsLib/res/drawable/ic_media_speaker_device.xml diff --git a/packages/SettingsLib/res/drawable/ic_headphone.xml b/packages/SettingsLib/res/drawable/ic_headphone.xml new file mode 100644 index 000000000000..3b44f8f2153f --- /dev/null +++ b/packages/SettingsLib/res/drawable/ic_headphone.xml @@ -0,0 +1,29 @@ + + + + + \ No newline at end of file diff --git a/packages/SettingsLib/res/drawable/ic_media_device.xml b/packages/SettingsLib/res/drawable/ic_media_device.xml deleted file mode 100644 index 5a6aeb4a8e23..000000000000 --- a/packages/SettingsLib/res/drawable/ic_media_device.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - \ No newline at end of file diff --git a/packages/SettingsLib/res/drawable/ic_media_display_device.xml b/packages/SettingsLib/res/drawable/ic_media_display_device.xml new file mode 100644 index 000000000000..78b4e2a23d45 --- /dev/null +++ b/packages/SettingsLib/res/drawable/ic_media_display_device.xml @@ -0,0 +1,30 @@ + + + + + \ No newline at end of file diff --git a/packages/SettingsLib/res/drawable/ic_media_group_device.xml b/packages/SettingsLib/res/drawable/ic_media_group_device.xml index ba5e65119ead..478a86095869 100644 --- a/packages/SettingsLib/res/drawable/ic_media_group_device.xml +++ b/packages/SettingsLib/res/drawable/ic_media_group_device.xml @@ -21,12 +21,16 @@ android:viewportHeight="24" android:tint="?android:attr/colorControlNormal"> + android:fillColor="#000000" + android:pathData="M19,4v14l-10,-0.01V4h10m0,-2H9c-1.1,0 -2,0.9 -2,2v13.99c0,1.1 0.89, + 2 2,2L19,20c1.1,0 2,-0.9 2,-2V4c0,-1.1 -0.9,-2 -2,-2z"/> + android:fillColor="#000000" + android:pathData="M14,7m-1.5,0a1.5,1.5 0,1 1,3 0a1.5,1.5 0,1 1,-3 0"/> + android:fillColor="#000000" + android:pathData="M14,17c1.93,0 3.5,-1.57 3.5,-3.5S15.93,10 14,10s-3.5, + 1.57 -3.5,3.5S12.07,17 14,17zM14,12c0.83,0 1.5,0.67 1.5,1.5S14.83,15 14, + 15s-1.5,-0.67 -1.5,-1.5 0.67,-1.5 1.5,-1.5zM6,5L4,5v16c0,1.1 0.89,2 2, + 2h10v-2L6,21L6,5z"/> \ No newline at end of file diff --git a/packages/SettingsLib/res/drawable/ic_media_speaker_device.xml b/packages/SettingsLib/res/drawable/ic_media_speaker_device.xml new file mode 100644 index 000000000000..32fe7d1c17ff --- /dev/null +++ b/packages/SettingsLib/res/drawable/ic_media_speaker_device.xml @@ -0,0 +1,30 @@ + + + + + \ No newline at end of file diff --git a/packages/SettingsLib/res/drawable/ic_smartphone.xml b/packages/SettingsLib/res/drawable/ic_smartphone.xml index 84a96da95fb1..09811bb4b792 100644 --- a/packages/SettingsLib/res/drawable/ic_smartphone.xml +++ b/packages/SettingsLib/res/drawable/ic_smartphone.xml @@ -20,10 +20,9 @@ android:width="24dp" android:height="24dp" android:tint="?android:attr/colorControlNormal"> - + android:pathData="M17,1.01L7,1c-1.1,0 -2,0.9 -2,2v18c0,1.1 0.9, + 2 2,2h10c1.1,0 2,-0.9 2,-2L19,3c0,-1.1 -0.9,-1.99 -2,-1.99zM17, + 21L7,21v-1h10v1zM17,18L7,18L7,6h10v12zM7,4L7,3h10v1L7,4z"/> diff --git a/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java index a2f77e2d5046..40d80488af96 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/BluetoothMediaDevice.java @@ -59,12 +59,18 @@ public class BluetoothMediaDevice extends MediaDevice { public Drawable getIcon() { final Pair pair = BluetoothUtils .getBtRainbowDrawableWithDescription(mContext, mCachedDevice); - return pair.first; + return isFastPairDevice() + ? pair.first + : BluetoothUtils.buildBtRainbowDrawable(mContext, + mContext.getDrawable(R.drawable.ic_headphone), + mCachedDevice.getAddress().hashCode()); } @Override public Drawable getIconWithoutBackground() { - return BluetoothUtils.getBtDrawableWithDescription(mContext, mCachedDevice).first; + return isFastPairDevice() + ? BluetoothUtils.getBtDrawableWithDescription(mContext, mCachedDevice).first + : mContext.getDrawable(R.drawable.ic_headphone); } @Override diff --git a/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java b/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java index 22dc90643128..8d6bc5c97228 100644 --- a/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java +++ b/packages/SettingsLib/src/com/android/settingslib/media/InfoMediaDevice.java @@ -73,9 +73,11 @@ public class InfoMediaDevice extends MediaDevice { resId = R.drawable.ic_media_group_device; break; case TYPE_REMOTE_TV: + resId = R.drawable.ic_media_display_device; + break; case TYPE_REMOTE_SPEAKER: default: - resId = R.drawable.ic_media_device; + resId = R.drawable.ic_media_speaker_device; break; } return resId; diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InfoMediaDeviceTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InfoMediaDeviceTest.java index 685c834ff328..49b236a2188f 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InfoMediaDeviceTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/media/InfoMediaDeviceTest.java @@ -95,11 +95,13 @@ public class InfoMediaDeviceTest { public void getDrawableResId_returnCorrectResId() { when(mRouteInfo.getType()).thenReturn(TYPE_REMOTE_TV); - assertThat(mInfoMediaDevice.getDrawableResId()).isEqualTo(R.drawable.ic_media_device); + assertThat(mInfoMediaDevice.getDrawableResId()).isEqualTo( + R.drawable.ic_media_display_device); when(mRouteInfo.getType()).thenReturn(TYPE_REMOTE_SPEAKER); - assertThat(mInfoMediaDevice.getDrawableResId()).isEqualTo(R.drawable.ic_media_device); + assertThat(mInfoMediaDevice.getDrawableResId()).isEqualTo( + R.drawable.ic_media_speaker_device); when(mRouteInfo.getType()).thenReturn(TYPE_GROUP); -- cgit v1.2.3-59-g8ed1b