From 55c532525b4a20773c733049cda110fbe8d74568 Mon Sep 17 00:00:00 2001 From: Lee Shombert Date: Tue, 5 Dec 2023 16:22:44 -0800 Subject: Move AnrTimer to com.android.server.util Move the new AnrTimer class from services.am to the android server utility package. This moves code around but changes no functionality except that the unit test is simplified. The simplification is in preparation for a complete reworking of the feature code. Test: atest * FrameworksServicesTests:com.android.server.am * FrameworksServicesTests:com.android.server.utils * FrameworksMockingServicesTests:com.android.server.am Bug: 282428924 Change-Id: Ic1cdf6832e6ddd04d1bfc0e8883ae3aed9c53262 --- services/core/Android.bp | 1 + .../java/com/android/server/am/ActiveServices.java | 1 + .../android/server/am/ActivityManagerService.java | 1 + .../core/java/com/android/server/am/AnrTimer.java | 1027 -------------------- .../server/am/BroadcastQueueModernImpl.java | 1 + .../core/java/com/android/server/am/flags.aconfig | 8 - .../core/java/com/android/server/utils/Android.bp | 10 + .../java/com/android/server/utils/AnrTimer.java | 1027 ++++++++++++++++++++ .../java/com/android/server/utils/flags.aconfig | 9 + .../src/com/android/server/am/AnrTimerTest.java | 389 -------- .../src/com/android/server/utils/AnrTimerTest.java | 203 ++++ 11 files changed, 1253 insertions(+), 1424 deletions(-) delete mode 100644 services/core/java/com/android/server/am/AnrTimer.java create mode 100644 services/core/java/com/android/server/utils/Android.bp create mode 100644 services/core/java/com/android/server/utils/AnrTimer.java create mode 100644 services/core/java/com/android/server/utils/flags.aconfig delete mode 100644 services/tests/servicestests/src/com/android/server/am/AnrTimerTest.java create mode 100644 services/tests/servicestests/src/com/android/server/utils/AnrTimerTest.java diff --git a/services/core/Android.bp b/services/core/Android.bp index 3323d0ba64dd..45a582376c26 100644 --- a/services/core/Android.bp +++ b/services/core/Android.bp @@ -202,6 +202,7 @@ java_library_static { "biometrics_flags_lib", "am_flags_lib", "com_android_wm_shell_flags_lib", + "com.android.server.utils_aconfig-java", "service-jobscheduler-deviceidle.flags-aconfig-java", ], javac_shard_size: 50, diff --git a/services/core/java/com/android/server/am/ActiveServices.java b/services/core/java/com/android/server/am/ActiveServices.java index 5f1a7e7e8123..71916843fe0b 100644 --- a/services/core/java/com/android/server/am/ActiveServices.java +++ b/services/core/java/com/android/server/am/ActiveServices.java @@ -241,6 +241,7 @@ import com.android.server.am.LowMemDetector.MemFactor; import com.android.server.am.ServiceRecord.ShortFgsInfo; import com.android.server.pm.KnownPackages; import com.android.server.uri.NeededUriGrants; +import com.android.server.utils.AnrTimer; import com.android.server.wm.ActivityServiceConnectionsHolder; import java.io.FileDescriptor; diff --git a/services/core/java/com/android/server/am/ActivityManagerService.java b/services/core/java/com/android/server/am/ActivityManagerService.java index b87d02d86c22..720e99cd4fcd 100644 --- a/services/core/java/com/android/server/am/ActivityManagerService.java +++ b/services/core/java/com/android/server/am/ActivityManagerService.java @@ -475,6 +475,7 @@ import com.android.server.sdksandbox.SdkSandboxManagerLocal; import com.android.server.uri.GrantUri; import com.android.server.uri.NeededUriGrants; import com.android.server.uri.UriGrantsManagerInternal; +import com.android.server.utils.AnrTimer; import com.android.server.utils.PriorityDump; import com.android.server.utils.Slogf; import com.android.server.utils.TimingsTraceAndSlog; diff --git a/services/core/java/com/android/server/am/AnrTimer.java b/services/core/java/com/android/server/am/AnrTimer.java deleted file mode 100644 index 3e17930e3cb9..000000000000 --- a/services/core/java/com/android/server/am/AnrTimer.java +++ /dev/null @@ -1,1027 +0,0 @@ -/* - * Copyright (C) 2023 The Android Open Source Project - * - * Licensed under the Apache License, Version 2.0 (the "License"); - * you may not use this file except in compliance with the License. - * You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ - -package com.android.server.am; - -import static android.text.TextUtils.formatSimple; - -import android.annotation.IntDef; -import android.annotation.NonNull; -import android.annotation.Nullable; -import android.os.Handler; -import android.os.Looper; -import android.os.Message; -import android.os.Process; -import android.os.SystemClock; -import android.os.Trace; -import android.text.TextUtils; -import android.text.format.TimeMigrationUtils; -import android.util.ArrayMap; -import android.util.IndentingPrintWriter; -import android.util.Log; -import android.util.MathUtils; -import android.util.SparseArray; - -import com.android.internal.annotations.GuardedBy; -import com.android.internal.annotations.Keep; -import com.android.internal.annotations.VisibleForTesting; -import com.android.internal.os.ProcessCpuTracker; -import com.android.internal.util.RingBuffer; - -import java.io.PrintWriter; -import java.lang.ref.WeakReference; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Objects; -import java.util.concurrent.atomic.AtomicInteger; - -/** - * This class managers AnrTimers. An AnrTimer is a substitute for a delayed Message. In legacy - * mode, the timer just sends a delayed message. In modern mode, the timer is implemented in - * native code; on expiration, the message is sent without delay. - * - *

There are four external operations on a timer: - *