From dc21a33a80fedffe332e1347bde8c1933dd4f4c2 Mon Sep 17 00:00:00 2001
From: Riddle Hsu <riddlehsu@google.com>
Date: Thu, 14 Jan 2021 18:09:32 +0800
Subject: Do not abort launch logger by invisible drawn activity

For a special complex case: A no-display trampoline activity
launches main activity in the same task (no starting window),
and then the main activity launches trampoline and main again
consecutively. If the drawn event of main is reported before
the 2nd launch of main, the launch event log will be canceled
by seeing the drawn state before transition.

Because there will be a transition to commit window visibility,
the case can be addressed by allowing invisible drawn activity
as a valid launch event. Then the launch time can be reported
when notifying transition starting.

Bug: 176687862
Test: ActivityMetricsLaunchObserverTests#testActivityDrawnBeforeTransition

Change-Id: I81ec1695038216490537bdac6defcd9e6d75e1f8
---
 .../com/android/server/wm/ActivityMetricsLogger.java     |  4 ++--
 .../server/wm/ActivityMetricsLaunchObserverTests.java    | 16 ++++++++++++++++
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/services/core/java/com/android/server/wm/ActivityMetricsLogger.java b/services/core/java/com/android/server/wm/ActivityMetricsLogger.java
index 03cf021d0e9b..6bca4843e009 100644
--- a/services/core/java/com/android/server/wm/ActivityMetricsLogger.java
+++ b/services/core/java/com/android/server/wm/ActivityMetricsLogger.java
@@ -288,7 +288,7 @@ class ActivityMetricsLogger {
                 return;
             }
             mLastLaunchedActivity = r;
-            if (!r.noDisplay) {
+            if (!r.noDisplay && !r.isReportedDrawn()) {
                 if (DEBUG_METRICS) Slog.i(TAG, "Add pending draw " + r);
                 mPendingDrawActivities.add(r);
             }
@@ -576,7 +576,7 @@ class ActivityMetricsLogger {
                     + " processSwitch=" + processSwitch + " info=" + info);
         }
 
-        if (launchedActivity.isReportedDrawn()) {
+        if (launchedActivity.isReportedDrawn() && launchedActivity.isVisible()) {
             // Launched activity is already visible. We cannot measure windows drawn delay.
             abort(info, "launched activity already visible");
             return;
diff --git a/services/tests/wmtests/src/com/android/server/wm/ActivityMetricsLaunchObserverTests.java b/services/tests/wmtests/src/com/android/server/wm/ActivityMetricsLaunchObserverTests.java
index f1dc098fccf6..6b69ee921c8b 100644
--- a/services/tests/wmtests/src/com/android/server/wm/ActivityMetricsLaunchObserverTests.java
+++ b/services/tests/wmtests/src/com/android/server/wm/ActivityMetricsLaunchObserverTests.java
@@ -350,6 +350,22 @@ public class ActivityMetricsLaunchObserverTests extends WindowTestsBase {
         verifyNoMoreInteractions(mLaunchObserver);
     }
 
+    @Test
+    public void testActivityDrawnBeforeTransition() {
+        mTopActivity.setVisible(false);
+        notifyActivityLaunching(mTopActivity.intent);
+        // Assume the activity is launched the second time consecutively. The drawn event is from
+        // the first time (omitted in test) launch that is earlier than transition.
+        doReturn(true).when(mTopActivity).isReportedDrawn();
+        notifyWindowsDrawn(mTopActivity);
+        notifyActivityLaunched(START_SUCCESS, mTopActivity);
+        // If the launching activity was drawn when starting transition, the launch event should
+        // be reported successfully.
+        notifyTransitionStarting(mTopActivity);
+
+        verifyOnActivityLaunchFinished(mTopActivity);
+    }
+
     @Test
     public void testActivityRecordProtoIsNotTooBig() {
         // The ActivityRecordProto must not be too big, otherwise converting it at runtime
-- 
cgit v1.2.3-59-g8ed1b