From 549f19a8a5653972af79f39178091d985e757407 Mon Sep 17 00:00:00 2001 From: Alejandro Nijamkin Date: Tue, 8 Aug 2023 17:35:41 -0700 Subject: Fixes @Nullable issues in System UI and WMShell. Test: followed these steps: 1. Patched in https://r.android.com/2688146 2. m sysuig 3. Fix compilation issues 4. Repeat 2 and 3 until done Fix: 294098415 Change-Id: I74cc61fd87819be7302590d788c3c230bff57544 Merged-In: I74cc61fd87819be7302590d788c3c230bff57544 (cherry picked from commit 162280b4f9f21673b2450551647d95d5c84e7569) --- .../wm/shell/bubbles/ManageEducationView.kt | 8 +++--- .../android/wm/shell/bubbles/StackEducationView.kt | 6 ++--- .../wm/shell/desktopmode/DesktopTasksController.kt | 30 ++++++++++++---------- ...topModeAppControlsWindowDecorationViewHolder.kt | 18 +++++++------ ...DesktopModeFocusedWindowDecorationViewHolder.kt | 11 ++++---- .../DesktopModeWindowDecorationViewHolder.kt | 5 +++- .../systemui/animation/DialogLaunchAnimator.kt | 10 ++++---- .../GhostedViewLaunchAnimatorController.kt | 7 ++--- .../android/systemui/animation/LaunchAnimator.kt | 4 +-- .../com/android/systemui/animation/TextAnimator.kt | 12 +++++---- .../systemui/animation/ViewHierarchyAnimator.kt | 2 +- .../com/android/systemui/plugins/WeatherData.kt | 2 +- .../testing/screenshot/ViewScreenshotTestRule.kt | 3 ++- .../systemui/shared/system/ActivityManagerKt.kt | 2 +- .../shared/system/smartspace/SmartspaceState.kt | 10 ++++---- .../util/NaturalRotationUnfoldProgressProvider.kt | 2 +- .../android/keyguard/BouncerKeyguardMessageArea.kt | 4 +-- .../com/android/keyguard/ClockEventController.kt | 8 +++--- .../keyguard/KeyguardStatusViewController.java | 1 + .../systemui/biometrics/AuthRippleController.kt | 2 +- .../android/systemui/biometrics/AuthRippleView.kt | 18 ++++++------- .../systemui/biometrics/SideFpsController.kt | 4 +-- .../systemui/biometrics/UdfpsFpmEmptyView.kt | 3 ++- .../domain/interactor/CredentialInteractor.kt | 13 ++++++---- .../biometrics/ui/CredentialPasswordView.kt | 2 +- .../biometrics/ui/binder/BiometricViewBinder.kt | 22 ++++++++-------- .../ui/binder/BiometricViewSizeBinder.kt | 4 +-- .../charging/WiredChargingRippleController.kt | 6 ++--- .../systemui/classifier/FalsingA11yDelegate.kt | 2 +- .../ui/data/repository/ConfigurationRepository.kt | 2 +- .../android/systemui/contrast/ContrastDialog.kt | 6 ++--- .../controls/controller/ControlsControllerImpl.kt | 2 +- .../management/ControlsFavoritingActivity.kt | 2 +- .../systemui/controls/ui/ChallengeDialogs.kt | 10 +++----- .../systemui/controls/ui/ControlViewHolder.kt | 6 ++--- .../android/systemui/controls/ui/DetailDialog.kt | 8 +++--- .../com/android/systemui/controls/ui/RenderInfo.kt | 3 ++- .../android/systemui/controls/ui/StatusBehavior.kt | 6 ++--- .../systemui/controls/ui/ToggleRangeBehavior.kt | 4 +-- .../backlight/ui/view/KeyboardBacklightDialog.kt | 2 +- ...ickAccessWalletKeyguardQuickAffordanceConfig.kt | 8 +++--- .../repository/DeviceEntryFaceAuthRepository.kt | 2 +- .../data/repository/LightRevealScrimRepository.kt | 3 ++- .../ui/binder/KeyguardBottomAreaViewBinder.kt | 2 +- .../keyguard/ui/preview/KeyguardPreviewRenderer.kt | 2 +- .../systemui/lifecycle/RepeatWhenAttached.kt | 4 +-- .../controls/models/player/SeekBarViewModel.kt | 4 +-- .../media/controls/pipeline/MediaDataFilter.kt | 10 ++------ .../media/controls/pipeline/MediaDataManager.kt | 19 +++++++------- .../controls/pipeline/MediaSessionBasedFilter.kt | 10 +++++--- .../media/controls/ui/IlluminationDrawable.kt | 2 +- .../media/controls/ui/LightSourceDrawable.kt | 11 +++----- .../controls/ui/MediaCarouselScrollHandler.kt | 8 +++--- .../media/controls/ui/MediaHierarchyManager.kt | 10 ++++---- .../systemui/media/controls/ui/MediaHost.kt | 4 +-- .../systemui/media/controls/ui/SquigglyProgress.kt | 2 +- .../receiver/MediaTttChipControllerReceiver.kt | 4 +-- .../receiver/MediaTttReceiverRippleController.kt | 4 +-- .../receiver/ReceiverChipRippleView.kt | 4 +-- .../sender/MediaTttSenderCoordinator.kt | 2 +- .../view/MediaProjectionRecentsViewController.kt | 2 +- .../systemui/people/ui/view/PeopleViewBinder.kt | 4 +-- .../BaseScreenSharePermissionDialog.kt | 18 ++++++------- .../screenrecord/ScreenRecordPermissionDialog.kt | 8 +++--- .../systemui/shade/ShadeHeaderController.kt | 14 +++++----- .../src/com/android/systemui/shade/ShadeModule.kt | 20 +++++++-------- .../systemui/statusbar/BatteryStatusChip.kt | 4 +-- .../android/systemui/statusbar/LightRevealScrim.kt | 11 ++++---- .../LockscreenShadeTransitionController.kt | 2 +- .../systemui/statusbar/MediaArtworkProcessor.kt | 2 +- .../statusbar/NotificationShadeDepthController.kt | 2 +- .../statusbar/events/PrivacyDotViewController.kt | 4 +-- .../lockscreen/LockscreenSmartspaceController.kt | 6 ++++- .../statusbar/notification/ViewGroupFadeHelper.kt | 2 +- .../notification/row/ChannelEditorListView.kt | 14 +++++----- .../statusbar/phone/ActivityStarterImpl.kt | 4 +-- .../statusbar/phone/KeyguardBottomAreaView.kt | 3 ++- .../phone/PhoneStatusBarViewController.kt | 4 +-- .../phone/StatusBarContentInsetsProvider.kt | 8 +++--- .../phone/UnlockedScreenOffAnimationController.kt | 8 +++--- .../userswitcher/StatusBarUserSwitcherContainer.kt | 4 +-- .../policy/DeviceControlsControllerImpl.kt | 6 +++-- .../com/android/systemui/stylus/StylusManager.kt | 4 +-- .../systemui/user/UserSwitcherFullscreenDialog.kt | 2 +- .../android/systemui/user/UserSwitcherPopupMenu.kt | 28 ++++++++++---------- .../user/legacyhelper/ui/LegacyUserUiHelper.kt | 2 +- .../systemui/util/animation/TransitionLayout.kt | 8 +++--- .../systemui/biometrics/SideFpsControllerTest.kt | 2 +- .../systemui/shade/ShadeHeaderControllerTest.kt | 10 ++++---- 89 files changed, 302 insertions(+), 291 deletions(-) diff --git a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt index e95e8e5cdaea..1b41f793311d 100644 --- a/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt +++ b/libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/ManageEducationView.kt @@ -41,9 +41,9 @@ class ManageEducationView constructor(context: Context, positioner: BubblePositi private val ANIMATE_DURATION: Long = 200 private val positioner: BubblePositioner = positioner - private val manageView by lazy { findViewById(R.id.manage_education_view) } - private val manageButton by lazy { findViewById