From 91598903f5bffd60076dc8a9dd918c0fbaadae3f Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Thu, 28 Oct 2021 16:13:57 -0700 Subject: Fix overlapping alpha of shade pull down The brightness slider and media player had overlapping elements that made the alpha animation janky. We now avoid it by caching them as a texture. Test: visual Bug: 199047412 Change-Id: I65871e9931dec2238fda1dc0aa22ff7830098f96 --- packages/SystemUI/src/com/android/systemui/media/PlayerViewHolder.kt | 1 + .../com/android/systemui/settings/brightness/BrightnessSliderView.java | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/SystemUI/src/com/android/systemui/media/PlayerViewHolder.kt b/packages/SystemUI/src/com/android/systemui/media/PlayerViewHolder.kt index f32dad632721..042a337322e9 100644 --- a/packages/SystemUI/src/com/android/systemui/media/PlayerViewHolder.kt +++ b/packages/SystemUI/src/com/android/systemui/media/PlayerViewHolder.kt @@ -106,6 +106,7 @@ class PlayerViewHolder private constructor(itemView: View) { */ @JvmStatic fun create(inflater: LayoutInflater, parent: ViewGroup): PlayerViewHolder { val mediaView = inflater.inflate(R.layout.media_view, parent, false) + mediaView.setLayerType(View.LAYER_TYPE_HARDWARE, null) // Because this media view (a TransitionLayout) is used to measure and layout the views // in various states before being attached to its parent, we can't depend on the default // LAYOUT_DIRECTION_INHERIT to correctly resolve the ltr direction. diff --git a/packages/SystemUI/src/com/android/systemui/settings/brightness/BrightnessSliderView.java b/packages/SystemUI/src/com/android/systemui/settings/brightness/BrightnessSliderView.java index 15aa2b730adf..0e037ad56257 100644 --- a/packages/SystemUI/src/com/android/systemui/settings/brightness/BrightnessSliderView.java +++ b/packages/SystemUI/src/com/android/systemui/settings/brightness/BrightnessSliderView.java @@ -60,6 +60,7 @@ public class BrightnessSliderView extends FrameLayout { @Override protected void onFinishInflate() { super.onFinishInflate(); + setLayerType(LAYER_TYPE_HARDWARE, null); mSlider = requireViewById(R.id.slider); mSlider.setAccessibilityLabel(getContentDescription().toString()); -- cgit v1.2.3-59-g8ed1b