From 98cbf05bda481c0420f02d15d6ba36043883861a Mon Sep 17 00:00:00 2001 From: Austin Delgado Date: Fri, 11 Aug 2023 11:10:08 -0700 Subject: Update BP strings Updates the BP strings for unlock error and unlock succeeded Bug: 291960666 Test: atest SystemUITests:com.android.systemui.biometrics Change-Id: I914d2d0418a741e1764418f71461e8bf00567bde --- core/res/res/values/strings.xml | 2 ++ core/res/res/values/symbols.xml | 1 + .../SystemUI/src/com/android/systemui/biometrics/AuthController.java | 5 +++-- .../com/android/systemui/biometrics/ui/binder/BiometricViewBinder.kt | 2 +- .../src/com/android/systemui/biometrics/AuthControllerTest.java | 3 +-- 5 files changed, 8 insertions(+), 5 deletions(-) diff --git a/core/res/res/values/strings.xml b/core/res/res/values/strings.xml index 79426c8311ab..dfff8d4d28ff 100644 --- a/core/res/res/values/strings.xml +++ b/core/res/res/values/strings.xml @@ -1835,6 +1835,8 @@ Fingerprint not recognized Fingerprint not recognized + + Can\u2019t recognize face. Use fingerprint instead. Fingerprint authenticated diff --git a/core/res/res/values/symbols.xml b/core/res/res/values/symbols.xml index cafa74e7250b..4213190a4ac2 100644 --- a/core/res/res/values/symbols.xml +++ b/core/res/res/values/symbols.xml @@ -2591,6 +2591,7 @@ + diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java b/packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java index 96b144731a1b..2ca4f0cfe3b1 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java +++ b/packages/SystemUI/src/com/android/systemui/biometrics/AuthController.java @@ -88,6 +88,8 @@ import com.android.systemui.statusbar.CommandQueue; import com.android.systemui.util.concurrency.DelayableExecutor; import com.android.systemui.util.concurrency.Execution; +import kotlin.Unit; + import java.io.PrintWriter; import java.util.ArrayList; import java.util.Arrays; @@ -101,7 +103,6 @@ import java.util.Set; import javax.inject.Inject; import javax.inject.Provider; -import kotlin.Unit; import kotlinx.coroutines.CoroutineScope; /** @@ -1036,7 +1037,7 @@ public class AuthController implements CoreStartable, CommandQueue.Callbacks, final int userId = mCurrentDialogArgs.argi1; if (isFaceAuthEnrolled(userId) && isFingerprintEnrolled(userId)) { messageRes = modality == TYPE_FACE - ? R.string.biometric_face_not_recognized + ? R.string.fingerprint_dialog_use_fingerprint_instead : R.string.fingerprint_error_not_match; } else { messageRes = R.string.biometric_not_recognized; diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/BiometricViewBinder.kt b/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/BiometricViewBinder.kt index ac1d6a4765f4..40bb8715f8c5 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/BiometricViewBinder.kt +++ b/packages/SystemUI/src/com/android/systemui/biometrics/ui/binder/BiometricViewBinder.kt @@ -486,7 +486,7 @@ private class Spaghetti( modalities.hasFaceAndFingerprint && (viewModel.fingerprintStartMode.first() != FingerprintStartMode.Pending) && (authenticatedModality == BiometricModality.Face) -> - R.string.biometric_dialog_tap_confirm_with_face + R.string.biometric_dialog_tap_confirm_with_face_alt_1 else -> null } diff --git a/packages/SystemUI/tests/src/com/android/systemui/biometrics/AuthControllerTest.java b/packages/SystemUI/tests/src/com/android/systemui/biometrics/AuthControllerTest.java index 0a73a9eba9ee..8278135b2f9f 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/biometrics/AuthControllerTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/biometrics/AuthControllerTest.java @@ -99,7 +99,6 @@ import com.android.systemui.flags.FakeFeatureFlags; import com.android.systemui.flags.Flags; import com.android.systemui.keyguard.WakefulnessLifecycle; import com.android.systemui.statusbar.CommandQueue; -import com.android.systemui.statusbar.VibratorHelper; import com.android.systemui.util.concurrency.DelayableExecutor; import com.android.systemui.util.concurrency.Execution; import com.android.systemui.util.concurrency.FakeExecution; @@ -515,7 +514,7 @@ public class AuthControllerTest extends SysuiTestCase { assertThat(mModalityCaptor.getValue().intValue()).isEqualTo(modality); assertThat(mMessageCaptor.getValue()).isEqualTo( - mContext.getString(R.string.biometric_face_not_recognized)); + mContext.getString(R.string.fingerprint_dialog_use_fingerprint_instead)); } @Test -- cgit v1.2.3-59-g8ed1b