From f19ce4af1df13a5230c8e05246ab691400821052 Mon Sep 17 00:00:00 2001 From: Jay Aliomer Date: Tue, 17 Dec 2019 15:04:15 -0500 Subject: Dark theme battery saver tile secondary text Dark theme tile on battery saver should show "Dark theme" and "Battery saver" on two lines Test: manual. turn battery saver on while dark theme on auto Fixes: 146439388 Change-Id: I460b582ca7fcf244b406d6eaf70c10e4edc52d85 --- packages/SystemUI/res/values/strings.xml | 4 ++-- .../src/com/android/systemui/qs/tiles/UiModeNightTile.java | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/res/values/strings.xml b/packages/SystemUI/res/values/strings.xml index be1623b18826..69f661e37da1 100644 --- a/packages/SystemUI/res/values/strings.xml +++ b/packages/SystemUI/res/values/strings.xml @@ -892,8 +892,8 @@ Until %s Dark theme - - Dark theme\nBattery saver + + Battery saver On at sunset diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/UiModeNightTile.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/UiModeNightTile.java index 54fbaf361745..107958f49b91 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/tiles/UiModeNightTile.java +++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/UiModeNightTile.java @@ -91,7 +91,10 @@ public class UiModeNightTile extends QSTileImpl implements boolean nightMode = (mContext.getResources().getConfiguration().uiMode & Configuration.UI_MODE_NIGHT_MASK) == Configuration.UI_MODE_NIGHT_YES; - if (isAuto && !powerSave) { + if (powerSave) { + state.secondaryLabel = mContext.getResources().getString( + R.string.quick_settings_dark_mode_secondary_label_battery_saver); + } else if (isAuto) { state.secondaryLabel = mContext.getResources().getString(nightMode ? R.string.quick_settings_dark_mode_secondary_label_until_sunrise : R.string.quick_settings_dark_mode_secondary_label_on_at_sunset); @@ -99,9 +102,7 @@ public class UiModeNightTile extends QSTileImpl implements state.secondaryLabel = null; } state.value = nightMode; - state.label = mContext.getString(powerSave - ? R.string.quick_settings_ui_mode_night_label_battery_saver - : R.string.quick_settings_ui_mode_night_label); + state.label = mContext.getString(R.string.quick_settings_ui_mode_night_label); state.icon = mIcon; state.contentDescription = TextUtils.isEmpty(state.secondaryLabel) ? state.label -- cgit v1.2.3-59-g8ed1b