From 9c1f79f75d76fd4700deba21a28ce54fe3489b0c Mon Sep 17 00:00:00 2001 From: Greg Kaiser Date: Tue, 19 Jan 2021 07:35:49 -0800 Subject: RuntimeShader: Invoke va_end() We locally cache our return value so we can call va_end() prior to returning. Test: TreeHugger Change-Id: Ieb453512a39e8f229db006a31ce8e7e7ec69e882 --- libs/hwui/jni/Shader.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libs/hwui/jni/Shader.cpp b/libs/hwui/jni/Shader.cpp index ad3fd552204e..1dc5cd99eed1 100644 --- a/libs/hwui/jni/Shader.cpp +++ b/libs/hwui/jni/Shader.cpp @@ -269,8 +269,9 @@ static jlong RuntimeShader_create(JNIEnv* env, jobject, jlong shaderBuilder, jlo static inline int ThrowIAEFmt(JNIEnv* env, const char* fmt, ...) { va_list args; va_start(args, fmt); - return jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", fmt, args); + int ret = jniThrowExceptionFmt(env, "java/lang/IllegalArgumentException", fmt, args); va_end(args); + return ret; } static void RuntimeShader_updateUniforms(JNIEnv* env, jobject, jlong shaderBuilder, -- cgit v1.2.3-59-g8ed1b