From 95f3c1dbc20ac2ab8990e5ab213238679bd21c23 Mon Sep 17 00:00:00 2001
From: Rubin Xu <rubinxu@google.com>
Date: Mon, 10 Feb 2020 17:49:29 +0000
Subject: Throw exception when gatekeeper fails

This is a non-recoverable system internal error and let's make the
failure loud and clear.

Bug: 148159520
Test: atest com.android.server.locksettings
Change-Id: I38737113d9d06862077b873548dbdfe025578cdd
---
 .../com/android/server/locksettings/SyntheticPasswordManager.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java b/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java
index b726e571cf0c..ac49fa293fe7 100644
--- a/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java
+++ b/services/core/java/com/android/server/locksettings/SyntheticPasswordManager.java
@@ -590,8 +590,8 @@ public class SyntheticPasswordManager {
             throw new IllegalStateException("Failed to create new SID for user", e);
         }
         if (response.getResponseCode() != GateKeeperResponse.RESPONSE_OK) {
-            Slog.e(TAG, "Fail to create new SID for user " + userId);
-            return;
+            throw new IllegalStateException("Fail to create new SID for user " + userId
+                    + " response: " + response.getResponseCode());
         }
         saveSyntheticPasswordHandle(response.getPayload(), userId);
     }
-- 
cgit v1.2.3-59-g8ed1b