From 0156867544453076a7bb55194cbbdc87edbb7fd5 Mon Sep 17 00:00:00 2001 From: Nancy Chen Date: Fri, 29 Aug 2014 15:53:29 -0700 Subject: Remove onConnectionAdded/Removed() from ConnectionService API These methods are redundant because there are already other methods listening to the connection adding and removing. Bug: 17262026 Change-Id: I1c87af539932673a11e5ceee62755c2aec6aa43f --- .../java/android/telecomm/ConnectionService.java | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/telecomm/java/android/telecomm/ConnectionService.java b/telecomm/java/android/telecomm/ConnectionService.java index 46968151bcfb..07702a00c346 100644 --- a/telecomm/java/android/telecomm/ConnectionService.java +++ b/telecomm/java/android/telecomm/ConnectionService.java @@ -819,24 +819,6 @@ public abstract class ConnectionService extends Service { */ public void onConference(Connection connection1, Connection connection2) {} - /** - * Notifies that a connection has been added to this connection service and sent to Telecomm. - * - * @param connection The connection which was added. - */ - public void onConnectionAdded(Connection connection) {} - - /** - * Notified that a connection has been removed from this connection service. - *

- * TODO: Deprecate this since we can listen to the Connection onDestroyed() to determine when - * it is destroyed. This then percolates down to the RemoteConference stuff, where we can also - * have a callback for one being added, but we don't need one for being destroyed. - * - * @param connection The connection which was removed. - */ - public void onConnectionRemoved(Connection connection) {} - public void onRemoteConferenceAdded(RemoteConference conference) {} /** @@ -864,7 +846,6 @@ public abstract class ConnectionService extends Service { mIdByConnection.put(connection, callId); connection.addConnectionListener(mConnectionListener); connection.setConnectionService(this); - onConnectionAdded(connection); } private void removeConnection(Connection connection) { @@ -873,7 +854,6 @@ public abstract class ConnectionService extends Service { connection.removeConnectionListener(mConnectionListener); mConnectionById.remove(mIdByConnection.get(connection)); mIdByConnection.remove(connection); - onConnectionRemoved(connection); mAdapter.removeCall(id); } -- cgit v1.2.3-59-g8ed1b