From 86b391cd03ba2c3e71e78ce2ccf8dd073ac409cf Mon Sep 17 00:00:00 2001 From: Christopher Tate Date: Fri, 13 Sep 2013 16:58:36 -0700 Subject: Prune shared users that the system declares but does not use Bug 10184643 Change-Id: I72c5177c621c24fac34bf8744eb6c5108b6d3464 --- .../java/com/android/server/pm/PackageManagerService.java | 3 +++ services/java/com/android/server/pm/Settings.java | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/services/java/com/android/server/pm/PackageManagerService.java b/services/java/com/android/server/pm/PackageManagerService.java index 39fc4ad3ba37..7cc568e25d99 100755 --- a/services/java/com/android/server/pm/PackageManagerService.java +++ b/services/java/com/android/server/pm/PackageManagerService.java @@ -1349,6 +1349,9 @@ public class PackageManagerService extends IPackageManager.Stub { //delete tmp files deleteTempPackageFiles(); + // Remove any shared userIDs that have no associated packages + mSettings.pruneSharedUsersLPw(); + if (!mOnlyCore) { EventLog.writeEvent(EventLogTags.BOOT_PROGRESS_PMS_DATA_SCAN_START, SystemClock.uptimeMillis()); diff --git a/services/java/com/android/server/pm/Settings.java b/services/java/com/android/server/pm/Settings.java index 92026b2bb6ba..8e0c92a2084f 100644 --- a/services/java/com/android/server/pm/Settings.java +++ b/services/java/com/android/server/pm/Settings.java @@ -351,6 +351,19 @@ final class Settings { return null; } + void pruneSharedUsersLPw() { + ArrayList removeStage = new ArrayList(); + for (Map.Entry entry : mSharedUsers.entrySet()) { + final SharedUserSetting sus = entry.getValue(); + if (sus == null || sus.packages.size() == 0) { + removeStage.add(entry.getKey()); + } + } + for (int i = 0; i < removeStage.size(); i++) { + mSharedUsers.remove(removeStage.get(i)); + } + } + // Transfer ownership of permissions from one package to another. void transferPermissionsLPw(String origPkg, String newPkg) { // Transfer ownership of permissions to the new package. -- cgit v1.2.3-59-g8ed1b