From aa19d5e49e6258bc85fa7121fe489b63926ecfcc Mon Sep 17 00:00:00 2001 From: Adam Lesinski Date: Fri, 15 Jul 2016 17:49:49 -0700 Subject: Deprecate Resources constructor and updateConfiguration() method These methods were never meant to be public. Instead, developers can use Context#createConfigurationContext(). Bug:30088019 Bug:29999297 Change-Id: I2b864136163deda0af99fa3bfe9ef4ee1077341a --- api/current.txt | 4 ++-- api/system-current.txt | 4 ++-- api/test-current.txt | 4 ++-- core/java/android/content/res/Resources.java | 7 +++++++ 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/api/current.txt b/api/current.txt index d3ee682370b9..c0fd25b1fdd8 100644 --- a/api/current.txt +++ b/api/current.txt @@ -10321,7 +10321,7 @@ package android.content.res { } public class Resources { - ctor public Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); + ctor public deprecated Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); method public final void finishPreloading(); method public final void flushLayoutCache(); method public android.content.res.XmlResourceParser getAnimation(int) throws android.content.res.Resources.NotFoundException; @@ -10372,7 +10372,7 @@ package android.content.res { method public android.content.res.AssetFileDescriptor openRawResourceFd(int) throws android.content.res.Resources.NotFoundException; method public void parseBundleExtra(java.lang.String, android.util.AttributeSet, android.os.Bundle) throws org.xmlpull.v1.XmlPullParserException; method public void parseBundleExtras(android.content.res.XmlResourceParser, android.os.Bundle) throws java.io.IOException, org.xmlpull.v1.XmlPullParserException; - method public void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); + method public deprecated void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); } public static class Resources.NotFoundException extends java.lang.RuntimeException { diff --git a/api/system-current.txt b/api/system-current.txt index 13ad2d666dcb..e407eb4dc7f8 100644 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -10760,7 +10760,7 @@ package android.content.res { } public class Resources { - ctor public Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); + ctor public deprecated Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); method public final void finishPreloading(); method public final void flushLayoutCache(); method public android.content.res.XmlResourceParser getAnimation(int) throws android.content.res.Resources.NotFoundException; @@ -10811,7 +10811,7 @@ package android.content.res { method public android.content.res.AssetFileDescriptor openRawResourceFd(int) throws android.content.res.Resources.NotFoundException; method public void parseBundleExtra(java.lang.String, android.util.AttributeSet, android.os.Bundle) throws org.xmlpull.v1.XmlPullParserException; method public void parseBundleExtras(android.content.res.XmlResourceParser, android.os.Bundle) throws java.io.IOException, org.xmlpull.v1.XmlPullParserException; - method public void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); + method public deprecated void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); } public static class Resources.NotFoundException extends java.lang.RuntimeException { diff --git a/api/test-current.txt b/api/test-current.txt index c6359dd4d1e9..53f87f4a3af6 100644 --- a/api/test-current.txt +++ b/api/test-current.txt @@ -10335,7 +10335,7 @@ package android.content.res { } public class Resources { - ctor public Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); + ctor public deprecated Resources(android.content.res.AssetManager, android.util.DisplayMetrics, android.content.res.Configuration); method public final void finishPreloading(); method public final void flushLayoutCache(); method public android.content.res.XmlResourceParser getAnimation(int) throws android.content.res.Resources.NotFoundException; @@ -10386,7 +10386,7 @@ package android.content.res { method public android.content.res.AssetFileDescriptor openRawResourceFd(int) throws android.content.res.Resources.NotFoundException; method public void parseBundleExtra(java.lang.String, android.util.AttributeSet, android.os.Bundle) throws org.xmlpull.v1.XmlPullParserException; method public void parseBundleExtras(android.content.res.XmlResourceParser, android.os.Bundle) throws java.io.IOException, org.xmlpull.v1.XmlPullParserException; - method public void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); + method public deprecated void updateConfiguration(android.content.res.Configuration, android.util.DisplayMetrics); } public static class Resources.NotFoundException extends java.lang.RuntimeException { diff --git a/core/java/android/content/res/Resources.java b/core/java/android/content/res/Resources.java index 8d3940c99e0d..ad113075c96b 100644 --- a/core/java/android/content/res/Resources.java +++ b/core/java/android/content/res/Resources.java @@ -201,12 +201,16 @@ public class Resources { * Create a new Resources object on top of an existing set of assets in an * AssetManager. * + * @deprecated Resources should not be constructed by apps. + * See {@link android.content.Context#createConfigurationContext(Configuration)}. + * * @param assets Previously created AssetManager. * @param metrics Current display metrics to consider when * selecting/computing resource values. * @param config Desired device configuration to consider when * selecting/computing resource values (optional). */ + @Deprecated public Resources(AssetManager assets, DisplayMetrics metrics, Configuration config) { this(null); mResourcesImpl = new ResourcesImpl(assets, metrics, config, new DisplayAdjustments()); @@ -1762,7 +1766,10 @@ public class Resources { /** * Store the newly updated configuration. + * + * @deprecated See {@link android.content.Context#createConfigurationContext(Configuration)}. */ + @Deprecated public void updateConfiguration(Configuration config, DisplayMetrics metrics) { updateConfiguration(config, metrics, null); } -- cgit v1.2.3-59-g8ed1b