From 6dafefb0f44c4e57384e2ec3e08fefac5cc7e071 Mon Sep 17 00:00:00 2001 From: Romain Guy Date: Fri, 16 Sep 2011 16:00:59 -0700 Subject: Forces AsyncTask to use the main looper Bug #5333924 This might break applications trying to use AsyncTask on a looper that is not the main thread, but such apps would already have issues (AsyncTask has a single static handler and attempting to use AsyncTask outside of the main thread would likely result in weird threading issues in other parts of the app.) Change-Id: Ibbf480627fc7b91326a27d4f5e5af49e8c5b5115 --- core/java/android/os/AsyncTask.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/core/java/android/os/AsyncTask.java b/core/java/android/os/AsyncTask.java index 64bba54b2cee..6a512a96f373 100644 --- a/core/java/android/os/AsyncTask.java +++ b/core/java/android/os/AsyncTask.java @@ -237,6 +237,7 @@ public abstract class AsyncTask { /** @hide Used to force static handler to be created. */ public static void init() { + // TODO: This doesn't do anything, we should get rid of it sHandler.getLooper(); } @@ -254,6 +255,7 @@ public abstract class AsyncTask { mTaskInvoked.set(true); Process.setThreadPriority(Process.THREAD_PRIORITY_BACKGROUND); + //noinspection unchecked return postResult(doInBackground(mParams)); } }; @@ -288,7 +290,7 @@ public abstract class AsyncTask { } private Result postResult(Result result) { - Message message = sHandler.obtainMessage(MESSAGE_POST_RESULT, + @SuppressWarnings({"unchecked"}) Message message = sHandler.obtainMessage(MESSAGE_POST_RESULT, new AsyncTaskResult(this, result)); message.sendToTarget(); return result; @@ -598,6 +600,10 @@ public abstract class AsyncTask { } private static class InternalHandler extends Handler { + InternalHandler() { + super(Looper.getMainLooper()); + } + @SuppressWarnings({"unchecked", "RawUseOfParameterizedType"}) @Override public void handleMessage(Message msg) { -- cgit v1.2.3-59-g8ed1b