From c5ae595e6f71798109c730cd835a2cca79a8877c Mon Sep 17 00:00:00 2001 From: Po-Chien Hsueh Date: Thu, 9 Feb 2017 10:38:34 +0800 Subject: Remove build flag ANDROID_ENABLE_RENDERSCRIPT remove this flag and consider renderscript is always enabled Bug: 34693640 Test: compile Change-Id: I22464e1d64f2a55a60ba9f8ab1510f2811605552 --- core/jni/Android.mk | 2 ++ libs/hwui/Android.mk | 12 +++++------- libs/hwui/FontRenderer.cpp | 12 +----------- libs/hwui/FontRenderer.h | 4 ---- libs/hwui/hwui_static_deps.mk | 5 ++--- 5 files changed, 10 insertions(+), 25 deletions(-) diff --git a/core/jni/Android.mk b/core/jni/Android.mk index db3ea8c51bf4..dd2f365bb86a 100644 --- a/core/jni/Android.mk +++ b/core/jni/Android.mk @@ -203,6 +203,8 @@ LOCAL_C_INCLUDES += \ $(call include-path-for, libhardware)/hardware \ $(call include-path-for, libhardware_legacy)/hardware_legacy \ $(TOP)/frameworks/base/media/jni \ + $(TOP)/frameworks/rs/cpp \ + $(TOP)/frameworks/rs \ $(TOP)/system/core/base/include \ $(TOP)/system/core/include \ $(TOP)/system/core/libappfuse/include \ diff --git a/libs/hwui/Android.mk b/libs/hwui/Android.mk index 692199d7af1f..ff40c8a9fb92 100644 --- a/libs/hwui/Android.mk +++ b/libs/hwui/Android.mk @@ -189,13 +189,11 @@ hwui_c_includes += \ external/harfbuzz_ng/src \ external/freetype/include -ifneq (false,$(ANDROID_ENABLE_RENDERSCRIPT)) - hwui_cflags += -DANDROID_ENABLE_RENDERSCRIPT - hwui_c_includes += \ - $(call intermediates-dir-for,STATIC_LIBRARIES,TARGET,) \ - frameworks/rs/cpp \ - frameworks/rs -endif +# enable RENDERSCRIPT +hwui_c_includes += \ + $(call intermediates-dir-for,STATIC_LIBRARIES,TARGET,) \ + frameworks/rs/cpp \ + frameworks/rs # ------------------------ # static library diff --git a/libs/hwui/FontRenderer.cpp b/libs/hwui/FontRenderer.cpp index 4f9a3de64fc2..ee99018fb652 100644 --- a/libs/hwui/FontRenderer.cpp +++ b/libs/hwui/FontRenderer.cpp @@ -33,14 +33,11 @@ #include #include +#include #include #include #include -#ifdef ANDROID_ENABLE_RENDERSCRIPT -#include -#endif - namespace android { namespace uirenderer { @@ -591,17 +588,12 @@ FontRenderer::DropShadow FontRenderer::renderDropShadow(const SkPaint* paint, co return image; } -#ifdef ANDROID_ENABLE_RENDERSCRIPT // Align buffers for renderscript usage if (paddedWidth & (RS_CPU_ALLOCATION_ALIGNMENT - 1)) { paddedWidth += RS_CPU_ALLOCATION_ALIGNMENT - paddedWidth % RS_CPU_ALLOCATION_ALIGNMENT; } int size = paddedWidth * paddedHeight; uint8_t* dataBuffer = (uint8_t*) memalign(RS_CPU_ALLOCATION_ALIGNMENT, size); -#else - int size = paddedWidth * paddedHeight; - uint8_t* dataBuffer = (uint8_t*) malloc(size); -#endif memset(dataBuffer, 0, size); @@ -691,7 +683,6 @@ bool FontRenderer::renderTextOnPath(const SkPaint* paint, const Rect* clip, cons void FontRenderer::blurImage(uint8_t** image, int32_t width, int32_t height, float radius) { uint32_t intRadius = Blur::convertRadiusToInt(radius); -#ifdef ANDROID_ENABLE_RENDERSCRIPT if (width * height * intRadius >= RS_MIN_INPUT_CUTOFF && radius <= 25.0f) { uint8_t* outImage = (uint8_t*) memalign(RS_CPU_ALLOCATION_ALIGNMENT, width * height); @@ -729,7 +720,6 @@ void FontRenderer::blurImage(uint8_t** image, int32_t width, int32_t height, flo return; } } -#endif std::unique_ptr gaussian(new float[2 * intRadius + 1]); Blur::generateGaussianWeights(gaussian.get(), radius); diff --git a/libs/hwui/FontRenderer.h b/libs/hwui/FontRenderer.h index dd9c40f89ad0..329309c1cd5c 100644 --- a/libs/hwui/FontRenderer.h +++ b/libs/hwui/FontRenderer.h @@ -34,7 +34,6 @@ #include -#ifdef ANDROID_ENABLE_RENDERSCRIPT #include "RenderScript.h" namespace RSC { class Element; @@ -42,7 +41,6 @@ namespace RSC { class ScriptIntrinsicBlur; class sp; } -#endif namespace android { namespace uirenderer { @@ -201,12 +199,10 @@ private: FontCacheHistoryTracker mHistoryTracker; #endif -#ifdef ANDROID_ENABLE_RENDERSCRIPT // RS constructs RSC::sp mRs; RSC::sp mRsElement; RSC::sp mRsScript; -#endif static void computeGaussianWeights(float* weights, int32_t radius); static void horizontalBlur(float* weights, int32_t radius, const uint8_t *source, uint8_t *dest, diff --git a/libs/hwui/hwui_static_deps.mk b/libs/hwui/hwui_static_deps.mk index f69da484af43..a75fd6a8d587 100644 --- a/libs/hwui/hwui_static_deps.mk +++ b/libs/hwui/hwui_static_deps.mk @@ -28,6 +28,5 @@ LOCAL_SHARED_LIBRARIES += \ libminikin \ libandroidfw -ifneq (false,$(ANDROID_ENABLE_RENDERSCRIPT)) - LOCAL_SHARED_LIBRARIES += libRScpp -endif +# enable RENDERSCRIPT +LOCAL_SHARED_LIBRARIES += libRScpp -- cgit v1.2.3-59-g8ed1b