From bd42349f7e97f172d5496ecaf2273994ced43b0d Mon Sep 17 00:00:00 2001 From: Chih-Hung Hsieh Date: Mon, 29 Aug 2016 14:49:57 -0700 Subject: Fix google-explicit-constructor warnings in media utils. * Add explicit keyword to conversion constructors. Bug: 28341362 Test: build with WITH_TIDY=1 Change-Id: I13958693f28fae9016124a43cd211e5302ed8d51 --- media/jni/android_media_Utils.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/media/jni/android_media_Utils.h b/media/jni/android_media_Utils.h index 8184f943ce23..39c155439767 100644 --- a/media/jni/android_media_Utils.h +++ b/media/jni/android_media_Utils.h @@ -37,7 +37,7 @@ private: size_t mPosition; public: - AssetStream(SkStream* stream); + explicit AssetStream(SkStream* stream); ~AssetStream(); // Reads 'length' amount of bytes from 'offset' to 'data'. The 'data' buffer @@ -60,7 +60,7 @@ private: const size_t kMinSizeToRead = 8192; public: - BufferedStream(SkStream* stream); + explicit BufferedStream(SkStream* stream); ~BufferedStream(); // Reads 'length' amount of bytes from 'offset' to 'data'. The 'data' buffer @@ -79,8 +79,8 @@ private: size_t mPosition; public: - FileStream(const int fd); - FileStream(const String8 filename); + explicit FileStream(const int fd); + explicit FileStream(const String8 filename); ~FileStream(); // Reads 'length' amount of bytes from 'offset' to 'data'. The 'data' buffer -- cgit v1.2.3-59-g8ed1b