From 18f68b1350e8a4fba0208b38be3bc632dab5f25f Mon Sep 17 00:00:00 2001 From: Anton Potapov Date: Thu, 4 Apr 2024 19:20:46 +0100 Subject: Remove excessive volume slider ripple Flag: aconfig new_volume_panel TRUNKFOOD Test: manual on the phone. Tap on the icon at the start of the VolumeSlider Fixes: 330807799 Change-Id: I7b1dc2dff1b76d3012c354cd8b6802e6b922d069 --- .../component/volume/ui/composable/VolumeSlider.kt | 41 ++++++++++------------ 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/packages/SystemUI/compose/features/src/com/android/systemui/volume/panel/component/volume/ui/composable/VolumeSlider.kt b/packages/SystemUI/compose/features/src/com/android/systemui/volume/panel/component/volume/ui/composable/VolumeSlider.kt index d31064ae23b3..19d3f599ef31 100644 --- a/packages/SystemUI/compose/features/src/com/android/systemui/volume/panel/component/volume/ui/composable/VolumeSlider.kt +++ b/packages/SystemUI/compose/features/src/com/android/systemui/volume/panel/component/volume/ui/composable/VolumeSlider.kt @@ -17,10 +17,10 @@ package com.android.systemui.volume.panel.component.volume.ui.composable import androidx.compose.animation.core.animateFloatAsState +import androidx.compose.foundation.clickable import androidx.compose.foundation.layout.Box +import androidx.compose.foundation.layout.fillMaxSize import androidx.compose.foundation.layout.size -import androidx.compose.material3.IconButton -import androidx.compose.material3.IconButtonColors import androidx.compose.material3.LocalContentColor import androidx.compose.material3.Text import androidx.compose.runtime.Composable @@ -32,7 +32,6 @@ import androidx.compose.runtime.remember import androidx.compose.runtime.setValue import androidx.compose.ui.Alignment import androidx.compose.ui.Modifier -import androidx.compose.ui.graphics.Color import androidx.compose.ui.semantics.ProgressBarRangeInfo import androidx.compose.ui.semantics.clearAndSetSemantics import androidx.compose.ui.semantics.contentDescription @@ -130,24 +129,20 @@ private fun SliderIcon( isTappable: Boolean, modifier: Modifier = Modifier ) { - if (isTappable) { - IconButton( - modifier = modifier, - onClick = onIconTapped, - colors = - IconButtonColors( - contentColor = LocalContentColor.current, - containerColor = Color.Transparent, - disabledContentColor = LocalContentColor.current, - disabledContainerColor = Color.Transparent, - ), - content = { Icon(modifier = Modifier.size(24.dp), icon = icon) }, - ) - } else { - Box( - modifier = modifier, - contentAlignment = Alignment.Center, - content = { Icon(modifier = Modifier.size(24.dp), icon = icon) }, - ) - } + val boxModifier = + if (isTappable) { + modifier.clickable( + onClick = onIconTapped, + interactionSource = null, + indication = null + ) + } else { + modifier + } + .fillMaxSize() + Box( + modifier = boxModifier, + contentAlignment = Alignment.Center, + content = { Icon(modifier = Modifier.size(24.dp), icon = icon) }, + ) } -- cgit v1.2.3-59-g8ed1b