From 62539e9efa02c4037d3310a8b4f16f0085cd8c37 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Thu, 10 Nov 2011 09:35:38 -0800 Subject: Close file on exception as well Bug: 5458045 Change-Id: I4c79b9c273ff69dda292e5cc7b2b60f8db2edbd9 --- services/java/com/android/server/pm/Settings.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/services/java/com/android/server/pm/Settings.java b/services/java/com/android/server/pm/Settings.java index bfe6613cf630..36442a0c4fac 100644 --- a/services/java/com/android/server/pm/Settings.java +++ b/services/java/com/android/server/pm/Settings.java @@ -63,6 +63,8 @@ import java.util.HashMap; import java.util.HashSet; import java.util.Iterator; +import libcore.io.IoUtils; + /** * Holds information about dynamic settings. */ @@ -998,8 +1000,8 @@ final class Settings { FileUtils.sync(fstr); str.close(); journal.commit(); - } - catch (Exception e) { + } catch (Exception e) { + IoUtils.closeQuietly(str); journal.rollback(); } -- cgit v1.2.3-59-g8ed1b