From 5fdfd60ff76714e6978e9da87ec4321cb98b2ee7 Mon Sep 17 00:00:00 2001 From: Matt Buckley Date: Thu, 24 Aug 2023 15:56:46 +0000 Subject: Fix possible leaks in CanvasContext HintSessionWrapper Ensure the mHintSessionFuture is accounted for correctly in the destructor. Bug: b/297230599 Test: manual Change-Id: Idcbd0f2ba87290f090d693f0a64cb46fe8270b95 Merged-In: Idcbd0f2ba87290f090d693f0a64cb46fe8270b95 (cherry picked from commit ac620f64a32500890007b0b405ca72405d6db41e) --- libs/hwui/renderthread/HintSessionWrapper.cpp | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libs/hwui/renderthread/HintSessionWrapper.cpp b/libs/hwui/renderthread/HintSessionWrapper.cpp index 814ac4d90028..30e472a79926 100644 --- a/libs/hwui/renderthread/HintSessionWrapper.cpp +++ b/libs/hwui/renderthread/HintSessionWrapper.cpp @@ -93,8 +93,13 @@ HintSessionWrapper::HintSessionWrapper(pid_t uiThreadId, pid_t renderThreadId) : mUiThreadId(uiThreadId), mRenderThreadId(renderThreadId) {} HintSessionWrapper::~HintSessionWrapper() { + if (mHintSessionFuture.valid()) { + mHintSession = mHintSessionFuture.get(); + } if (mHintSession) { gAPH_closeSessionFn(mHintSession); + mSessionValid = true; + mHintSession = nullptr; } } -- cgit v1.2.3-59-g8ed1b