From 855535aa36d59758842d44f52c4cfc840f4c7f97 Mon Sep 17 00:00:00 2001 From: Alexander Roederer Date: Wed, 4 Oct 2023 21:51:23 +0000 Subject: Make RankingUpdate detailedAssertEquals detailed Currently, NotificationListenerServiceTest detailedAssertEquals on NotificationRankingUpdates just does a simple assertEquals on the ranking map references, which isn't very detailed (and doesn't actually check for true equality; two equivalent maps that have different references but identical entries will fail this assert.) Instead we should be calling detailedAssertEquals on the constitutent ranking maps instead. Test: Test only change Bug: 284297289 Change-Id: Iac4dc35f538a8baa6892affe5e1d3002f0a1e6ad --- .../android/server/notification/NotificationListenerServiceTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/tests/uiservicestests/src/com/android/server/notification/NotificationListenerServiceTest.java b/services/tests/uiservicestests/src/com/android/server/notification/NotificationListenerServiceTest.java index 7a55143ba13f..c05f81497e57 100644 --- a/services/tests/uiservicestests/src/com/android/server/notification/NotificationListenerServiceTest.java +++ b/services/tests/uiservicestests/src/com/android/server/notification/NotificationListenerServiceTest.java @@ -462,7 +462,7 @@ public class NotificationListenerServiceTest extends UiServiceTestCase { } private void detailedAssertEquals(NotificationRankingUpdate a, NotificationRankingUpdate b) { - assertEquals(a.getRankingMap(), b.getRankingMap()); + detailedAssertEquals(a.getRankingMap(), b.getRankingMap()); } private void detailedAssertEquals(String comment, Ranking a, Ranking b) { -- cgit v1.2.3-59-g8ed1b