From c29844d07236c5569663a9e0406943652b674959 Mon Sep 17 00:00:00 2001 From: George Burgess IV Date: Tue, 11 Jul 2017 17:18:26 -0700 Subject: app_main: silence static analyzer warnings This silences two warnings: frameworks/base/cmds/app_process/app_main.cpp:238:11: warning: Potential memory leak frameworks/base/cmds/app_process/app_main.cpp:261:9: warning: Potential memory leak As the (existing) comment notes, we nuke argv later in main(), so these copies are necessary. Since these args need to live for basically the entire life of the process, it seems pointless to go out of our way to free them. Bug: 27101951 Test: mma. Static analyzer warnings are gone. Change-Id: Icbfabfede9db909f6acb274b697cb6076c3fc11f --- cmds/app_process/app_main.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cmds/app_process/app_main.cpp b/cmds/app_process/app_main.cpp index 0ea141c292dd..752c2a8d7400 100644 --- a/cmds/app_process/app_main.cpp +++ b/cmds/app_process/app_main.cpp @@ -233,6 +233,9 @@ int main(int argc, char* const argv[]) for (i = 0; i < argc; i++) { if (known_command == true) { runtime.addOption(strdup(argv[i])); + // The static analyzer gets upset that we don't ever free the above + // string. Since the allocation is from main, leaking it doesn't seem + // problematic. NOLINTNEXTLINE ALOGV("app_process main add known option '%s'", argv[i]); known_command = false; continue; @@ -256,6 +259,9 @@ int main(int argc, char* const argv[]) } runtime.addOption(strdup(argv[i])); + // The static analyzer gets upset that we don't ever free the above + // string. Since the allocation is from main, leaking it doesn't seem + // problematic. NOLINTNEXTLINE ALOGV("app_process main add option '%s'", argv[i]); } -- cgit v1.2.3-59-g8ed1b