From 563721fd40028ea37a6fe34b22cbc64145a138c7 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Tue, 16 Jan 2024 20:07:34 -0800 Subject: Remove an obsolete TODO comment This is a follow up CL to my previous CL, which introduced InputMethodListBuilder with a TODO comment to enrich API document on InputMethodSubtype#overridesImplicitlyEnabledSubtype(). The concept of explicitly-enabled subtypes and implicitly-enabled subtypes are to now considered to be one of basic knowledge of Android Input Methods. At least the following API documents assume the same level of its understanding. * "allowsImplicitlyEnabledSubtypes" parameter in InputMethodManager#getEnabledInputMethodSubtypeList() * JavaDoc of InputMethodManager#setExplicitlyEnabledInputMethodSubtypes() * JavaDoc of InputMethodSubtype#overridesImplicitlyEnabledSubtype() With above let's remove this stale TODO for now. This is just a removal of a comment. There must be no observable behavior change. [1]: I871ccda787eb0f1099ba3574356c1da4b33681f3 b21220efae92a56ff7b4b781fa614a6e3a8a3007 Bug: 17347871 Bug: 18192576 Bug: 309837937 Test: presubmit Change-Id: I24ca559f48ce9b56d7348d7727bb00a063f7b8ac --- .../core/java/com/android/server/inputmethod/InputMethodInfoUtils.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/services/core/java/com/android/server/inputmethod/InputMethodInfoUtils.java b/services/core/java/com/android/server/inputmethod/InputMethodInfoUtils.java index 295793569a25..a7632519b7bc 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodInfoUtils.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodInfoUtils.java @@ -77,8 +77,6 @@ final class InputMethodInfoUtils { return this; } - // TODO: The behavior of InputMethodSubtype#overridesImplicitlyEnabledSubtype() should be - // documented more clearly. InputMethodListBuilder fillAuxiliaryImes(ArrayList imis, Context context) { // If one or more auxiliary input methods are available, OK to stop populating the list. for (final InputMethodInfo imi : mInputMethodSet) { -- cgit v1.2.3-59-g8ed1b