From 53d8776f28a030d0b7feb9840f6d00c3bbd5c689 Mon Sep 17 00:00:00 2001 From: Vaibhav Devmurari Date: Tue, 6 Dec 2022 15:08:00 +0000 Subject: Fix PK Settings notification for non-keyboard devices Refactoring CL ag/20500090 caused a side effect where all non-keyboard devices also ran default layout selection logic and showed notification to configure OK layout. Need to filter by non-virtual and full keyboards. Test: Manual Bug: 261173318 Change-Id: Ib624c19e584b7d10f9d36bc852ee9ac9ed070d0e --- services/core/java/com/android/server/input/KeyboardLayoutManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/input/KeyboardLayoutManager.java b/services/core/java/com/android/server/input/KeyboardLayoutManager.java index 85d6197ffe1c..1bb14aa6c438 100644 --- a/services/core/java/com/android/server/input/KeyboardLayoutManager.java +++ b/services/core/java/com/android/server/input/KeyboardLayoutManager.java @@ -145,7 +145,7 @@ final class KeyboardLayoutManager implements InputManager.InputDeviceListener { @Override public void onInputDeviceChanged(int deviceId) { final InputDevice inputDevice = getInputDevice(deviceId); - if (inputDevice == null) { + if (inputDevice == null || inputDevice.isVirtual() || !inputDevice.isFullKeyboard()) { return; } synchronized (mDataStore) { -- cgit v1.2.3-59-g8ed1b