From 81b134695a26978641c77ed5ca757e6cf43add72 Mon Sep 17 00:00:00 2001 From: Yasin Kilicdere Date: Mon, 11 Sep 2023 12:08:31 +0100 Subject: Trace UserSwitchObservers.onUserSwitching calls with asyncTrace. Bug: 297009655 Test: Manually checking perfetto traces Change-Id: I563fd7b9edddb9802120e4615a79fcccb89a1f7d --- services/core/java/com/android/server/am/UserController.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/services/core/java/com/android/server/am/UserController.java b/services/core/java/com/android/server/am/UserController.java index 27708330efd3..de4ad20bdccc 100644 --- a/services/core/java/com/android/server/am/UserController.java +++ b/services/core/java/com/android/server/am/UserController.java @@ -2212,6 +2212,7 @@ class UserController implements Handler.Callback { final IRemoteCallback callback = new IRemoteCallback.Stub() { @Override public void sendResult(Bundle data) throws RemoteException { + asyncTraceEnd("onUserSwitching-" + name, newUserId); synchronized (mLock) { long delayForObserver = SystemClock.elapsedRealtime() - dispatchStartedTimeForObserver; @@ -2229,8 +2230,6 @@ class UserController implements Handler.Callback { + " ms after dispatchUserSwitch."); } - TimingsTraceAndSlog t2 = new TimingsTraceAndSlog(TAG); - t2.traceBegin("onUserSwitchingReply-" + name); curWaitingUserSwitchCallbacks.remove(name); // Continue switching if all callbacks have been notified and // user switching session is still valid @@ -2239,13 +2238,11 @@ class UserController implements Handler.Callback { == mCurWaitingUserSwitchCallbacks)) { sendContinueUserSwitchLU(uss, oldUserId, newUserId); } - t2.traceEnd(); } } }; - t.traceBegin("onUserSwitching-" + name); + asyncTraceBegin("onUserSwitching-" + name, newUserId); mUserSwitchObservers.getBroadcastItem(i).onUserSwitching(newUserId, callback); - t.traceEnd(); } catch (RemoteException e) { // Ignore } -- cgit v1.2.3-59-g8ed1b