From c24e8e6c5e86fa2e4bb31d99246dd953943f4070 Mon Sep 17 00:00:00 2001 From: John Reck Date: Tue, 23 Apr 2019 09:23:52 -0700 Subject: Disable flaky tests Fixes: 130587638 Fixes: 130158977 Test: this Change-Id: I173a56b61205aff0903141beeb65e84b739d66e0 --- libs/hwui/tests/unit/CommonPoolTests.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libs/hwui/tests/unit/CommonPoolTests.cpp b/libs/hwui/tests/unit/CommonPoolTests.cpp index 70a5f5acbb6e..da6a2604a4b6 100644 --- a/libs/hwui/tests/unit/CommonPoolTests.cpp +++ b/libs/hwui/tests/unit/CommonPoolTests.cpp @@ -36,7 +36,9 @@ TEST(CommonPool, post) { EXPECT_TRUE(ran) << "Failed to flip atomic after 1 second"; } -TEST(CommonPool, threadCount) { +// test currently relies on timings, which +// makes it flaky. Disable for now +TEST(DISABLED_CommonPool, threadCount) { std::set threads; std::array, 64> futures; for (int i = 0; i < futures.size(); i++) { @@ -93,7 +95,9 @@ TEST(CommonPool, singleThread) { EXPECT_NE(gettid(), tid1); } -TEST(CommonPool, fullQueue) { +// Test currently relies on timings +// which makes it flaky, disable for now +TEST(DISABLED_CommonPool, fullQueue) { std::mutex lock; std::condition_variable fence; bool signaled = false; @@ -179,4 +183,4 @@ TEST(CommonPool, syncLifecycleCheck) { } CommonPool::waitForIdle(); ASSERT_EQ(0, ObjectTracker::count()); -} \ No newline at end of file +} -- cgit v1.2.3-59-g8ed1b