From 077d6371931dcefeb882a694524753c24bed3313 Mon Sep 17 00:00:00 2001 From: Michal Karpinski Date: Tue, 27 Jun 2017 15:08:57 +0100 Subject: Fix an NPE when cancelling full backup in BMS#endFullBackup() Bug: 63000171 Test: it's just a nullcheck that compiles Change-Id: I90faa5577f2fd656bb4f7b6af39494590a77e3bf --- .../java/com/android/server/backup/BackupManagerService.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/services/backup/java/com/android/server/backup/BackupManagerService.java b/services/backup/java/com/android/server/backup/BackupManagerService.java index 30de4baf3460..6f6e1b721487 100644 --- a/services/backup/java/com/android/server/backup/BackupManagerService.java +++ b/services/backup/java/com/android/server/backup/BackupManagerService.java @@ -5666,13 +5666,15 @@ public class BackupManagerService { PerformFullTransportBackupTask pftbt = null; synchronized (mQueueLock) { if (mRunningFullBackupTask != null) { - if (DEBUG_SCHEDULING) { - Slog.i(TAG, "Telling running backup to stop"); - } pftbt = mRunningFullBackupTask; } } - pftbt.handleCancel(true); + if (pftbt != null) { + if (DEBUG_SCHEDULING) { + Slog.i(TAG, "Telling running backup to stop"); + } + pftbt.handleCancel(true); + } } }; new Thread(endFullBackupRunnable, "end-full-backup").start(); -- cgit v1.2.3-59-g8ed1b