From 29cad18bd36e35e509ff25daf8b3ccd4eed1685a Mon Sep 17 00:00:00 2001 From: Nader Jawad Date: Wed, 28 Nov 2018 16:48:07 -0800 Subject: Hidden API usage Landroid/graphics/Canvas;->mBitmap:Landroid/graphics/Bitmap; Added maxTargetSdk version for Android P for access of mBitmap field through reflection. The bitmap field is configured by application usages only already so there is no need for apps to query the Bitmap from the Canvas and should do so directly. Getters on Canvas is generally seen as an anti-pattern. Bug: 117521088 Test: none Change-Id: Ie2318248f7682fd4e0a46121bc6e9f5c1546dcfb --- graphics/java/android/graphics/Canvas.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/graphics/java/android/graphics/Canvas.java b/graphics/java/android/graphics/Canvas.java index 3b0dc9d9f125..135c13703131 100644 --- a/graphics/java/android/graphics/Canvas.java +++ b/graphics/java/android/graphics/Canvas.java @@ -64,7 +64,7 @@ public class Canvas extends BaseCanvas { public boolean isRecordingFor(Object o) { return false; } // may be null - @UnsupportedAppUsage + @UnsupportedAppUsage(maxTargetSdk = Build.VERSION_CODES.P, trackingBug = 117521088) private Bitmap mBitmap; // optional field set by the caller -- cgit v1.2.3-59-g8ed1b