From 012cfaba793c7d494c948b1295e227fb8a6ca453 Mon Sep 17 00:00:00 2001 From: Mateus Azis Date: Thu, 28 Dec 2023 10:50:55 -0800 Subject: Remove unused fields from ProcessObserver. These fields are unused and holder object references unnecessarily, possibly hurting garbage-collection. Bug: 274764512 Test: built and ran a local image on cuttlefish; no obvious issues. Change-Id: Ia04271cd2e29faba003feb96d87a629910a8d574 --- .../com/android/server/am/ActivityManagerShellCommand.java | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/services/core/java/com/android/server/am/ActivityManagerShellCommand.java b/services/core/java/com/android/server/am/ActivityManagerShellCommand.java index 1b83327f50f6..ac8d56b2e9f4 100644 --- a/services/core/java/com/android/server/am/ActivityManagerShellCommand.java +++ b/services/core/java/com/android/server/am/ActivityManagerShellCommand.java @@ -396,7 +396,7 @@ final class ActivityManagerShellCommand extends ShellCommand { case "get-bg-restriction-level": return runGetBgRestrictionLevel(pw); case "observe-foreground-process": - return runGetCurrentForegroundProcess(pw, mInternal, mTaskInterface); + return runGetCurrentForegroundProcess(pw, mInternal); case "reset-dropbox-rate-limiter": return runResetDropboxRateLimiter(); case "list-displays-for-starting-users": @@ -3644,11 +3644,10 @@ final class ActivityManagerShellCommand extends ShellCommand { return -1; } - private int runGetCurrentForegroundProcess(PrintWriter pw, - IActivityManager iam, IActivityTaskManager iatm) + private int runGetCurrentForegroundProcess(PrintWriter pw, IActivityManager iam) throws RemoteException { - ProcessObserver observer = new ProcessObserver(pw, iam, iatm, mInternal); + ProcessObserver observer = new ProcessObserver(pw, iam); iam.registerProcessObserver(observer); final InputStream mInput = getRawInputStream(); @@ -3683,15 +3682,10 @@ final class ActivityManagerShellCommand extends ShellCommand { private PrintWriter mPw; private IActivityManager mIam; - private IActivityTaskManager mIatm; - private ActivityManagerService mInternal; - ProcessObserver(PrintWriter mPw, IActivityManager mIam, - IActivityTaskManager mIatm, ActivityManagerService ams) { + ProcessObserver(PrintWriter mPw, IActivityManager mIam) { this.mPw = mPw; this.mIam = mIam; - this.mIatm = mIatm; - this.mInternal = ams; } @Override -- cgit v1.2.3-59-g8ed1b