From 26aa04c3c4d16ab7bf47d414fac697721e5843cd Mon Sep 17 00:00:00 2001 From: Jorim Jaggi Date: Wed, 29 Jul 2015 14:52:22 -0700 Subject: Fix state weirdness in the panel When QS was open while the we started with expansion, we immediately notified about expansion finsihed again, which led to all kinds of weird states. The change that introduced these bugs was to fix another bug in which onExpandingFinished was not call. Make sure to call in exactly that case and no other case to not risk regressions. Bug: 22806817 Bug: 22807359 Bug: 22807372 Change-Id: Id7daf37ef4a772f724971bf79c61084ff4279f31 --- .../com/android/systemui/statusbar/phone/NotificationPanelView.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java index 56e303264dc8..f8bd7937b437 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/NotificationPanelView.java @@ -626,6 +626,7 @@ public class NotificationPanelView extends PanelView implements && shouldQuickSettingsIntercept(mInitialTouchX, mInitialTouchY, h)) { mQsTracking = true; onQsExpansionStarted(); + notifyExpandingFinished(); mInitialHeightOnTouch = mQsExpansionHeight; mInitialTouchY = y; mInitialTouchX = x; @@ -825,9 +826,7 @@ public class NotificationPanelView extends PanelView implements mInitialTouchX = event.getY(); // If we interrupt an expansion gesture here, make sure to update the state correctly. - if (mIsExpanding) { - onExpandingFinished(); - } + notifyExpandingFinished(); } } @@ -970,7 +969,6 @@ public class NotificationPanelView extends PanelView implements private void onQsExpansionStarted(int overscrollAmount) { cancelQsAnimation(); cancelHeightAnimator(); - notifyExpandingFinished(); // Reset scroll position and apply that position to the expanded height. float height = mQsExpansionHeight - mScrollView.getScrollY() - overscrollAmount; -- cgit v1.2.3-59-g8ed1b