From c602bd535d420e8e8c01535ad44322090c1412cc Mon Sep 17 00:00:00 2001 From: Sunny Shao Date: Wed, 15 Jan 2020 20:04:47 +0800 Subject: Fix the huge value of the ACTION_DASHBOARD_VISIBLE_TIME - We only record the elapsed time once after user invoked writeElapsedTimeMetric. Fixes: 147722985 Test: manual test Change-Id: I11d713538d895bc4ee5551b924f4d85ac66e64f9 --- .../settingslib/core/instrumentation/VisibilityLoggerMixin.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/VisibilityLoggerMixin.java b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/VisibilityLoggerMixin.java index 61e47f8f8dd8..6e7a429e6b7a 100644 --- a/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/VisibilityLoggerMixin.java +++ b/packages/SettingsLib/src/com/android/settingslib/core/instrumentation/VisibilityLoggerMixin.java @@ -87,8 +87,10 @@ public class VisibilityLoggerMixin implements LifecycleObserver, OnAttach { if (mMetricsFeature == null || mMetricsCategory == METRICS_CATEGORY_UNKNOWN) { return; } - final int elapse = (int) (SystemClock.elapsedRealtime() - mCreationTimestamp); - mMetricsFeature.action(METRICS_CATEGORY_UNKNOWN, action, mMetricsCategory, key, elapse); + if (mCreationTimestamp != 0L) { + final int elapse = (int) (SystemClock.elapsedRealtime() - mCreationTimestamp); + mMetricsFeature.action(METRICS_CATEGORY_UNKNOWN, action, mMetricsCategory, key, elapse); + } } /** -- cgit v1.2.3-59-g8ed1b