From 0d3db06d1d287c3efe18c951e08f4e7c6b3ebd47 Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Fri, 21 Apr 2017 08:08:39 -0700 Subject: Removed deprecated SaveInfo methods. Test: CtsAutoFillServiceTestCases pass Bug: 37563972 Bug: 33197203 Change-Id: Ie90fa78c31f033c47e7b2f018355ae87759c622b --- core/java/android/service/autofill/SaveInfo.java | 31 ++---------------------- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/core/java/android/service/autofill/SaveInfo.java b/core/java/android/service/autofill/SaveInfo.java index f7964447fb7b..3a1529f915e4 100644 --- a/core/java/android/service/autofill/SaveInfo.java +++ b/core/java/android/service/autofill/SaveInfo.java @@ -21,9 +21,7 @@ import static android.view.autofill.Helper.DEBUG; import android.annotation.IntDef; import android.annotation.NonNull; import android.annotation.Nullable; -import android.app.assist.AssistStructure; import android.content.IntentSender; -import android.os.Bundle; import android.os.Parcel; import android.os.Parcelable; import android.util.DebugUtils; @@ -154,7 +152,7 @@ public final class SaveInfo implements Parcelable { @interface SaveDataType{} /** - * Usually {@link AutofillService#onSaveRequest(AssistStructure, Bundle, SaveCallback)} + * Usually {@link AutofillService#onSaveRequest(SaveRequest, SaveCallback)} * is called once the activity finishes. If this flag is set it is called once all saved views * become invisible. */ @@ -228,8 +226,7 @@ public final class SaveInfo implements Parcelable { private final @SaveDataType int mType; private CharSequence mNegativeActionTitle; private IntentSender mNegativeActionListener; - // TODO(b/33197203): make mRequiredIds final once addSavableIds() is gone - private AutofillId[] mRequiredIds; + private final AutofillId[] mRequiredIds; private AutofillId[] mOptionalIds; private CharSequence mDescription; private boolean mDestroyed; @@ -251,36 +248,12 @@ public final class SaveInfo implements Parcelable { * @throws IllegalArgumentException if {@code requiredIds} is {@code null} or empty. */ public Builder(@SaveDataType int type, @NonNull AutofillId[] requiredIds) { - if (false) {// TODO(b/33197203): re-move when clients use it Preconditions.checkArgument(requiredIds != null && requiredIds.length > 0, "must have at least one required id: " + Arrays.toString(requiredIds)); - } mType = type; mRequiredIds = requiredIds; } - /** - * @hide - * @deprecated - * // TODO(b/33197203): make sure is removed when clients migrated - */ - @Deprecated - public Builder(@SaveDataType int type) { - this(type, null); - } - - /** - * @hide - * @deprecated - * // TODO(b/33197203): make sure is removed when clients migrated - */ - @Deprecated - public @NonNull Builder addSavableIds(@Nullable AutofillId... ids) { - throwIfDestroyed(); - mRequiredIds = ids; - return this; - } - /** * Set flags changing the save behavior. * -- cgit v1.2.3-59-g8ed1b