From 09ddba78cafbc849f5b331489d34d92d3a48ed94 Mon Sep 17 00:00:00 2001 From: Christian Göllner Date: Wed, 13 Apr 2022 11:26:31 +0200 Subject: PanelExpansionStateManager: add new parameter for raw drag amount This will be needed for split-shade expansion motion. The absolute value of the expansion will be used instead of fractions. + refactor multiple primitive parameters into a single high-level type parameter. Test: unit tests Change-Id: Ia35f79ff42f29e44e4123776be30ebc33ee2aab0 Merged-In: Ia35f79ff42f29e44e4123776be30ebc33ee2aab0 --- .../biometrics/UdfpsAnimationViewController.kt | 15 +- .../biometrics/UdfpsKeyguardViewController.java | 5 +- .../dreams/touch/BouncerSwipeTouchHandler.java | 25 ++- .../statusbar/NotificationShadeDepthController.kt | 5 +- .../notification/NotificationWakeUpCoordinator.kt | 5 +- .../systemui/statusbar/phone/CentralSurfaces.java | 5 +- .../statusbar/phone/PanelViewController.java | 4 +- .../systemui/statusbar/phone/ScrimController.java | 2 +- .../phone/StatusBarKeyguardViewManager.java | 5 +- .../phone/panelstate/PanelExpansionChangeEvent.kt | 14 ++ .../phone/panelstate/PanelExpansionListener.java | 31 ---- .../phone/panelstate/PanelExpansionListener.kt | 26 +++ .../phone/panelstate/PanelExpansionStateManager.kt | 17 +- .../UdfpsKeyguardViewControllerTest.java | 6 +- .../dreams/touch/BouncerSwipeTouchHandlerTest.java | 18 +- .../NotificationShadeDepthControllerTest.kt | 95 +++++------ .../phone/StatusBarKeyguardViewManagerTest.java | 183 +++++++++------------ .../panelstate/PanelExpansionStateManagerTest.kt | 48 +++--- 18 files changed, 260 insertions(+), 249 deletions(-) create mode 100644 packages/SystemUI/src/com/android/systemui/statusbar/phone/panelstate/PanelExpansionChangeEvent.kt delete mode 100644 packages/SystemUI/src/com/android/systemui/statusbar/phone/panelstate/PanelExpansionListener.java create mode 100644 packages/SystemUI/src/com/android/systemui/statusbar/phone/panelstate/PanelExpansionListener.kt diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.kt b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.kt index ac81633cdb2b..5cfbdb0caf2d 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.kt +++ b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsAnimationViewController.kt @@ -54,14 +54,13 @@ abstract class UdfpsAnimationViewController( private var dialogAlphaAnimator: ValueAnimator? = null private val dialogListener = SystemUIDialogManager.Listener { runDialogAlphaAnimator() } - private val panelExpansionListener = - PanelExpansionListener { fraction, expanded, tracking -> - // Notification shade can be expanded but not visible (fraction: 0.0), for example - // when a heads-up notification (HUN) is showing. - notificationShadeVisible = expanded && fraction > 0f - view.onExpansionChanged(fraction) - updatePauseAuth() - } + private val panelExpansionListener = PanelExpansionListener { event -> + // Notification shade can be expanded but not visible (fraction: 0.0), for example + // when a heads-up notification (HUN) is showing. + notificationShadeVisible = event.expanded && event.fraction > 0f + view.onExpansionChanged(event.fraction) + updatePauseAuth() + } /** If the notification shade is visible. */ var notificationShadeVisible: Boolean = false diff --git a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsKeyguardViewController.java b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsKeyguardViewController.java index e8cfd422cc8a..416b8ee60fd9 100644 --- a/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsKeyguardViewController.java +++ b/packages/SystemUI/src/com/android/systemui/biometrics/UdfpsKeyguardViewController.java @@ -38,6 +38,7 @@ import com.android.systemui.statusbar.phone.KeyguardBouncer; import com.android.systemui.statusbar.phone.StatusBarKeyguardViewManager; import com.android.systemui.statusbar.phone.SystemUIDialogManager; import com.android.systemui.statusbar.phone.UnlockedScreenOffAnimationController; +import com.android.systemui.statusbar.phone.panelstate.PanelExpansionChangeEvent; import com.android.systemui.statusbar.phone.panelstate.PanelExpansionListener; import com.android.systemui.statusbar.phone.panelstate.PanelExpansionStateManager; import com.android.systemui.statusbar.policy.ConfigurationController; @@ -491,8 +492,8 @@ public class UdfpsKeyguardViewController extends UdfpsAnimationViewController