From 6f14377e21367ebf8b248ac3449341f73750ae34 Mon Sep 17 00:00:00 2001 From: Neil Fuller Date: Fri, 28 Jul 2017 17:33:19 +0100 Subject: Remove redundant TODOs from PackageTracker The permission checks are either not required (for the data app) or have been moved to validateUpdaterAppManifest() (for the updater app). Bug: 64142062 Test: make droid Change-Id: Ie1791d64484f53ea2c2476f866fbd75358960de3 --- services/core/java/com/android/server/timezone/PackageTracker.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/services/core/java/com/android/server/timezone/PackageTracker.java b/services/core/java/com/android/server/timezone/PackageTracker.java index 9b4999667c88..24e0fe4841bc 100644 --- a/services/core/java/com/android/server/timezone/PackageTracker.java +++ b/services/core/java/com/android/server/timezone/PackageTracker.java @@ -173,8 +173,6 @@ public class PackageTracker implements IntentHelper.Listener { throw logAndThrowRuntimeException("Could not determine update app package details for " + mUpdateAppPackageName, e); } - // TODO(nfuller) Consider permission checks. While an updated system app retains permissions - // obtained by the system version it's not clear how to check them. Slog.d(TAG, "Update app " + mUpdateAppPackageName + " is valid."); // Validate the data application package. @@ -187,8 +185,6 @@ public class PackageTracker implements IntentHelper.Listener { throw logAndThrowRuntimeException("Could not determine data app package details for " + mDataAppPackageName, e); } - // TODO(nfuller) Consider permission checks. While an updated system app retains permissions - // obtained by the system version it's not clear how to check them. Slog.d(TAG, "Data app " + mDataAppPackageName + " is valid."); } @@ -466,7 +462,6 @@ public class PackageTracker implements IntentHelper.Listener { + TimeZoneRulesDataContract.AUTHORITY); return false; } - // TODO(nfuller) Add any permissions checks needed. return true; } -- cgit v1.2.3-59-g8ed1b