| Age | Commit message (Collapse) | Author |
|
main
|
|
Behavior for ALL_APPS and ACCESSIBILITY_ALL_APPS is exactly
the same so reducing the enum conflict.
Test: atest InputTests
Bug: 245989146
Flag: EXEMPT refactor
Change-Id: I729362351e7384f7119f1588f3f3be80e12df5fe
|
|
This is now handled by SysfsNodeMonitor.
Bug: 397208968
Test: Presubmit
Flag: EXEMPT bug fix
Change-Id: Ic7c1ed8575a1f332011aa35a207e00c2e0c59133
|
|
Remove code associated with foreground power key capture for system
apps, including the system API (reverts ag/30871623 and ag/30152916).
The decision was made to abandon this change for 25Q2 as Wallet does not
plan to use this feature with the system app limitation.
The flag is already rolled back in Gantry: see https://gantry.corp.google.com/changes/0a61p0a000001?build_unique_id=ComAndroidHardwareInputOverridePowerKeyBehaviorInFocusedWindowLaunch-platform&apply_default_filter=true&enable_workflow_timeline=false
Context: b/357144512#comment55
Test: atest PowerKeyGestureTests && atest GestureLauncherServicetest &&
atest WindowManagerServiceTests
Test: manually ensuring power button shortcuts remain same as before.
Bug: 357144512
Flag: com.android.hardware.input.override_power_key_behavior_in_focused_window
Change-Id: Ifd533b7e28745dd78be8ff53bd0cc465f248dda4
|
|
This will help input team ensure that their code is formatted without
doing it manually and dealing with it in code reviews.
Also, run the formatter on the existing files.
Bug: 245989146
Test: repo upload
Flag: TEST_ONLY
Change-Id: I38df2dfa1f76ffe702864c88083a3d579a873442
|
|
Fixes a bug in where kcm fallbacks with search based modifiers could
not activate since PhoneWindowManager would consume all search events.
This prevented the InputDispatcher from generating the fallback.
This change modifies the behavior so that when a search-based
fallback is detected, the key event will be directly sent to
InputDispatcher to handle the fallback. This will NOT send the
original event to applications.
Bug: 384113980
Test: atest PhoneWindowManagerTest
Test: atest InputTests:InputManagerServiceTests
Flag: com.android.hardware.input.fix_search_modifier_fallbacks
Change-Id: Iacecf945ea6be9841b6009d5f30bcf83f68309ef
|
|
|
|
On some devices, error dialogs aren't supposed. Skip the 'wait for the
app' test on those devices. Also skip looking for ANR dialog on the
'close app' test.
Also, increase the timeout for waiting for the activity to launch and
bind. When run on auto_md cf remote target, this is taking > 5 seconds
to launch and connect. So it used to fail with the following message
when the timeout was equal to 5 seconds:
STACKTRACE:
junit.framework.AssertionFailedError: UnresponsiveGestureMonitorActivity failed to call 'provideActivityInfo'
at junit.framework.Assert.fail(Assert.java:50)
at android.testing.PollingCheck.check(PollingCheck.java:73)
at com.android.test.input.AnrTest.startUnresponsiveActivity(AnrTest.kt:235)
at com.android.test.input.AnrTest.setUp(AnrTest.kt:132)
And even with the multiplied timeout, the test used to fail, so increase
the timeout to 10 seconds at the same time.
When the ANR dialog is skipped, we need to ensure that we wait for "exit
reasons" for a long time, because we are no longer waiting for the ANR
dialog to appear.
To run the test on auto cf md:
$ lunch cf_x86_64_only_auto_md-trunk_staging-userdebug
$ acloud create --local-image --boot-timeout 1000
$ atest AnrTest
Flag: TEST_ONLY
Bug: 339924248
Test: atest AnrTest
Change-Id: I031361e48c8bcdeac7489555d1c12df1a956a982
|
|
handleKeyGestureEvent() is synchronous API that makes system server
dependent on handler and can cause ANR if handlers misbehave.
As a replacement, handlers should provide list of gesture they want
to listen to. For consistency, we only allow single handler per
gesture.
Test: atest InputTests
Test: atest WmTests
Test: Presubmit
Bug: 358569822
Bug: 383602794
Flag: EXEMPT refactor
Change-Id: Iea0f6ba3360ed241e19f0265d6ab28fd7889aafa
|
|
|
|
Bug: 400865401
Test: atest PointerIconLoadingTest
Flag: TEST_ONLY
Change-Id: I9e97e2db2bd409f1a6121f43baf596e343ddff0f
|
|
"vaibhav_isKeygestureSupported_refactor" into main
* changes:
(3/n) Remove usage of isKeyGestureSupported() from KeyGestureController
(2/n) Remove usage of isKeyGestureSupported() from KeyGestureController
|
|
This is the way that TestableContext's JavaDoc recommends, to let it
clean up after itself once the test finishes, so we should do it anyway.
However, it won't fix b/339924248 on its own.
Bug: 339924248
Test: $ atest InputTests:com.android.server.input.BatteryControllerTests
Flag: TEST_ONLY
Change-Id: I53b40671286530a7c411cfff6bc08239f5baf13b
|
|
This is the way that TestableContext's JavaDoc recommends, to let it
clean up after itself once the test finishes, so we should do it anyway.
However, unfortunately, it doesn't fix b/339924248, where
com.android.test.input.AnrTest fails if it's run after the touchpad
debug view tests.
Bug: 339924248
Test: $ atest \
InputTests:com.android.server.input.debug.TouchpadDebugViewTest \
InputTests:com.android.server.input.debug.TouchpadDebugViewControllerTests
Flag: TEST_ONLY
Change-Id: Ia5a480ccbdc05491c7e0bab8c269aa5bd55a205c
|
|
isKeyGestureSupported is synchronous API that makes system server
dependent on handler and can cause ANR if handlers misbehave.
It was added as a stop gap for multi-key gestures that require
some SysUI info like keyguard state, display state, etc, to decide
if the key needs to be consumed or not at the start of the gesture.
Test: atest KeygestureControllerTests
Bug: 358569822
Bug: 383602794
Flag: EXEMPT refactor
Change-Id: I14abee92ede63e57c4c0d92c3d0eb501bd14a3bd
|
|
isKeyGestureSupported is synchronous API that makes system server
dependent on handler and can cause ANR if handlers misbehave.
It was added as a stop gap for multi-key gestures that require
some SysUI info like keyguard state, display state, etc, to decide
if the key needs to be consumed or not at the start of the gesture.
With this refactor:
- WM policy added an API to check isKeyguardLocked() and we will
use that for checking keyguard status
- Move A11yShortcutController to KGC to circumvent the need of the
isShortcutAvailable() API
- Since the only difference with TV and non TV event handling was
whether keyguard showing blocks the shortcut or not, we no longer
need to have separate handler logic for TV (we can cover it in
precondition check).
In subsequent CLs:
- Will remove usages of isKeyGestureSupported() API everywhere
Test: atest KeygestureControllerTests
Bug: 358569822
Bug: 383602794
Flag: EXEMPT refactor
Change-Id: Ib5d5c727fabb28623efa6247e817cf0c643a949c
|
|
|
|
This will allow us to communicate with the app, so that we can learn
about the app's window token, displayId, and PID. This will also allow
the app to notify the test when the input event is received. This will
help the test avoid closing the uinput device prematurely.
Outstanding issues in this test:
1. Some of the injection that's occurring is still done using
"uiobject::click" instead of using uinput. The difficulty here is
that we need a way to wait for the ANR window to disappear after
clicking to prevent the uinput device from getting closed too soon.
To do this, we may be able to match a window by the window's name.
This kind of refactor should be done in a separate CL.
2. The test needs to be skipped on devices that don't support error
dialogs.
Bug: 339924248
Flag: TEST_ONLY
Test: atest AnrTest
Change-Id: Ic944d8a2558237d29a6155abe2a0271cb3e982b6
|
|
am: 931305e0a4 am: 6c5456d10c
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3501454
Change-Id: Ib8db6e57cdcabfdb7aec408ef53ecc4fbf01c31b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
c357c280a716b584b512e4febb43c7c62b1aea3e
Change-Id: I99ac28a8bb165edb985d0405a8b33ed840f7f2f7
|
|
This will help ensure that the setting is restored, without doing much
explicit work in the test itself.
Bug: 339924248
Flag: TEST_ONLY
Test: atest AnrTest
Change-Id: If06d496589a205881aaee2848b80ad91cae6c648
|
|
Previously this key combination was removed from the user facing
elements like the "new shortcut helper" UI but wasn't removed from
old shortcut helper and the key gesture controller.
Originally removed due to low usage and ergonomic difficulty with
the shortcut: b/394599430
Bug: 394599430
Bug: 394600915
Test: atest InputTests
Flag: EXEMPT bugfix
Change-Id: I2968c76bea7fe9d85c2b6f08d7277933f5ee35db
|
|
am: 019dab7845 am: a543de34d2
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3502139
Change-Id: Ie251c319352b38772be0edf71b874cd43968badc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
bd81bb71413c3324306b9663329e9537d6b2c123
Change-Id: Icc653a0930545ebe1468156385b6842b783d6152
|
|
am: 5d977d2fc5 am: 12750b072f
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3500595
Change-Id: I2d5fade5eba4802a7d1f1c953413812d9325f7bc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
|
|
0a977ce9257d236aeb435f90fdd0b4d3ead78b64
Change-Id: I8e20e035cfc8fd4d450e3dfa28af47df8701f45c
|
|
4c05e0484e am: c9d59b34ac
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3499700
Change-Id: I42586fcc67350bff09199d3524b6a494c23fdfff
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
Revert submission 3495771-upgrade-mockito
Reason for revert: DroidMonitor: Potential culprit for http://b/397508359 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Reverted changes: /q/submissionid:3495771-upgrade-mockito
Change-Id: Ia26942ea855f0a7e9e4ff5230dcc19b7fd0fab37
|
|
|
|
0de81957f4 am: 9213e44679
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3494547
Change-Id: I2fe85ef863e3ef4b2cf277c045c75b243af3b988
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
Those tests use deprecated and internal Mockito APIs.
Change-Id: I2752dc0026e248bcea65b975a75dcf0c3aae2f66
|
|
|
|
|
|
We will rely on ROLE_NOTES based bookmark to launch notes app
instead of dedicated system shortcut. With the shortcut
currently broken, we are removing the shortcut from system
shortcut logic.
Once ROLE_NOTES is available and added to default application
supported roles, we can add corresponding bookmark to the list
of app bookmarks (bookmarks.xml) and it should work.
Test: atest KeyGestureControllerTests
Test: atest KeyGestureEventTests
Bug: 390707077
Flag: EXEMPT bugfix
Change-Id: I9ff3509e0b04ec8127b6a6dcefd64ae7e5e2848d
|
|
* changes:
Flag cleanup: keyboard_a11y_(bounce/slow/sticky)_keys_flag
Flag cleanup: keyboard_layout_preview_flag
|
|
Previously, gestures were being persisted on the DisplayThread
foreground thread handler. This updates gestures to be persisted
on the background IoThread.
Bug: b/383380006
Bug: b/383380875
Test: Verified on device that functionality still works
Flag: EXEMPT bugfix
Change-Id: I103d2e03151c84152beebe4d2a81b2e813e3ee6c
|
|
Presubmit is failing due to extra semicolon in kotlin file.
Test: Cosmetic change
Flag: EXEMPT bugfix
Change-Id: I778377fbc4415d604ca57fb346c830ffae828f64
|
|
Add missing test cases for when the permission and private flag
overrides are not a factor for intercepting keys before dispatching.
Bug: 384113980
Test: atest InputTests:InputManagerServiceTests
Flag: TEST_ONLY
Change-Id: Ie401dfe3e10ec71e2054cb19cd2ce2d4d913b239
|
|
|
|
Test: atest InputTests:InputManagerServiceTests
bug: 356412905
Flag: com.android.hardware.input.key_event_activity_detection
Change-Id: Iaeeeecaac9b63f2c6c38bf79612199cc9f88def6
|
|
into main
|
|
This test used its own infra to parse EVEMU files and inject their
contents into the uinput shell command.
In this CL, we introduce the EvemuDevice class, which uses our exising
VirtualInputDevice test infra to manage the virtual device. This means
the test will benefit from the existing synchronization points present
in the infra.
Bug: 385141667
Bug: 389901828
Test: Presubmit
Flag: TEST_ONLY
Change-Id: Id009eaf828581a41b0466dff43aebe7bf9b1bc26
|
|
Test: atest InputTests:KeyGestureControllerTests
Test: Manually tested backup + restore on device
Bug: 365064144
Bug: 382184249
Flag: com.android.hardware.input.enable_backup_and_restore_for_input_gestures
Change-Id: Iff0358fd2f4cd8efa7adde103befc70017871d7f
|
|
Bug: 294546335
Test: manual
Flag: EXEMPT cleanup
Change-Id: Iffba0c67ed626d517a105441deff3d9fb97fdf3b
|