| Age | Commit message (Collapse) | Author |
|---|
|
Robustness to crash of AudioServer.
Take benefit of future permission enforcement.
Bug: 293236285
Flag: EXEMPT refactor
Test: atest com.android.server.audio
Signed-off-by: Francois Gaffie <francois.gaffie@renault.com>
Change-Id: If556a668f45d608b98b6e8073426f5bb8128c7a2
|
|
While the overhead of recomputing the feature lookup cache is relatively
cheap, we should avoid it by computing it just once with the boot image.
Note that this manual addition should only be necessary as we ramp the
feature, after that we can likely remove it and rely on the usual boot
image profiling pipeline to ensure one-time init.
Bug: 400597432
Test: m + check boot-framework.art/oat
Flag: android.content.pm.cache_sdk_system_features
Change-Id: I1f4e881c94a3a4c1b7c1bedda0d3968ce47a71d2
|
|
Bug: 254051423
Bug: 360419348
Test: go/art-benchmark?p=BootImageProfileId:54874&f=CandidateName:in:54879
= Perf stats =
(lower is better)
Regular update to the boot image profiles, with also a fix of adding a few of frequently used classes which are missed during the generation of the profile. Benchmark shows improvements for cold app startup and app memory, with no impact on boot time and memory, but with an increase of code size by 59KB which could be an acceptable cost given the improvmenet in the other metrics.
Avg % [Confidence interval min-max %]
App Startup: -2.03 [-5.38, 1.32]
App File RSS: -1.48 [-6.06, 3.11]
App Anon RSS + Swap: -0.41 [-14.3, 13.49]
Memory(PSS): +0.23 [-1.49, 1.95]
Memory(RSS): -0.33 [-1.04, 0.38]
Memory(Private-dirty): -0.36 [-7.13, 6.41]
Boot time: -0.04 [-0.55, 0.48]
Code size: +0.059MB (0.076%)
Ignore-AOSP-First: Boot image profiles
Flag: EXEMPT NONE regular update to the boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
Bypass the increase in services.odex_bytes as it is justfiled by the other improvements in startup time and memory
=Generation Strategy=
method_threshold: 0.46
image_class_threshold: 0.37
preloaded_classes_threshold: 0.58
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.065714285
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.065714285
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.065714285
}
priority_packages_thresholds {
key: "service-uwb.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "service-uwb.jar.prof:METHOD:android"
value: 0.065714285
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.065714285
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.052857142
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.065714285
}
=Profile stats=
Data info:
- total aggregations: 2698
- number of (device types, builds): 159
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 273 added, 3 removed
- totals now: 0 hot methods, 0 methods, 18430 classes
- totals before: 0 hot methods, 0 methods, 18160 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 119, 3, 0, 10738
com.android, 0, 0, 31, 0, 0, 3666
java, 0, 0, 109, 0, 0, 2199
android.view, 0, 0, 12, 0, 0, 1141
android.hardware, 0, 0, 5, 0, 0, 885
android.app, 0, 0, 24, 0, 0, 1224
android.content, 0, 0, 6, 0, 0, 637
android.graphics, 0, 0, 5, 0, 0, 377
android.icu, 0, 0, 1, 0, 0, 1491
android.media, 0, 0, 6, 0, 0, 630
android.net, 0, 0, 6, 0, 0, 213
android.widget, 0, 0, 1, 0, 0, 426
File boot-image-profile.txt
- hot methods: 436 added, 52 removed
- methods: 91 added, 64 removed
- classes: 194 added, 3 removed
- totals now: 23282 hot methods, 23310 methods, 15156 classes
- totals before: 22898 hot methods, 23283 methods, 14965 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 332, 50, 95, 3, 21618, 10745
com.android, 104, 2, 21, 0, 1567, 3229
java, 0, 0, 74, 0, 2, 188
android.view, 60, 16, 7, 1, 3530, 1142
android.hardware, 15, 1, 2, 0, 490, 886
android.animation, 2, 1, 0, 0, 419, 89
android.app, 95, 9, 18, 0, 3105, 1227
android.content, 25, 3, 6, 0, 1946, 639
android.graphics, 5, 3, 1, 0, 1984, 378
android.icu, 2, 3, 0, 0, 2096, 1491
android.media, 0, 0, 7, 0, 785, 638
android.net, 3, 0, 6, 0, 256, 213
android.widget, 0, 0, 2, 0, 1401, 428
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 222 added, 3 removed
- totals now: 0 hot methods, 0 methods, 15103 classes
- totals before: 0 hot methods, 0 methods, 14884 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 119, 3, 0, 10705
com.android, 0, 0, 30, 0, 0, 3224
java, 0, 0, 69, 0, 0, 183
android.view, 0, 0, 12, 0, 0, 1141
android.hardware, 0, 0, 5, 0, 0, 885
android.app, 0, 0, 24, 0, 0, 1224
android.content, 0, 0, 6, 0, 0, 637
android.graphics, 0, 0, 5, 0, 0, 377
android.icu, 0, 0, 1, 0, 0, 1491
android.media, 0, 0, 6, 0, 0, 630
android.net, 0, 0, 6, 0, 0, 213
android.widget, 0, 0, 1, 0, 0, 426
File art-profile
- hot methods: 297 added, 156 removed
- methods: 297 added, 156 removed
- classes: 232 added, 1 removed
- totals now: 4485 hot methods, 4485 methods, 296 classes
- totals before: 4344 hot methods, 4344 methods, 65 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 112, 0, 20, 117
com.android, 297, 156, 35, 1, 4465, 94
java, 0, 0, 83, 0, 0, 83
android.view, 0, 0, 13, 0, 0, 13
android.hardware, 0, 0, 7, 0, 17, 7
android.app, 0, 0, 25, 0, 0, 27
android.content, 0, 0, 10, 0, 1, 11
android.media, 0, 0, 10, 0, 0, 10
android.net, 0, 0, 8, 0, 2, 8
InternalReferenceRawProfileId: 54874
InternalReferenceCandidateProfileId: 54879
Test: build & benchmark
Change-Id: Id72be07137c66625aba9d17b862db8d445a44662
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:54227&f=CandidateName:in:54235
= Perf stats =
(lower is better)
Regular update to the boot image profiles. Benchmark shows improvements for Apps startup and boot memory, with no impact on boot time, but with an increase of code size by 391KB which could be an acceptable cost given the improvmenet in the other metrics.
Avg % [Confidence interval min-max %]
App Startup: -2.99 [-6.52, 0.53]
App File RSS: -3.63 [-16.14, 8.88]
App Anon RSS + Swap: -1.37 [-16.88, 14.14]
Memory(PSS): -1.25 [-3.92, 1.41]
Memory(RSS): -1.3 [-4.02, 1.42]
Memory(Private-dirty): -2.69 [-9.54, 4.16]
Boot time: +0.48 [-0.09, 1.06]
Code size: +0.39MB (0.50%)
Ignore-AOSP-First: Boot image profiles
Flag: EXEMPT resource only update
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
Bypass the increase in boot-framework.oat_bytes and services.odex_bytes as it is justfiled by the other improvements in startup time and memory
=Generation Strategy=
method_threshold: 0.44
image_class_threshold: 0.35
preloaded_classes_threshold: 0.56
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.06285714
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.06285714
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.06285714
}
priority_packages_thresholds {
key: "service-uwb.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "service-uwb.jar.prof:METHOD:android"
value: 0.06285714
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.06285714
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.05
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.06285714
}
=Profile stats=
Data info:
- total aggregations: 1789
- number of (device types, builds): 156
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 423 added, 72 removed
- totals now: 0 hot methods, 0 methods, 18159 classes
- totals before: 0 hot methods, 0 methods, 17808 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 289, 58, 0, 10621
com.android, 0, 0, 86, 13, 0, 3635
java, 0, 0, 8, 1, 0, 2090
android.view, 0, 0, 17, 4, 0, 1129
android.hardware, 0, 0, 11, 2, 0, 880
android.app, 0, 0, 29, 6, 0, 1200
android.content, 0, 0, 5, 0, 0, 631
android.graphics, 0, 0, 3, 3, 0, 372
android.icu, 0, 0, 2, 1, 0, 1490
android.media, 0, 0, 7, 8, 0, 624
android.net, 0, 0, 1, 10, 0, 207
android.widget, 0, 0, 2, 1, 0, 425
File boot-image-profile.txt
- hot methods: 673 added, 99 removed
- methods: 1058 added, 99 removed
- classes: 390 added, 64 removed
- totals now: 22898 hot methods, 23283 methods, 14965 classes
- totals before: 22324 hot methods, 22324 methods, 14639 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 600, 98, 309, 50, 21336, 10653
com.android, 73, 1, 66, 13, 1465, 3208
android.view, 133, 6, 22, 6, 3486, 1136
android.hardware, 13, 3, 13, 0, 476, 884
android.animation, 7, 2, 0, 0, 418, 89
android.app, 143, 36, 34, 6, 3019, 1209
android.content, 23, 5, 5, 1, 1924, 633
android.graphics, 11, 3, 5, 0, 1982, 377
android.icu, 22, 1, 2, 0, 2097, 1491
android.media, 0, 5, 6, 5, 785, 631
android.net, 8, 4, 0, 11, 253, 207
android.widget, 2, 0, 2, 1, 1401, 426
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 365 added, 69 removed
- totals now: 0 hot methods, 0 methods, 14883 classes
- totals before: 0 hot methods, 0 methods, 14587 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 288, 58, 0, 10588
com.android, 0, 0, 63, 11, 0, 3194
android.view, 0, 0, 17, 4, 0, 1129
android.hardware, 0, 0, 11, 2, 0, 880
android.app, 0, 0, 29, 6, 0, 1200
android.content, 0, 0, 5, 0, 0, 631
android.graphics, 0, 0, 3, 3, 0, 372
android.icu, 0, 0, 2, 1, 0, 1490
android.media, 0, 0, 7, 8, 0, 624
android.net, 0, 0, 1, 10, 0, 207
android.widget, 0, 0, 2, 1, 0, 425
File art-profile
- hot methods: 885 added, 681 removed
- methods: 885 added, 681 removed
- classes: 11 added, 1643 removed
- totals now: 4344 hot methods, 4344 methods, 65 classes
- totals before: 4140 hot methods, 4140 methods, 1697 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 1, 5, 17, 20, 5
com.android, 885, 680, 6, 1592, 4324, 60
android.hardware, 0, 1, 0, 8, 17, 0
android.app, 0, 0, 2, 0, 0, 2
android.content, 0, 0, 1, 3, 1, 1
android.net, 0, 0, 0, 3, 2, 0
InternalReferenceRawProfileId: 54227
InternalReferenceCandidateProfileId: 54235
Test: build & benchmark
Change-Id: I6f7b112e372a08ba9fd660c1c50787e2a9d3fc98
|
|
into main
|
|
The java CodecCapabilities is being ported to native. The nested private
class FeatureList will be removed ultimately.
Bug: 388337603
Test: m
Change-Id: I7b8b4e43a8fe6a3d1ccbbac4217606a8b4bf369b
|
|
PlatformAconfigPackage is the class used by the non-updatable part in
the system. This change uses the zygote optimization until the automated system picks up the class.
Test: presubmit
Bug: 386382756
Change-Id: I4ee9cac0f127c84154f41004387439a6a3bfcdc1
|
|
It looks like an outdated decision to exclude this class, so return it back
Bug: 254051423
Bug: 382606466
Test: go/art-benchmark?p=BootImageProfileId:53718
Change-Id: If8b018f179bb4596e4e229ac58ea8c67cdc2263e
|
|
It saves time for loading AconfigPackage and find right containers for each process using exported aconfig flag.
Test: presubmit
Bug: 349874828
Change-Id: I176aaf3164d9134b57659728b40e4f0e3684a52e
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:41298&f=CandidateName:in:41302
= Perf stats =
(lower is better)
Regular update to the boot image profiles. Benchmark shows improvements for Apps startup and memory, boot memory and boot time, but with an increase of code size by 629KB which could be an acceptable cost given the improvmenet in the other metrics.
Avg % [Confidence interval min-max %]
App Startup: -1.43 [-3.4, 0.53]
App RSS: 0.23 [-0.44, 0.89]
App Anon RSS + Swap: -0.79 [-2.55, 0.96]
Memory(PSS): -1.07 [-3.16, 1.03]
Memory(RSS): -0.97 [-1.94, 0]
Memory(Private-dirty): -1.47 [-6.05, 3.12]
Boot time: -1.11 [-1.59, -0.62]
Code size: 629KB (0.701%)
Ignore-AOSP-First: Boot image profiles
Flag: EXEMPT resource only update
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.8
image_class_threshold: 0.35
preloaded_classes_threshold: 0.56
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.025
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.057142857
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.025
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.057142857
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.025
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.057142857
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.025
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.057142857
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.025
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.057142857
}
=Profile stats=
Data info:
- total aggregations: 4270
- number of (device types, builds): 130
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 398 added, 355 removed
- totals now: 0 hot methods, 0 methods, 17805 classes
- totals before: 0 hot methods, 0 methods, 17762 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 268, 253, 0, 10387
com.android, 0, 0, 65, 18, 0, 3562
java, 0, 0, 36, 71, 0, 2083
android.view, 0, 0, 32, 58, 0, 1116
android.hardware, 0, 0, 5, 7, 0, 871
android.animation, 0, 0, 5, 5, 0, 89
android.app, 0, 0, 26, 29, 0, 1177
android.content, 0, 0, 9, 15, 0, 626
android.graphics, 0, 0, 11, 7, 0, 372
android.icu, 0, 0, 11, 19, 0, 1489
android.media, 0, 0, 9, 12, 0, 625
android.net, 0, 0, 0, 5, 0, 216
android.widget, 0, 0, 22, 41, 0, 424
File boot-image-profile.txt
- hot methods: 1121 added, 1294 removed
- methods: 1121 added, 1294 removed
- classes: 423 added, 326 removed
- totals now: 22324 hot methods, 22324 methods, 14639 classes
- totals before: 22497 hot methods, 22497 methods, 14542 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1062, 1216, 335, 301, 20834, 10394
com.android, 59, 78, 84, 24, 1393, 3155
java, 0, 0, 0, 1, 2, 114
android.view, 204, 260, 40, 60, 3359, 1120
android.hardware, 5, 23, 9, 16, 466, 871
android.animation, 65, 65, 5, 5, 413, 89
android.app, 62, 86, 40, 37, 2912, 1181
android.content, 87, 97, 10, 22, 1906, 629
android.graphics, 73, 74, 8, 7, 1974, 372
android.icu, 128, 100, 30, 26, 2076, 1489
android.media, 12, 14, 12, 15, 790, 630
android.net, 23, 26, 0, 4, 249, 218
android.widget, 62, 67, 23, 41, 1399, 425
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 324 added, 270 removed
- totals now: 0 hot methods, 0 methods, 14584 classes
- totals before: 0 hot methods, 0 methods, 14530 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 267, 253, 0, 10355
com.android, 0, 0, 57, 17, 0, 3142
android.view, 0, 0, 32, 58, 0, 1116
android.hardware, 0, 0, 5, 7, 0, 871
android.animation, 0, 0, 5, 5, 0, 89
android.app, 0, 0, 26, 29, 0, 1177
android.content, 0, 0, 9, 15, 0, 626
android.graphics, 0, 0, 11, 7, 0, 372
android.icu, 0, 0, 11, 19, 0, 1489
android.media, 0, 0, 9, 12, 0, 625
android.net, 0, 0, 0, 5, 0, 216
android.widget, 0, 0, 22, 41, 0, 424
File art-profile
- hot methods: 2259 added, 2069 removed
- methods: 2259 added, 2069 removed
- classes: 1618 added, 3 removed
- totals now: 4140 hot methods, 4140 methods, 1697 classes
- totals before: 3950 hot methods, 3950 methods, 82 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 12, 12, 17, 1, 21, 17
com.android, 2247, 2057, 1567, 2, 4119, 1646
android.hardware, 10, 10, 8, 0, 18, 8
android.content, 0, 0, 3, 0, 1, 3
android.net, 2, 2, 3, 0, 2, 3
InternalReferenceRawProfileId: 41298
InternalReferenceCandidateProfileId: 41302
Test: build & benchmark
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4816fa8ae8801cd3f780787c55755ce42a46d924)
Merged-In: Id6e9863dbeef2bc9ea4d8855e5d640dd81d16f8e
Change-Id: Id6e9863dbeef2bc9ea4d8855e5d640dd81d16f8e
|
|
This class is used by the CarService, which is a system service that is always running on Android Automotive devices, but not for phones.
Bug: 254051423
Bug: 377482680
Change-Id: I19bf0ce4dcf1b2b72e92a8f7b3064073e1d2d1dd
Test: m
|
|
Bug: 254051423
Change-Id: Icdbe008684f2a12046abeadb9667fc40d1d42a7a
Test: m
Test: go/art-benchmark?p=BootImageProfileId:41894 Shows no regression
|
|
Test: presubmit
Test: install ART jitzygote module, check that dex2oat receives new
path to dirty-image-objects file
Change-Id: Ied314e038cd42eea634e680f705cd82134f273fc
|
|
framework/base/config
This is to decouple the framework and art profiles everywhere.
Bug: 260067246
Change-Id: I61af081b402f6e63722a5ae9e22151227a713c95
Test: running `m`
Test: Verify PRODUCT_DEX_PREOPT_BOOT_IMAGE_PROFILE_LOCATION for multiple products https://paste.googleplex.com/5573555023773696
|
|
Revert partially submission 27407484-main-profiles-v11
Reason for revert: possible regression at b/342542772
Bug: 342542772
Test: https://android-build.corp.google.com/test_investigate/?invocationId=I06500010293058830
Flag: EXEMPT resource only update
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:a9d2cc78198bee64ef5420fe126377b4fc487a91)
Merged-In: I3485062a378bf2ce3b139a62c247dc33f4edd48e
Change-Id: I3485062a378bf2ce3b139a62c247dc33f4edd48e
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3211630
Change-Id: Ib73b73efcb908edd76bb83dcfb9692cbccd8eddc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Revert submission 3146736-split-dirty-image-objects
Reason for revert: Droidmonitor created revert due to b/358597715. Will be verifying through ABTD before submission.
Reverted changes: /q/submissionid:3146736-split-dirty-image-objects
Change-Id: Ibfa81c4092c338e773ea9823857f1390988c9459
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3146736
Change-Id: I5efd187b0437bf0a3a9bc4d13020407ea5cafb13
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3206354
Change-Id: I93ddb44eb197b0611639090d31b8f446ae6261e4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
This reverts commit 0ee1bb42d9a7095b7c0f10fee116db7f722671ae.
Reason for revert: Likely culprit for b/357595207 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: I8f69055a93867a7ee8244604d96df20f644a2742
|
|
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/3201650
Change-Id: Ia102818e631082340386fd3b458d893026df80da
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
Bug: 254051423
Change-Id: I8e8d887e14905f990e741ba663513a609f389b93
Test: Weekly Boot Image Profile at go/art-benchmark-service
|
|
Split dirty-image-objects file between ART and framework modules -
depending on where the classes are defined.
This will allow dirty-image-objects to stay relevant in case only one of
the modules is updated.
Add .txt extension to dirty-image-objects file.
Update AndroidRuntime to use new paths.
Bug: 346990440
Test: presubmit
Test: install ART jitzygote module, check that dex2oat receives new
paths to dirty-image-objects files
Change-Id: I77ff6bfa8d0f78fc1f493651879873cb33100e78
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:39982&f=CandidateName:in:39985
= Perf stats =
(lower is better)
Regular update to the boot image profiles. Benchmark shows a code size reduction of 0.5MB and improvements in App-memory and system-memory with a tiny improvement in boot Time.
Avg % [Confidence interval min-max %]
App Startup: 0.42 [-1.59, 2.42]
App RSS: -0.49 [-1.15, 0.16]
App Anon RSS + Swap: -0.75 [-2.04, 0.53]
Memory(PSS): -0.25 [-1.1, 0.61]
Memory(RSS): -0.49 [-1.09, 0.12]
Memory(Private-dirty): -2.6 [-4.54, -0.66]
Boot time: -0.57 [-1.44, 0.3]
Code size: -0.50MB (-0.607%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.82
image_class_threshold: 0.37
preloaded_classes_threshold: 0.58
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.026428571
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.058571428
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.026428571
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.058571428
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.026428571
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.058571428
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.026428571
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.058571428
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.026428571
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.058571428
}
=Profile stats=
Data info:
- total aggregations: 1873
- number of (device types, builds): 245
File boot-image-profile.txt
- hot methods: 610 added, 615 removed
- methods: 610 added, 615 removed
- classes: 17 added, 15 removed
- totals now: 32511 hot methods, 32511 methods, 17851 classes
- totals before: 32516 hot methods, 32516 methods, 17849 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 575, 574, 8, 10, 20958, 10421
com.android, 17, 23, 6, 4, 2320, 3538
java, 9, 9, 2, 1, 7241, 2131
android.view, 160, 164, 1, 0, 3394, 1148
android.hardware, 3, 1, 0, 0, 471, 873
android.animation, 46, 46, 0, 0, 413, 89
android.app, 35, 35, 0, 2, 2923, 1183
android.content, 74, 71, 0, 0, 1908, 635
android.graphics, 76, 76, 3, 0, 1974, 374
android.icu, 19, 19, 0, 0, 2043, 1497
android.media, 0, 0, 2, 0, 792, 637
android.net, 7, 7, 0, 0, 252, 222
android.widget, 77, 77, 0, 0, 1403, 445
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 33 added, 24 removed
- totals now: 0 hot methods, 0 methods, 17762 classes
- totals before: 0 hot methods, 0 methods, 17753 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 21, 14, 0, 10372
com.android, 0, 0, 6, 5, 0, 3515
java, 0, 0, 5, 5, 0, 2118
android.view, 0, 0, 2, 3, 0, 1142
android.hardware, 0, 0, 2, 0, 0, 873
android.app, 0, 0, 1, 2, 0, 1180
android.content, 0, 0, 0, 1, 0, 632
android.graphics, 0, 0, 0, 3, 0, 368
android.icu, 0, 0, 11, 0, 0, 1497
android.media, 0, 0, 2, 0, 0, 628
File boot-image-profile.txt
- hot methods: 601 added, 606 removed
- methods: 601 added, 606 removed
- classes: 14 added, 14 removed
- totals now: 22381 hot methods, 22381 methods, 14605 classes
- totals before: 22386 hot methods, 22386 methods, 14605 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 575, 574, 8, 10, 20894, 10390
com.android, 17, 23, 5, 4, 1390, 3125
android.view, 160, 164, 1, 0, 3394, 1148
android.hardware, 3, 1, 0, 0, 471, 873
android.animation, 46, 46, 0, 0, 413, 89
android.app, 35, 35, 0, 2, 2923, 1183
android.content, 74, 71, 0, 0, 1908, 635
android.graphics, 76, 76, 3, 0, 1974, 374
android.icu, 19, 19, 0, 0, 2043, 1497
android.media, 0, 0, 2, 0, 792, 637
android.net, 7, 7, 0, 0, 252, 222
android.widget, 77, 77, 0, 0, 1403, 445
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 26 added, 19 removed
- totals now: 0 hot methods, 0 methods, 14530 classes
- totals before: 0 hot methods, 0 methods, 14523 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 21, 14, 0, 10341
com.android, 0, 0, 4, 5, 0, 3102
android.view, 0, 0, 2, 3, 0, 1142
android.hardware, 0, 0, 2, 0, 0, 873
android.app, 0, 0, 1, 2, 0, 1180
android.content, 0, 0, 0, 1, 0, 632
android.graphics, 0, 0, 0, 3, 0, 368
android.icu, 0, 0, 11, 0, 0, 1497
android.media, 0, 0, 2, 0, 0, 628
File art-profile
- hot methods: 1774 added, 2504 removed
- methods: 1774 added, 2504 removed
- classes: 7 added, 3 removed
- totals now: 3950 hot methods, 3950 methods, 82 classes
- totals before: 4680 hot methods, 4680 methods, 78 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 3, 4, 1, 1, 21, 1
com.android, 1771, 2500, 6, 2, 3929, 81
android.hardware, 3, 4, 0, 1, 18, 0
InternalReferenceRawProfileId: 39982
InternalReferenceCandidateProfileId: 39985
Test: build & benchmark
Change-Id: I984aa7fffa8d68fc315124699e64de1a8cba2993
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:39887&f=CandidateName:in:39896
= Perf stats =
(lower is better)
Regular update to the boot image profiles. Benchmark shows a great code size reduction of 3.3MB and improvement in App-memory and system-memory with almost no impact on startup time and boot Time.
Avg % [Confidence interval min-max %]
App Startup: 0.31 [-2.42, 3.04]
App RSS: -0.62 [-1.48, 0.25]
App Anon RSS + Swap: -1.86 [-3.46, -0.27]
Memory(PSS): -1.74 [-3.78, 0.29]
Memory(RSS): -0.06 [-0.72, 0.6]
Memory(Private-dirty): -3.52 [-5.99, -1.05]
Boot time: 0.35 [-0.8, 1.5]
Code size: -3.36 MB (-3.93%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.84
image_class_threshold: 0.39
preloaded_classes_threshold: 0.6
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.027857142
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.06
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.027857142
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.06
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.027857142
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.06
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.027857142
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.06
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.027857142
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.06
}
=Profile stats=
Data info:
- total aggregations: 1790
- number of (device types, builds): 234
File boot-image-profile.txt
- hot methods: 1031 added, 1140 removed
- methods: 1031 added, 1140 removed
- classes: 153 added, 57 removed
- totals now: 32516 hot methods, 32516 methods, 17849 classes
- totals before: 32625 hot methods, 32625 methods, 17753 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 943, 1038, 79, 47, 20957, 10423
com.android, 52, 68, 40, 8, 2326, 3536
java, 31, 29, 19, 1, 7241, 2130
android.view, 199, 216, 9, 2, 3398, 1147
android.hardware, 1, 16, 4, 9, 469, 873
android.animation, 63, 63, 0, 0, 413, 89
android.app, 56, 69, 15, 8, 2923, 1185
android.content, 71, 82, 2, 8, 1905, 635
android.graphics, 88, 89, 0, 0, 1974, 371
android.icu, 86, 91, 19, 7, 2043, 1497
android.media, 12, 12, 4, 2, 792, 635
android.net, 22, 22, 0, 0, 252, 222
android.widget, 62, 63, 2, 0, 1403, 445
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 168 added, 70 removed
- totals now: 0 hot methods, 0 methods, 17753 classes
- totals before: 0 hot methods, 0 methods, 17655 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 80, 54, 0, 10365
com.android, 0, 0, 49, 15, 0, 3514
java, 0, 0, 20, 0, 0, 2118
android.view, 0, 0, 16, 3, 0, 1143
android.hardware, 0, 0, 4, 10, 0, 871
android.app, 0, 0, 14, 6, 0, 1181
android.content, 0, 0, 3, 7, 0, 633
android.icu, 0, 0, 8, 7, 0, 1486
android.media, 0, 0, 2, 3, 0, 626
android.net, 0, 0, 0, 1, 0, 221
android.widget, 0, 0, 3, 1, 0, 443
File boot-image-profile.txt
- hot methods: 995 added, 1106 removed
- methods: 995 added, 1106 removed
- classes: 119 added, 56 removed
- totals now: 22386 hot methods, 22386 methods, 14605 classes
- totals before: 22497 hot methods, 22497 methods, 14542 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 943, 1038, 79, 47, 20893, 10392
com.android, 52, 68, 37, 8, 1396, 3124
java, 0, 0, 0, 1, 2, 114
android.view, 199, 216, 9, 2, 3398, 1147
android.hardware, 1, 16, 4, 9, 469, 873
android.animation, 63, 63, 0, 0, 413, 89
android.app, 56, 69, 15, 8, 2923, 1185
android.content, 71, 82, 2, 8, 1905, 635
android.graphics, 88, 89, 0, 0, 1974, 371
android.icu, 86, 91, 19, 7, 2043, 1497
android.media, 12, 12, 4, 2, 792, 635
android.net, 22, 22, 0, 0, 252, 222
android.widget, 62, 63, 2, 0, 1403, 445
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 128 added, 70 removed
- totals now: 0 hot methods, 0 methods, 14523 classes
- totals before: 0 hot methods, 0 methods, 14465 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 80, 54, 0, 10334
com.android, 0, 0, 46, 15, 0, 3103
java, 0, 0, 0, 1, 0, 114
android.view, 0, 0, 16, 3, 0, 1143
android.hardware, 0, 0, 4, 10, 0, 871
android.app, 0, 0, 14, 6, 0, 1181
android.content, 0, 0, 3, 7, 0, 633
android.icu, 0, 0, 8, 7, 0, 1486
android.media, 0, 0, 2, 3, 0, 626
android.net, 0, 0, 0, 1, 0, 221
android.widget, 0, 0, 3, 1, 0, 443
File art-profile
- hot methods: 1362 added, 5742 removed
- methods: 1362 added, 5742 removed
- classes: 26 added, 5 removed
- totals now: 4680 hot methods, 4680 methods, 78 classes
- totals before: 9060 hot methods, 9060 methods, 57 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 4, 29, 1, 0, 22, 1
com.android, 1358, 5713, 25, 4, 4658, 77
java, 0, 0, 0, 1, 0, 0
android.hardware, 3, 26, 1, 0, 19, 1
android.net, 1, 3, 0, 0, 2, 0
InternalReferenceRawProfileId: 39887
InternalReferenceCandidateProfileId: 39896
Test: build & benchmark
Change-Id: If7d2699a79a04490dc1b82537456da5022edea2e
|
|
So far, we have used `instalable: false` to avoid collision with the
other modules that are installed to the same path. A typical example was
<foo> and <foo>.microdroid. The latter is a modified version of the
former for the inclusion of the microdroid image. They however both have
the same instalation path (ex: system/bin) and stem (ex: foo) so that we
can reference them using the same path regardless of whether we are in
Android or microdroid.
However, the use of `installable: false` for the purpose is actually
incorrect, because `installable: false` also means, obviously, "this
module shouldn't be installed". The only reason this incorrect way has
worked is simply because packaging modules (ex: android_filesystem)
didn't respect the property when gathering the modules.
As packaging modules are now fixed to respect `installable: false`, we
need a correct way of avoiding the collision. `no_full_install: true` is
it.
If a module has this property set to true, it is never installed to the
full instal path like out/target/product/<partition>/... It can be
installed only via packaging modules.
Bug: 335369205
Bug: 337993945
Test: m droid aosp_cf_system_x86_64
Change-Id: If9c053968bde39c3eb3b852f1df1d475161bd846
|
|
|
|
Bug: 335369205
Test: m aosp_cf_system_x86_64
Change-Id: I4dbbb163160b8d4daf878deada7b7cae78401f05
|
|
Bug: 254051423
Bug: 324079793
Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
= Perf stats =
(lower is better)
Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
Avg % [Confidence interval min-max %]
App Startup: -0.44 [-2.79, 1.9]
App Anon RSS + Swap: -0.83 [-1.92, 0.25]
Memory(PSS): -1.4 [-4.28, 1.48]
Memory(Private-dirty): -4.48 [-13.31, 4.34]
Boot time: 0.47 [-0.68, 1.62]
Code size: -0.79MB (-0.92%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.46
image_class_threshold: 0.41
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.029285714
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.032857142
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.029285714
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.032857142
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.029285714
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.032857142
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.029285714
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.032857142
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.029285714
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.032857142
}
=Profile stats=
Data info:
- total aggregations: 2263
- number of (device types, builds): 169
File boot-image-profile.txt
- hot methods: 1427 added, 1398 removed
- methods: 1427 added, 1398 removed
- classes: 113 added, 215 removed
- totals now: 32625 hot methods, 32625 methods, 17753 classes
- totals before: 32596 hot methods, 32596 methods, 17855 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 684, 825, 2, 64, 21052, 10391
com.android, 65, 89, 14, 21, 2342, 3504
java, 590, 420, 86, 115, 7239, 2112
android.view, 171, 223, 2, 8, 3415, 1140
android.hardware, 2, 12, 0, 5, 484, 878
android.animation, 59, 59, 0, 0, 413, 89
android.app, 44, 85, 0, 15, 2936, 1178
android.content, 56, 57, 0, 3, 1916, 641
android.graphics, 65, 69, 0, 0, 1975, 371
android.icu, 43, 43, 0, 0, 2048, 1485
android.media, 3, 3, 0, 0, 792, 633
android.net, 8, 8, 0, 6, 252, 222
android.widget, 53, 53, 0, 0, 1404, 443
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 120 added, 214 removed
- totals now: 0 hot methods, 0 methods, 17655 classes
- totals before: 0 hot methods, 0 methods, 17749 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 14, 59, 0, 10339
com.android, 0, 0, 15, 19, 0, 3480
java, 0, 0, 80, 117, 0, 2098
android.view, 0, 0, 1, 4, 0, 1130
android.hardware, 0, 0, 3, 4, 0, 877
android.app, 0, 0, 1, 17, 0, 1173
android.content, 0, 0, 1, 3, 0, 637
android.media, 0, 0, 0, 2, 0, 627
android.net, 0, 0, 0, 6, 0, 222
File boot-image-profile.txt
- hot methods: 723 added, 890 removed
- methods: 723 added, 890 removed
- classes: 2 added, 80 removed
- totals now: 22497 hot methods, 22497 methods, 14542 classes
- totals before: 22664 hot methods, 22664 methods, 14620 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 683, 824, 2, 64, 20988, 10360
com.android, 40, 66, 0, 14, 1412, 3095
java, 0, 0, 0, 1, 2, 115
android.view, 171, 223, 2, 8, 3415, 1140
android.hardware, 2, 12, 0, 5, 484, 878
android.animation, 59, 59, 0, 0, 413, 89
android.app, 44, 85, 0, 15, 2936, 1178
android.content, 56, 57, 0, 3, 1916, 641
android.graphics, 65, 69, 0, 0, 1975, 371
android.icu, 43, 43, 0, 0, 2048, 1485
android.media, 3, 3, 0, 0, 792, 633
android.net, 8, 8, 0, 6, 252, 222
android.widget, 53, 53, 0, 0, 1404, 443
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 15 added, 72 removed
- totals now: 0 hot methods, 0 methods, 14465 classes
- totals before: 0 hot methods, 0 methods, 14522 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 14, 59, 0, 10308
com.android, 0, 0, 1, 11, 0, 3072
java, 0, 0, 0, 1, 0, 115
android.view, 0, 0, 1, 4, 0, 1130
android.hardware, 0, 0, 3, 4, 0, 877
android.app, 0, 0, 1, 17, 0, 1173
android.content, 0, 0, 1, 3, 0, 637
android.media, 0, 0, 0, 2, 0, 627
android.net, 0, 0, 0, 6, 0, 222
File art-profile
- hot methods: 2157 added, 4848 removed
- methods: 2157 added, 4848 removed
- classes: 0 added, 1547 removed
- totals now: 9060 hot methods, 9060 methods, 57 classes
- totals before: 11751 hot methods, 11751 methods, 1604 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 5, 24, 0, 22, 47, 0
com.android, 2152, 4824, 0, 1492, 9013, 56
android.hardware, 4, 12, 0, 8, 42, 0
android.app, 0, 0, 0, 2, 0, 0
android.content, 0, 1, 0, 4, 1, 0
android.net, 1, 7, 0, 3, 4, 0
InternalReferenceRawProfileId: 38926
InternalReferenceCandidateProfileId: 38933
Test: build & benchmark
(cherry picked from https://googleplex-android-review.googlesource.com/q/commit:4b6a26a57e65e2f869c35a54fa3b91e083199dc8)
Merged-In: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
Change-Id: Icb1d1464ad947837eeb679258af67bc4f0e9ba98
NOTE FOR REVIEWERS - errors occurred while applying the patch.
PLEASE REVIEW CAREFULLY.
Errors:
Error applying patch in boot/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
Error applying patch in boot/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
Error applying patch in config/boot-image-profile.txt, hunk HunkHeader[124,19->124,19]: Hunk cannot be applied
Error applying patch in config/preloaded-classes, hunk HunkHeader[211,7->212,6]: Hunk cannot be applied
Error applying patch in services/art-profile, hunk HunkHeader[13,7->13,6]: Hunk cannot be applied
Original patch:
From 4b6a26a57e65e2f869c35a54fa3b91e083199dc8 Mon Sep 17 00:00:00 2001
From: art-benchmark-service <art-benchmark-service@google.com>
Date: Fri, 22 Mar 2024 09:25:24 -0700
Subject: [PATCH] Update boot image and system server profiles [M46C41P62S0PP]
Bug: 254051423
Bug: 324079793
Test: go/art-benchmark?p=BootImageProfileId:38926&f=CandidateName:in:38933
= Perf stats =
(lower is better)
Regular update to the boot image profiles which considers the latest changes in the ART module code instead of depending on the released mainline trains only. Benchmark shows a tiny improvement in App's startup time and Anon RSS+Swap and good improvement in system memory PSS and Private-dirty and almost no impact on boot Time, with a good reduction in code size.
Avg % [Confidence interval min-max %]
App Startup: -0.44 [-2.79, 1.9]
App Anon RSS + Swap: -0.83 [-1.92, 0.25]
Memory(PSS): -1.4 [-4.28, 1.48]
Memory(Private-dirty): -4.48 [-13.31, 4.34]
Boot time: 0.47 [-0.68, 1.62]
C
[[[Original patch trimmed due to size. Decoded string size: 6329. Decoded string SHA1: 1745d06a463192644cf1206f5ecdb8152786d3ff.]]]
Change-Id: I4c2c63c3361c206b3160901fa2fff3e03dcdde5d
|
|
Bug: 335369205
Test: build
Change-Id: I554a594a1b600ba0bb4f3370fef2c62d40fe60ce
|
|
Bug: 319669529
Merged-In: I46c7859ff042ee7aa9193757e5df8269f4892362
Change-Id: I0c7b5036c0b0f5f2caad551edb063350f6eb87e7
|
|
We'd like to limit the usage of libvintf because of its
performance/memory impact. By removing VintfObject and VintfRuntimeInfo
classes from preloaded-classes list, we can avoid loading libvintf from
libandroid_runtime. A new JNI library (libvintf_jni) is loaded only when
it's actually used.
Bug: 270169217
Test: atest VintfObjectTest
Change-Id: I469f368ee04863374988359c28bcd1a5fb4ead9e
|
|
Use new format which allows to specify dirty objects (as opposed to only
dirty classes) and supports object sorting.
Test: m
Bug: 314961378
Change-Id: Ie06539054387f3541fd7cbd63247443fba1d1ca4
|
|
IMagnificationConnection
Considering the connection is handling functions more than window
magnification operations, we would like to rename it as
IMagnificationconnection.
Bug: 310109308
Test: manually. Renaming the class and methods
atest IMagnificationConnectionTest
atest android.view.accessibility.AccessibilityManagerTest
atest MagnificationTest
atest CommandQueueTest
atest com.android.server.accessibility.magnification.FullScreenMagnificationControllerTest
atest MagnificationConnectionWrapperTest
atest MagnificationControllerTest
atest MagnificationConnectionManagerTest
atest WindowMagnificationGestureHandlerTest
Flag: NA
Change-Id: I6a19621dcf83e3c37b99204631e9bc022e894b5a
|
|
This is a partial revert to https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/24913102
Bug: 254051423
Bug: 303339619
Bug: 303378282
Bug: 303394972
Test: ART benchmark go/art-benchmark?p=BootImageProfileId:37045
Test: ATP test https://android-build.corp.google.com/abtd/run/L92000030000204927/
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
Change-Id: Ie3e80163b281c27a381c28b890b6571c8aea9720
|
|
Bug: 254051423
Bug: 303356546
Bug: 303339619
Bug: 303378282
Bug: 303394972
Test: go/art-benchmark?p=BootImageProfileId:36833&f=CandidateName:in:36861
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L85800030000096758
= Perf stats =
(lower is better)
Regular update to the boot image profiles, Benchmark shows an no impact on app cold startup time, boot-time and good memory reduction for system-server process besides fixing some regressions from the prev update, but with a small increase in code size which could be an acceptable cost.
Avg % [Confidence interval min-max %]
Startup: -0.14 [-2.34, 2.06]
Memory(PSS): -0.15 [-1.82, 1.51]
Boot time: 0.19 [-0.68, 1.06]
Code size (.oat + .art + .odex): 0.88MB (1.06%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.29
image_class_threshold: 0.24
preloaded_classes_threshold: 0.6
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.020714285
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.020714285
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.020714285
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.020714285
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.020714285
}
=Profile stats=
Data info:
- total aggregations: 50
- number of (device types, builds): 18
File boot-image-profile.txt
- hot methods: 201 added, 225 removed
- methods: 201 added, 225 removed
- classes: 0 added, 2 removed
- totals now: 32532 hot methods, 32532 methods, 17268 classes
- totals before: 32556 hot methods, 32556 methods, 17270 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 137, 154, 0, 2, 21053, 9950
com.android, 8, 9, 0, 0, 2425, 3481
java, 40, 47, 0, 0, 7086, 2101
android.view, 62, 66, 0, 0, 3444, 1058
android.hardware, 3, 9, 0, 0, 495, 859
android.app, 6, 8, 0, 0, 2952, 1108
android.content, 11, 12, 0, 0, 1892, 585
android.graphics, 8, 8, 0, 0, 1973, 345
android.icu, 10, 10, 0, 0, 2048, 1474
android.media, 1, 1, 0, 0, 792, 604
android.widget, 14, 15, 0, 2, 1403, 397
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 14 added, 2 removed
- totals now: 0 hot methods, 0 methods, 17228 classes
- totals before: 0 hot methods, 0 methods, 17216 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 14, 2, 0, 9922
android.view, 0, 0, 9, 0, 0, 1056
android.app, 0, 0, 3, 0, 0, 1107
android.content, 0, 0, 1, 0, 0, 583
android.widget, 0, 0, 1, 2, 0, 396
File boot-image-profile.txt
- hot methods: 144 added, 162 removed
- methods: 144 added, 162 removed
- classes: 0 added, 2 removed
- totals now: 22501 hot methods, 22501 methods, 14055 classes
- totals before: 22519 hot methods, 22519 methods, 14057 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 137, 154, 0, 2, 20989, 9919
com.android, 7, 8, 0, 0, 1415, 3052
android.view, 62, 66, 0, 0, 3444, 1058
android.hardware, 3, 9, 0, 0, 495, 859
android.app, 6, 8, 0, 0, 2952, 1108
android.content, 11, 12, 0, 0, 1892, 585
android.graphics, 8, 8, 0, 0, 1973, 345
android.icu, 10, 10, 0, 0, 2048, 1474
android.media, 1, 1, 0, 0, 792, 604
android.widget, 14, 15, 0, 2, 1403, 397
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 14 added, 2 removed
- totals now: 0 hot methods, 0 methods, 14019 classes
- totals before: 0 hot methods, 0 methods, 14007 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 14, 2, 0, 9891
android.view, 0, 0, 9, 0, 0, 1056
android.app, 0, 0, 3, 0, 0, 1107
android.content, 0, 0, 1, 0, 0, 583
android.widget, 0, 0, 1, 2, 0, 396
File art-profile
- hot methods: 2073 added, 821 removed
- methods: 2073 added, 821 removed
- classes: 10 added, 2 removed
- totals now: 14004 hot methods, 14004 methods, 1494 classes
- totals before: 12752 hot methods, 12752 methods, 1486 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 21, 26, 0, 0, 86, 25
com.android, 2052, 795, 9, 2, 13918, 1439
android.hardware, 20, 25, 0, 0, 70, 12
android.net, 1, 1, 0, 0, 10, 3
InternalReferenceRawProfileId: 36833
InternalReferenceCandidateProfileId: 36861
Test: build & benchmark
Change-Id: If26794e3e9e3605a8059e846472c300f289dba0e
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36711&f=CandidateName:in:36720
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L47100000963607173
= Perf stats =
(lower is better)
Regular update to the boot image profiles, Benchmark shows an improvement in app cold startup time and good code size reduction, besides no noticeable impact on memory and boot time. This change also will resolve some of the regressions from the prev updates.
Avg % [Confidence interval min-max %]
Startup: -1.37 [-2.51, -0.23]
Memory(PSS): -0.13 [-2.38, 2.13]
Boot time: 0.09 [-0.9, 1.09]
Code size (.oat + .art + .odex): -0.61MB (-0.73%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.27
image_class_threshold: 0.22
preloaded_classes_threshold: 0.58
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.015714286
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.019285714
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.015714286
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.019285714
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.015714286
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.019285714
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.015714286
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.019285714
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.015714286
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.019285714
}
=Profile stats=
Data info:
- total aggregations: 84
- number of (device types, builds): 28
File boot-image-profile.txt
- hot methods: 157 added, 87 removed
- methods: 157 added, 87 removed
- classes: 15 added, 9 removed
- totals now: 32556 hot methods, 32556 methods, 17270 classes
- totals before: 32486 hot methods, 32486 methods, 17264 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 120, 48, 15, 8, 21070, 9952
java, 37, 38, 0, 0, 7093, 2101
android.view, 41, 10, 7, 1, 3448, 1058
android.hardware, 8, 4, 0, 0, 501, 859
android.animation, 14, 0, 7, 0, 411, 82
android.app, 17, 5, 1, 0, 2954, 1108
android.content, 16, 11, 0, 0, 1893, 585
android.graphics, 5, 0, 0, 0, 1973, 345
android.widget, 2, 0, 0, 0, 1404, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 30 added, 10 removed
- totals now: 0 hot methods, 0 methods, 17216 classes
- totals before: 0 hot methods, 0 methods, 17196 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 23, 9, 0, 9910
com.android, 0, 0, 6, 0, 0, 3475
java, 0, 0, 1, 0, 0, 2098
android.view, 0, 0, 6, 0, 0, 1047
android.hardware, 0, 0, 5, 0, 0, 858
android.animation, 0, 0, 2, 0, 0, 75
android.app, 0, 0, 6, 0, 0, 1104
android.media, 0, 0, 1, 0, 0, 601
File boot-image-profile.txt
- hot methods: 120 added, 48 removed
- methods: 120 added, 48 removed
- classes: 15 added, 10 removed
- totals now: 22519 hot methods, 22519 methods, 14057 classes
- totals before: 22447 hot methods, 22447 methods, 14052 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 120, 48, 15, 8, 21006, 9921
java, 0, 0, 0, 1, 2, 115
android.view, 41, 10, 7, 1, 3448, 1058
android.hardware, 8, 4, 0, 0, 501, 859
android.animation, 14, 0, 7, 0, 411, 82
android.app, 17, 5, 1, 0, 2954, 1108
android.content, 16, 11, 0, 0, 1893, 585
android.graphics, 5, 0, 0, 0, 1973, 345
android.widget, 2, 0, 0, 0, 1404, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 29 added, 9 removed
- totals now: 0 hot methods, 0 methods, 14007 classes
- totals before: 0 hot methods, 0 methods, 13987 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 23, 7, 0, 9879
com.android, 0, 0, 6, 0, 0, 3046
java, 0, 0, 0, 1, 0, 115
android.view, 0, 0, 6, 0, 0, 1047
android.hardware, 0, 0, 5, 0, 0, 858
android.animation, 0, 0, 2, 0, 0, 75
android.app, 0, 0, 6, 0, 0, 1104
android.media, 0, 0, 1, 0, 0, 601
File art-profile
- hot methods: 2492 added, 4332 removed
- methods: 2492 added, 4332 removed
- classes: 11 added, 1219 removed
- totals now: 12752 hot methods, 12752 methods, 1486 classes
- totals before: 14592 hot methods, 14592 methods, 2694 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 30, 30, 1, 21, 91, 25
com.android, 2462, 4302, 10, 1181, 12661, 1432
android.hardware, 28, 29, 0, 17, 75, 12
android.app, 0, 1, 0, 2, 0, 2
android.content, 0, 0, 0, 1, 2, 3
android.net, 2, 0, 0, 0, 10, 3
InternalReferenceRawProfileId: 36711
InternalReferenceCandidateProfileId: 36720
Test: build & benchmark
Change-Id: Ibd13bc54c1fd8927030d41f3670021379ebaccc8
|
|
am: 1cafb8a7b2 am: b4c2766158 am: 163336f273 am: 7fa6f4985d am: 704d684a9d
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2482187
Change-Id: I9bce79809c845dcb2e2753aedd5c5aa2539783cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
|
|
|
|
Making changes to use aidl_interface build system in
KeyAttestationApplicationProvider to support Rust, CPP and Java
backends.
Defined AAID interface and its parcelables using AIDL types.
Removed custom parcelables defined for AAID.
Bug: 267452060
Test: atest android.keystore.cts.KeyAttestationTest
Change-Id: Iec558642867c13e2998d7f69f00b3f1adf4e2b62
|
|
Bug: 254051423
Bug: 299558523
Bug: 299514114
Bug: 299595206
Bug: 299572243
Test: go/art-benchmark?p=BootImageProfileId:36420&f=CandidateName:in:36422
Test: ATP test https://android-build.googleplex.com/builds/abtd/run/L12500000963261237
= Perf stats =
(lower is better)
Regular update to the boot image profiles, Benchmark shows an improvement in boot time and great code size reduction, besides no noticeable impact on memory and startup time. This change also will resolve some of the regressions from the prev updates.
Avg % (Confidence interval min-max %)
Startup: 0.12 (-1.19 -> 1.43)
Memory(PSS): -0.53 (-2.16 -> 1.1)
Boot time: -1.09 (-1.8 -> -0.38)
Code size (.oat + .art + .odex): -0.51MB (-0.62%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.25
image_class_threshold: 0.2
preloaded_classes_threshold: 0.56
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.017857144
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.017857144
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.017857144
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.017857144
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.017857144
}
=Profile stats=
Data info:
- total aggregations: 31
- number of (device types, builds): 16
File boot-image-profile.txt
- hot methods: 3145 added, 3473 removed
- methods: 3145 added, 3473 removed
- classes: 24 added, 123 removed
- totals now: 32486 hot methods, 32486 methods, 17264 classes
- totals before: 32814 hot methods, 32814 methods, 17363 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1842, 2107, 20, 122, 20998, 9945
com.android, 146, 181, 4, 1, 2426, 3481
java, 917, 944, 0, 0, 7094, 2101
android.view, 348, 422, 7, 2, 3417, 1052
android.hardware, 18, 29, 1, 0, 497, 859
android.animation, 17, 34, 0, 7, 397, 75
android.app, 136, 140, 8, 0, 2942, 1107
android.content, 196, 200, 1, 0, 1888, 585
android.graphics, 158, 165, 0, 0, 1968, 345
android.icu, 232, 239, 0, 0, 2048, 1474
android.media, 19, 20, 0, 0, 792, 604
android.net, 44, 43, 0, 1, 252, 220
android.widget, 147, 154, 1, 1, 1402, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 139 removed
- totals now: 0 hot methods, 0 methods, 17194 classes
- totals before: 0 hot methods, 0 methods, 17333 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 135, 0, 9894
com.android, 0, 0, 0, 3, 0, 3469
java, 0, 0, 0, 1, 0, 2097
android.view, 0, 0, 0, 6, 0, 1041
android.hardware, 0, 0, 0, 4, 0, 853
android.animation, 0, 0, 0, 9, 0, 73
android.media, 0, 0, 0, 1, 0, 600
android.net, 0, 0, 0, 1, 0, 220
android.widget, 0, 0, 0, 1, 0, 397
File boot-image-profile.txt
- hot methods: 1938 added, 2238 removed
- methods: 1938 added, 2238 removed
- classes: 24 added, 125 removed
- totals now: 22447 hot methods, 22447 methods, 14052 classes
- totals before: 22747 hot methods, 22747 methods, 14153 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1838, 2103, 20, 122, 20934, 9914
com.android, 100, 135, 4, 1, 1416, 3052
java, 0, 0, 0, 2, 2, 116
android.view, 348, 422, 7, 2, 3417, 1052
android.hardware, 18, 29, 1, 0, 497, 859
android.animation, 17, 34, 0, 7, 397, 75
android.app, 136, 140, 8, 0, 2942, 1107
android.content, 196, 200, 1, 0, 1888, 585
android.graphics, 158, 165, 0, 0, 1968, 345
android.icu, 232, 239, 0, 0, 2048, 1474
android.media, 19, 20, 0, 0, 792, 604
android.net, 44, 43, 0, 1, 252, 220
android.widget, 147, 154, 1, 1, 1402, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 140 removed
- totals now: 0 hot methods, 0 methods, 13987 classes
- totals before: 0 hot methods, 0 methods, 14127 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 135, 0, 9863
com.android, 0, 0, 0, 3, 0, 3040
java, 0, 0, 0, 2, 0, 116
android.view, 0, 0, 0, 6, 0, 1041
android.hardware, 0, 0, 0, 4, 0, 853
android.animation, 0, 0, 0, 9, 0, 73
android.media, 0, 0, 0, 1, 0, 600
android.net, 0, 0, 0, 1, 0, 220
android.widget, 0, 0, 0, 1, 0, 397
File art-profile
- hot methods: 5705 added, 3202 removed
- methods: 5705 added, 3202 removed
- classes: 1243 added, 14 removed
- totals now: 14592 hot methods, 14592 methods, 2694 classes
- totals before: 12089 hot methods, 12089 methods, 1465 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 46, 21, 21, 8, 91, 45
com.android, 5659, 3181, 1205, 5, 14501, 2603
java, 0, 0, 0, 1, 0, 0
android.hardware, 45, 19, 17, 1, 76, 29
android.app, 1, 0, 2, 0, 1, 4
android.content, 0, 0, 1, 1, 2, 4
android.net, 0, 2, 0, 0, 8, 3
InternalReferenceRawProfileId: 36420
InternalReferenceCandidateProfileId: 36422
Test: build & benchmark
Change-Id: Ia2d60e41a204ef584c4a1ef91759e97ce37813ce
|
|
Bug: 254051423
Bug: 294603422
Test: go/art-benchmark?p=BootImageProfileId:36349
Test: ATP test http://shortn/_aT2kwyTb9i
= Perf stats =
(lower is better)
Regular update to the boot image profiles, which is adding some missing inline cache to the boot image profiles. Benchmark shows slight improvement in startup time, memory and no noticeable impact on the total boot time, with a very small increase in code size which could be an acceptable cost.
Avg % (Confidence interval min-max %)
Startup: -0.35% (-1.57 -> 0.87)
Memory(PSS): -0.85% (-2.26 -> 0.55)
Boot time: 0.11 (-4.85% -> 5.08)
Code size (.oat + .art + .odex): 0.02MB (0.02%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.31
image_class_threshold: 0.26
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.018571427
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.022142857
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.018571427
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.022142857
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.018571427
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.022142857
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.018571427
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.022142857
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.018571427
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.022142857
}
=Profile stats=
Data info:
- total aggregations: 5691
- number of (device types, builds): 136
File boot-image-profile.txt
- hot methods: 2140 added, 2289 removed
- methods: 2140 added, 2289 removed
- classes: 1 added, 4 removed
- totals now: 32814 hot methods, 32814 methods, 17363 classes
- totals before: 32963 hot methods, 32963 methods, 17366 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1354, 1481, 1, 1, 21263, 10047
com.android, 106, 117, 0, 1, 2461, 3478
java, 508, 513, 0, 1, 7121, 2101
android.view, 249, 272, 0, 0, 3491, 1047
android.hardware, 14, 27, 0, 0, 508, 858
android.animation, 28, 29, 0, 0, 414, 82
android.app, 85, 112, 0, 0, 2946, 1099
android.content, 137, 143, 0, 0, 1892, 584
android.graphics, 138, 142, 0, 0, 1975, 345
android.icu, 196, 205, 0, 0, 2055, 1474
android.media, 31, 32, 0, 0, 793, 604
android.net, 17, 18, 1, 0, 251, 221
android.widget, 139, 147, 0, 0, 1409, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 1 added, 1 removed
- totals now: 0 hot methods, 0 methods, 17333 classes
- totals before: 0 hot methods, 0 methods, 17333 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 1, 0, 0, 10029
com.android, 0, 0, 0, 1, 0, 3472
android.net, 0, 0, 1, 0, 0, 221
File boot-image-profile.txt
- hot methods: 1426 added, 1564 removed
- methods: 1426 added, 1564 removed
- classes: 1 added, 2 removed
- totals now: 22747 hot methods, 22747 methods, 14153 classes
- totals before: 22885 hot methods, 22885 methods, 14154 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1350, 1477, 1, 1, 21199, 10016
com.android, 76, 87, 0, 1, 1451, 3049
android.view, 249, 272, 0, 0, 3491, 1047
android.hardware, 14, 27, 0, 0, 508, 858
android.animation, 28, 29, 0, 0, 414, 82
android.app, 85, 112, 0, 0, 2946, 1099
android.content, 137, 143, 0, 0, 1892, 584
android.graphics, 138, 142, 0, 0, 1975, 345
android.icu, 196, 205, 0, 0, 2055, 1474
android.media, 31, 32, 0, 0, 793, 604
android.net, 17, 18, 1, 0, 251, 221
android.widget, 139, 147, 0, 0, 1409, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 1 added, 1 removed
- totals now: 0 hot methods, 0 methods, 14127 classes
- totals before: 0 hot methods, 0 methods, 14127 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 1, 0, 0, 9998
com.android, 0, 0, 0, 1, 0, 3043
android.net, 0, 0, 1, 0, 0, 221
File art-profile
- hot methods: 1386 added, 2383 removed
- methods: 1386 added, 2383 removed
- classes: 5 added, 22 removed
- totals now: 12089 hot methods, 12089 methods, 1465 classes
- totals before: 13086 hot methods, 13086 methods, 1482 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1, 14, 4, 0, 66, 32
com.android, 1385, 2369, 0, 21, 12023, 1403
java, 0, 0, 1, 0, 0, 1
android.hardware, 1, 14, 0, 0, 50, 13
InternalReferenceRawProfileId: 36330
InternalReferenceCandidateProfileId: 36335
Test: build & benchmark
Change-Id: I4613ceb8f5b25bc52f2f23ca9c106391ebb7d22f
|
|
Since this class should have a lazy loading behavior.
Bug: 297836588
Test: Running ATP `v2/android-crystalball-eng/health/microbench/systemui/systemui-foldable-latency-suite` test
Change-Id: I7f7ee0e8d0db6aa6c58a2b1a0fe8d249887ca97a
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36190&f=CandidateName:in:36196
= Perf stats =
(lower is better)
Regular update to the boot image profiles. Benchmark shows an improvement in total boot time, and no noticeable impact for startup and memory, with a small increase in code size which could be an acceptable cost.
Avg % (Confidence interval min-max %)
Startup: 0.19% (-1.01% -> 1.4%)
Memory(PSS): -0.21% (-1.58% -> 1.17%)
Boot time: -1.4% (-2.41% -> -0.38%)
Code size (.oat + .art + .odex): 0.24MB (0.28%)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.21
image_class_threshold: 0.16
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.015
}
=Profile stats=
Data info:
- total aggregations: 1365
- number of (device types, builds): 70
File boot-image-profile.txt
- hot methods: 1058 added, 1176 removed
- methods: 1058 added, 1176 removed
- classes: 0 added, 14 removed
- totals now: 32963 hot methods, 32963 methods, 17366 classes
- totals before: 33081 hot methods, 33081 methods, 17380 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 670, 765, 0, 7, 21390, 10047
com.android, 72, 85, 0, 6, 2472, 3479
java, 253, 258, 0, 0, 7126, 2102
android.view, 184, 209, 0, 1, 3514, 1047
android.hardware, 20, 23, 0, 0, 521, 858
android.animation, 17, 17, 0, 0, 415, 82
android.app, 37, 89, 0, 5, 2973, 1099
android.content, 77, 77, 0, 0, 1898, 584
android.graphics, 86, 89, 0, 0, 1979, 345
android.icu, 49, 49, 0, 0, 2064, 1474
android.media, 16, 21, 0, 0, 794, 604
android.net, 14, 14, 0, 0, 252, 220
android.widget, 65, 67, 0, 0, 1417, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 13 removed
- totals now: 0 hot methods, 0 methods, 17334 classes
- totals before: 0 hot methods, 0 methods, 17347 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 7, 0, 10028
com.android, 0, 0, 0, 6, 0, 3474
android.view, 0, 0, 0, 1, 0, 1047
android.app, 0, 0, 0, 5, 0, 1098
File boot-image-profile.txt
- hot methods: 718 added, 826 removed
- methods: 718 added, 826 removed
- classes: 0 added, 14 removed
- totals now: 22885 hot methods, 22885 methods, 14154 classes
- totals before: 22993 hot methods, 22993 methods, 14168 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 670, 765, 0, 7, 21326, 10016
com.android, 48, 61, 0, 6, 1462, 3050
android.view, 184, 209, 0, 1, 3514, 1047
android.hardware, 20, 23, 0, 0, 521, 858
android.animation, 17, 17, 0, 0, 415, 82
android.app, 37, 89, 0, 5, 2973, 1099
android.content, 77, 77, 0, 0, 1898, 584
android.graphics, 86, 89, 0, 0, 1979, 345
android.icu, 49, 49, 0, 0, 2064, 1474
android.media, 16, 21, 0, 0, 794, 604
android.net, 14, 14, 0, 0, 252, 220
android.widget, 65, 67, 0, 0, 1417, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 13 removed
- totals now: 0 hot methods, 0 methods, 14128 classes
- totals before: 0 hot methods, 0 methods, 14141 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 7, 0, 9997
com.android, 0, 0, 0, 6, 0, 3045
android.view, 0, 0, 0, 1, 0, 1047
android.app, 0, 0, 0, 5, 0, 1098
File art-profile
- hot methods: 1040 added, 941 removed
- methods: 1040 added, 941 removed
- classes: 5 added, 2 removed
- totals now: 13086 hot methods, 13086 methods, 1482 classes
- totals before: 12987 hot methods, 12987 methods, 1479 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 4, 2, 0, 1, 79, 28
com.android, 1036, 939, 4, 0, 13007, 1424
java, 0, 0, 0, 1, 0, 0
android.hardware, 4, 2, 0, 0, 63, 13
InternalReferenceRawProfileId: 36190
InternalReferenceCandidateProfileId: 36196
Test: build & benchmark
Change-Id: Ib1c3a4f2e42907191c68de754d3e997639426ecc
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36076&f=CandidateName:in:36081
= Perf stats =
(lower is better)
Improvements in total boot time, no noticeable impact for startup and memory, and great reduction in code size.
Startup: 0.63%
Memory(PSS): -0.15%
Boot time: -2.09%
Code size (.oat + .art + .odex): -0.83% (-0.71 MB reduction)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.21
image_class_threshold: 0.16
preloaded_classes_threshold: 0.62
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.015
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.011428571
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.015
}
=Profile stats=
Data info:
- total aggregations: 2977
- number of (device types, builds): 82
File boot-image-profile.txt
- hot methods: 1713 added, 2030 removed
- methods: 1713 added, 2030 removed
- classes: 2 added, 121 removed
- totals now: 33081 hot methods, 33081 methods, 17380 classes
- totals before: 33398 hot methods, 33398 methods, 17499 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1211, 1373, 1, 88, 21485, 10054
com.android, 65, 74, 0, 8, 2485, 3485
java, 344, 463, 0, 0, 7131, 2102
android.view, 315, 345, 0, 0, 3539, 1048
android.hardware, 9, 10, 0, 0, 524, 858
android.bluetooth, 0, 6, 0, 10, 0, 0
android.animation, 11, 11, 0, 0, 415, 82
android.app, 88, 87, 0, 11, 3025, 1104
android.content, 117, 121, 0, 0, 1898, 584
android.graphics, 110, 111, 0, 0, 1982, 345
android.icu, 80, 92, 0, 0, 2064, 1474
android.media, 18, 19, 0, 3, 799, 604
android.net, 28, 88, 0, 40, 252, 220
android.widget, 122, 124, 0, 0, 1419, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 109 removed
- totals now: 0 hot methods, 0 methods, 17347 classes
- totals before: 0 hot methods, 0 methods, 17456 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 76, 0, 10035
com.android, 0, 0, 0, 8, 0, 3480
android.bluetooth, 0, 0, 0, 5, 0, 0
android.app, 0, 0, 0, 10, 0, 1103
android.media, 0, 0, 0, 2, 0, 601
android.net, 0, 0, 0, 39, 0, 220
File boot-image-profile.txt
- hot methods: 1276 added, 3604 removed
- methods: 1276 added, 3604 removed
- classes: 2 added, 941 removed
- totals now: 22993 hot methods, 22993 methods, 14168 classes
- totals before: 25321 hot methods, 25321 methods, 15107 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1213, 1415, 1, 104, 21421, 10023
com.android, 63, 72, 0, 11, 1475, 3056
java, 0, 1986, 0, 668, 2, 118
android.view, 315, 345, 0, 0, 3539, 1048
android.hardware, 9, 10, 0, 0, 524, 858
android.bluetooth, 0, 6, 0, 10, 0, 0
android.animation, 11, 11, 0, 0, 415, 82
android.app, 88, 87, 0, 11, 3025, 1104
android.content, 117, 121, 0, 0, 1898, 584
android.graphics, 110, 111, 0, 0, 1982, 345
android.icu, 82, 91, 0, 0, 2064, 1474
android.media, 18, 19, 0, 3, 799, 604
android.net, 28, 86, 0, 39, 252, 220
android.widget, 122, 124, 0, 0, 1419, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 0 added, 928 removed
- totals now: 0 hot methods, 0 methods, 14141 classes
- totals before: 0 hot methods, 0 methods, 15069 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 0, 92, 0, 10004
com.android, 0, 0, 0, 11, 0, 3051
java, 0, 0, 0, 667, 0, 118
android.bluetooth, 0, 0, 0, 5, 0, 0
android.app, 0, 0, 0, 10, 0, 1103
android.media, 0, 0, 0, 2, 0, 601
android.net, 0, 0, 0, 38, 0, 220
File art-profile
- hot methods: 826 added, 7772 removed
- methods: 826 added, 7772 removed
- classes: 1 added, 3524 removed
- totals now: 12987 hot methods, 12987 methods, 1479 classes
- totals before: 19933 hot methods, 19933 methods, 5002 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 6, 4582, 0, 2507, 77, 29
com.android, 820, 1844, 1, 436, 12910, 1420
java, 0, 1289, 0, 397, 0, 1
android.view, 0, 526, 0, 239, 0, 0
android.hardware, 6, 155, 0, 236, 61, 13
android.bluetooth, 0, 24, 0, 24, 0, 0
android.animation, 0, 39, 0, 13, 0, 0
android.app, 0, 766, 0, 402, 0, 2
android.content, 0, 707, 0, 255, 2, 4
android.graphics, 0, 203, 0, 61, 0, 0
android.icu, 0, 13, 0, 7, 0, 0
android.media, 0, 157, 0, 191, 0, 0
android.net, 0, 200, 0, 114, 10, 3
android.widget, 0, 50, 0, 32, 0, 0
InternalReferenceRawProfileId: 36076
InternalReferenceCandidateProfileId: 36081
Test: build & benchmark
Change-Id: I34b8ef4d89dafb5ce77adbf85f8de829d78f3047
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:36003&f=CandidateName:in:36015
= Perf stats =
(lower is better)
Improvements in Startup, no noticeable impact for boot-time and memory at the cost of a slight increase in code size, which could be an acceptable cost. Also to keep the profile up to date with the code base.
Startup: -1.05%
Memory(PSS): 0.13%
Boot time: 0.22%
Code size (.oat + .art + .odex): 2.75% (2.29 MB increase)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.23
image_class_threshold: 0.18
preloaded_classes_threshold: 0.64
priority_packages_thresholds {
key: "service-appsearch.jar.prof:CLASS:android"
value: 0.012857144
}
priority_packages_thresholds {
key: "service-appsearch.jar.prof:METHOD:android"
value: 0.016428571
}
priority_packages_thresholds {
key: "service-art.jar.prof:CLASS:android"
value: 0.012857144
}
priority_packages_thresholds {
key: "service-art.jar.prof:METHOD:android"
value: 0.016428571
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:CLASS:android"
value: 0.012857144
}
priority_packages_thresholds {
key: "service-connectivity.jar.prof:METHOD:android"
value: 0.016428571
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:CLASS:android"
value: 0.012857144
}
priority_packages_thresholds {
key: "service-wifi.jar.prof:METHOD:android"
value: 0.016428571
}
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.012857144
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.016428571
}
=Profile stats=
Data info:
- total aggregations: 3267
- number of (device types, builds): 53
File boot-image-profile.txt
- hot methods: 2776 added, 2269 removed
- methods: 2776 added, 2269 removed
- classes: 183 added, 62 removed
- totals now: 33398 hot methods, 33398 methods, 17499 classes
- totals before: 32891 hot methods, 32891 methods, 17378 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1643, 1324, 126, 17, 21647, 10141
com.android, 176, 119, 20, 28, 2494, 3493
java, 757, 667, 25, 9, 7250, 2102
android.view, 376, 291, 7, 2, 3569, 1048
android.hardware, 51, 18, 8, 2, 525, 858
android.bluetooth, 6, 0, 10, 0, 6, 10
android.animation, 32, 21, 9, 0, 415, 82
android.app, 116, 110, 17, 2, 3024, 1115
android.content, 135, 133, 0, 1, 1902, 584
android.graphics, 93, 87, 0, 0, 1983, 345
android.icu, 160, 132, 0, 0, 2076, 1474
android.media, 38, 30, 4, 1, 800, 607
android.net, 86, 29, 40, 3, 312, 260
android.widget, 125, 112, 0, 0, 1421, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 173 added, 61 removed
- totals now: 0 hot methods, 0 methods, 17456 classes
- totals before: 0 hot methods, 0 methods, 17344 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 114, 16, 0, 10111
com.android, 0, 0, 23, 28, 0, 3488
java, 0, 0, 25, 9, 0, 2098
android.view, 0, 0, 7, 2, 0, 1048
android.hardware, 0, 0, 7, 2, 0, 857
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 9, 0, 0, 82
android.app, 0, 0, 15, 1, 0, 1113
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 1, 0, 603
android.net, 0, 0, 39, 3, 0, 259
File boot-image-profile.txt
- hot methods: 3931 added, 1398 removed
- methods: 3931 added, 1398 removed
- classes: 995 added, 46 removed
- totals now: 25321 hot methods, 25321 methods, 15107 classes
- totals before: 22788 hot methods, 22788 methods, 14158 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1683, 1324, 142, 17, 21623, 10126
com.android, 130, 73, 23, 28, 1484, 3067
java, 1986, 0, 672, 0, 1988, 786
android.view, 376, 291, 7, 2, 3569, 1048
android.hardware, 51, 18, 8, 2, 525, 858
android.bluetooth, 6, 0, 10, 0, 6, 10
android.animation, 32, 21, 9, 0, 415, 82
android.app, 116, 110, 17, 2, 3024, 1115
android.content, 135, 133, 0, 1, 1902, 584
android.graphics, 93, 87, 0, 0, 1983, 345
android.icu, 159, 134, 0, 0, 2073, 1474
android.media, 38, 30, 4, 1, 800, 607
android.net, 84, 29, 39, 3, 310, 259
android.widget, 125, 112, 0, 0, 1421, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 985 added, 45 removed
- totals now: 0 hot methods, 0 methods, 15069 classes
- totals before: 0 hot methods, 0 methods, 14129 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 130, 16, 0, 10096
com.android, 0, 0, 26, 28, 0, 3062
java, 0, 0, 671, 0, 0, 785
android.view, 0, 0, 7, 2, 0, 1048
android.hardware, 0, 0, 7, 2, 0, 857
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 9, 0, 0, 82
android.app, 0, 0, 15, 1, 0, 1113
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 1, 0, 603
android.net, 0, 0, 38, 3, 0, 258
File art-profile
- hot methods: 10322 added, 2590 removed
- methods: 10322 added, 2590 removed
- classes: 3578 added, 188 removed
- totals now: 19933 hot methods, 19933 methods, 5002 classes
- totals before: 12201 hot methods, 12201 methods, 1612 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 4600, 10, 2515, 2, 4653, 2536
com.android, 4376, 2580, 481, 184, 13934, 1855
java, 1289, 0, 398, 0, 1289, 398
android.view, 526, 0, 239, 0, 526, 239
android.hardware, 172, 9, 237, 0, 210, 249
android.bluetooth, 24, 0, 24, 0, 24, 24
android.animation, 39, 0, 13, 0, 39, 13
android.app, 766, 0, 404, 0, 766, 404
android.content, 707, 0, 256, 1, 709, 259
android.graphics, 203, 0, 61, 0, 203, 61
android.icu, 13, 0, 7, 0, 13, 7
android.media, 157, 0, 191, 0, 157, 191
android.net, 201, 1, 114, 1, 210, 117
android.widget, 50, 0, 32, 0, 50, 32
InternalReferenceRawProfileId: 36003
InternalReferenceCandidateProfileId: 36015
Test: build & benchmark
Change-Id: If8d53eb3c9624604b12fe84886dca7832d29d146
|
|
Revert submission 23615721-u-profiles-v10
Reason for revert: DroidMonitor: Potential culprit for Bug b/286550234 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Reverted changes: /q/submissionid:23615721-u-profiles-v10
Change-Id: I0648be943a1910b82d71b649db381eb294711792
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:35486&f=CandidateName:in:35492
= Perf stats =
(lower is better)
Improvements in Startup, no noticeable impact for boot-time and memory at the cost of a slight increase in code size, which could be an acceptable cost.
Startup: -2.68%
Memory(PSS): -0.44%
Boot time: -0.09%
Code size (.oat + .art + .odex): 0.60% (0.52 MB increase)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.28
image_class_threshold: 0.24
preloaded_classes_threshold: 0.49
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.017142856
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.02
}
=Profile stats=
Data info:
- total aggregations: 1164
- number of (device types, builds): 42
File boot-image-profile.txt
- hot methods: 2052 added, 1777 removed
- methods: 2052 added, 1777 removed
- classes: 178 added, 40 removed
- totals now: 33166 hot methods, 33166 methods, 17516 classes
- totals before: 32891 hot methods, 32891 methods, 17378 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1211, 1053, 123, 8, 21486, 10147
com.android, 98, 81, 19, 28, 2454, 3492
java, 611, 528, 24, 0, 7243, 2110
android.view, 269, 229, 9, 2, 3524, 1050
android.hardware, 23, 9, 8, 0, 506, 860
android.bluetooth, 3, 0, 8, 0, 3, 8
android.animation, 33, 23, 9, 0, 414, 82
android.app, 74, 71, 17, 1, 3021, 1116
android.content, 52, 62, 0, 1, 1890, 584
android.graphics, 89, 87, 0, 0, 1979, 345
android.icu, 172, 155, 0, 0, 2065, 1474
android.media, 22, 21, 4, 0, 793, 608
android.net, 74, 17, 39, 0, 312, 262
android.widget, 98, 99, 0, 0, 1407, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 174 added, 39 removed
- totals now: 0 hot methods, 0 methods, 17479 classes
- totals before: 0 hot methods, 0 methods, 17344 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 114, 7, 0, 10120
com.android, 0, 0, 23, 28, 0, 3488
java, 0, 0, 25, 0, 0, 2107
android.view, 0, 0, 7, 2, 0, 1048
android.hardware, 0, 0, 7, 0, 0, 859
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 9, 0, 0, 82
android.app, 0, 0, 15, 0, 0, 1114
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 0, 0, 604
android.net, 0, 0, 39, 0, 0, 262
File boot-image-profile.txt
- hot methods: 3422 added, 1113 removed
- methods: 3422 added, 1113 removed
- classes: 985 added, 37 removed
- totals now: 25097 hot methods, 25097 methods, 15106 classes
- totals before: 22788 hot methods, 22788 methods, 14158 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 1245, 1056, 139, 8, 21453, 10132
com.android, 73, 56, 22, 28, 1444, 3066
java, 1972, 0, 669, 0, 1974, 783
android.view, 269, 229, 9, 2, 3524, 1050
android.hardware, 23, 9, 8, 0, 506, 860
android.bluetooth, 3, 0, 8, 0, 3, 8
android.animation, 33, 23, 9, 0, 414, 82
android.app, 74, 71, 17, 1, 3021, 1116
android.content, 52, 62, 0, 1, 1890, 584
android.graphics, 89, 87, 0, 0, 1979, 345
android.icu, 165, 161, 0, 0, 2052, 1474
android.media, 22, 21, 4, 0, 793, 608
android.net, 73, 17, 38, 0, 311, 261
android.widget, 98, 99, 0, 0, 1407, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 979 added, 36 removed
- totals now: 0 hot methods, 0 methods, 15072 classes
- totals before: 0 hot methods, 0 methods, 14129 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 130, 7, 0, 10105
com.android, 0, 0, 26, 28, 0, 3062
java, 0, 0, 668, 0, 0, 782
android.view, 0, 0, 7, 2, 0, 1048
android.hardware, 0, 0, 7, 0, 0, 859
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 9, 0, 0, 82
android.app, 0, 0, 15, 0, 0, 1114
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 0, 0, 604
android.net, 0, 0, 38, 0, 0, 261
File art-profile
- hot methods: 8483 added, 2290 removed
- methods: 8483 added, 2290 removed
- classes: 3545 added, 171 removed
- totals now: 18394 hot methods, 18394 methods, 4986 classes
- totals before: 12201 hot methods, 12201 methods, 1612 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 4391, 9, 2495, 2, 4445, 2516
com.android, 2766, 2281, 479, 167, 12623, 1870
java, 1269, 0, 394, 0, 1269, 394
android.view, 511, 0, 244, 0, 511, 244
android.hardware, 137, 8, 236, 0, 176, 248
android.bluetooth, 19, 0, 23, 0, 19, 23
android.animation, 39, 0, 13, 0, 39, 13
android.app, 727, 0, 387, 0, 727, 387
android.content, 688, 0, 257, 1, 690, 260
android.graphics, 199, 0, 61, 0, 199, 61
android.icu, 13, 0, 7, 0, 13, 7
android.media, 140, 0, 187, 0, 140, 187
android.net, 186, 1, 114, 1, 195, 117
android.widget, 49, 0, 32, 0, 49, 32
InternalReferenceRawProfileId: 35486
InternalReferenceCandidateProfileId: 35492
Test: build & benchmark
Change-Id: I4f342f62d4fd8fda86149a67cbbffe35e73d7bfa
|
|
Revert submission 23539173-u-profiles-v9
Reason for revert: It seems causing a regression at b/286024404
Reverted changes: /q/submissionid:23539173-u-profiles-v9
Change-Id: I89d9305878044ebed4de65fb1134b58f2852ccad
|
|
Bug: 254051423
Test: go/art-benchmark?p=BootImageProfileId:35460&f=CandidateName:in:35466
= Perf stats =
(lower is better)
Improvements in Startup and boot times, no noticeable impact for memory at the cost of a slight increase in code size, which could be an acceptable cost.
Startup: -2.02%
Memory(PSS): -0.39%
Boot time: -0.60%
Code size (.oat + .art + .odex): 1.04% (0.99 MB increase)
Ignore-AOSP-First: Boot image profiles
BYPASS_INCLUSIVE_LANGUAGE_REASON: Profile of existing code
=Generation Strategy=
method_threshold: 0.24
image_class_threshold: 0.2
preloaded_classes_threshold: 0.47
priority_packages_thresholds {
key: "services.jar.prof:CLASS:android"
value: 0.014285714
}
priority_packages_thresholds {
key: "services.jar.prof:METHOD:android"
value: 0.017142856
}
=Profile stats=
Data info:
- total aggregations: 4702
- number of (device types, builds): 128
File boot-image-profile.txt
- hot methods: 3348 added, 3043 removed
- methods: 3348 added, 3043 removed
- classes: 173 added, 40 removed
- totals now: 33196 hot methods, 33196 methods, 17511 classes
- totals before: 32891 hot methods, 32891 methods, 17378 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 2085, 1961, 118, 8, 21452, 10142
com.android, 164, 151, 19, 28, 2450, 3492
java, 928, 780, 24, 0, 7308, 2110
android.view, 371, 372, 6, 2, 3483, 1047
android.hardware, 28, 18, 8, 0, 502, 860
android.bluetooth, 4, 0, 8, 0, 4, 8
android.animation, 94, 84, 9, 0, 414, 82
android.app, 225, 221, 16, 1, 3022, 1115
android.content, 219, 222, 0, 1, 1897, 584
android.graphics, 185, 185, 0, 0, 1977, 345
android.icu, 213, 197, 0, 0, 2064, 1474
android.media, 17, 15, 4, 0, 794, 608
android.net, 89, 36, 39, 0, 308, 262
android.widget, 118, 120, 0, 0, 1406, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 159 added, 39 removed
- totals now: 0 hot methods, 0 methods, 17464 classes
- totals before: 0 hot methods, 0 methods, 17344 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 100, 7, 0, 10106
com.android, 0, 0, 22, 28, 0, 3487
java, 0, 0, 25, 0, 0, 2107
android.view, 0, 0, 4, 2, 0, 1045
android.hardware, 0, 0, 7, 0, 0, 859
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 2, 0, 0, 75
android.app, 0, 0, 15, 0, 0, 1114
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 0, 0, 604
android.net, 0, 0, 36, 0, 0, 259
File boot-image-profile.txt
- hot methods: 4351 added, 2072 removed
- methods: 4351 added, 2072 removed
- classes: 980 added, 37 removed
- totals now: 25067 hot methods, 25067 methods, 15101 classes
- totals before: 22788 hot methods, 22788 methods, 14158 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 2121, 1966, 134, 8, 21419, 10127
com.android, 118, 105, 22, 28, 1440, 3066
java, 1980, 0, 669, 0, 1982, 783
android.view, 371, 372, 6, 2, 3483, 1047
android.hardware, 28, 18, 8, 0, 502, 860
android.bluetooth, 4, 0, 8, 0, 4, 8
android.animation, 94, 84, 9, 0, 414, 82
android.app, 225, 221, 16, 1, 3022, 1115
android.content, 219, 222, 0, 1, 1897, 584
android.graphics, 185, 185, 0, 0, 1977, 345
android.icu, 207, 203, 0, 0, 2052, 1474
android.media, 17, 15, 4, 0, 794, 608
android.net, 89, 36, 38, 0, 308, 261
android.widget, 118, 120, 0, 0, 1406, 399
File preloaded-classes
- hot methods: 0 added, 0 removed
- methods: 0 added, 0 removed
- classes: 964 added, 36 removed
- totals now: 0 hot methods, 0 methods, 15057 classes
- totals before: 0 hot methods, 0 methods, 14129 classes
per package info as csv (selected):
package_name, hot_a, hot_r, cl_a, cl_r, hot_num, cl_num
android, 0, 0, 116, 7, 0, 10091
com.android, 0, 0, 25, 28, 0, 3061
java, 0, 0, 668, 0, 0, 782
android.view, 0, 0, 4, 2, 0, 1045
android.hardware, 0, 0, 7, 0, 0, 859
android.bluetooth, 0, 0, 5, 0, 0, 5
android.animation, 0, 0, 2, 0, 0, 75
android.app, 0, 0, 15, 0, 0, 1114
android.content, 0, 0, 0, 1, 0, 582
android.media, 0, 0, 3, 0, 0, 604
android.net, 0, 0, 35, 0, 0, 258
InternalReferenceRawProfileId: 35460
InternalReferenceCandidateProfileId: 35466
Test: build & benchmark
Change-Id: I8379223a4a6972abab46f79fce1d3e6e86121a3e
|