diff options
| -rw-r--r-- | core/java/android/os/Binder.java | 4 | ||||
| -rw-r--r-- | core/jni/Android.bp | 1 | ||||
| -rw-r--r-- | core/jni/android/opengl/util.cpp | 29 | ||||
| -rw-r--r-- | core/jni/android_util_Binder.cpp | 6 |
4 files changed, 8 insertions, 32 deletions
diff --git a/core/java/android/os/Binder.java b/core/java/android/os/Binder.java index 50a3f4c01051..65d05a804c31 100644 --- a/core/java/android/os/Binder.java +++ b/core/java/android/os/Binder.java @@ -529,7 +529,7 @@ public class Binder implements IBinder { protected void finalize() throws Throwable { try { - destroy(); + destroyBinder(); } finally { super.finalize(); } @@ -559,7 +559,7 @@ public class Binder implements IBinder { } private native final void init(); - private native final void destroy(); + private native final void destroyBinder(); // Entry point from android_util_Binder.cpp's onTransact private boolean execTransact(int code, long dataObj, long replyObj, diff --git a/core/jni/Android.bp b/core/jni/Android.bp index a5f7d4f60470..2006be09265a 100644 --- a/core/jni/Android.bp +++ b/core/jni/Android.bp @@ -207,7 +207,6 @@ cc_library_shared { static_libs: [ "libseccomp_policy", "libselinux", - "libcrypto", ], shared_libs: [ diff --git a/core/jni/android/opengl/util.cpp b/core/jni/android/opengl/util.cpp index d4735ec3c94f..41d911150d93 100644 --- a/core/jni/android/opengl/util.cpp +++ b/core/jni/android/opengl/util.cpp @@ -49,27 +49,6 @@ void mx4transform(float x, float y, float z, float w, const float* pM, float* pD pDest[3] = pM[3 + 4 * 0] * x + pM[3 + 4 * 1] * y + pM[3 + 4 * 2] * z + pM[3 + 4 * 3] * w; } -class MallocHelper { -public: - MallocHelper() { - mData = 0; - } - - ~MallocHelper() { - if (mData != 0) { - free(mData); - } - } - - void* alloc(size_t size) { - mData = malloc(size); - return mData; - } - -private: - void* mData; -}; - #if 0 static void @@ -85,10 +64,7 @@ print_poly(const char* label, Poly* pPoly) { static int visibilityTest(float* pWS, float* pPositions, int positionsLength, unsigned short* pIndices, int indexCount) { - MallocHelper mallocHelper; int result = POLY_CLIP_OUT; - float* pTransformed = 0; - int transformedIndexCount = 0; if ( indexCount < 3 ) { return POLY_CLIP_OUT; @@ -116,8 +92,9 @@ int visibilityTest(float* pWS, float* pPositions, int positionsLength, return -1; } - transformedIndexCount = maxIndex - minIndex + 1; - pTransformed = (float*) mallocHelper.alloc(transformedIndexCount * 4 * sizeof(float)); + int transformedIndexCount = maxIndex - minIndex + 1; + std::unique_ptr<float[]> holder{new float[transformedIndexCount * 4]}; + float* pTransformed = holder.get(); if (pTransformed == 0 ) { return -2; diff --git a/core/jni/android_util_Binder.cpp b/core/jni/android_util_Binder.cpp index 26b00344b789..e2aa17b32d0b 100644 --- a/core/jni/android_util_Binder.cpp +++ b/core/jni/android_util_Binder.cpp @@ -836,7 +836,7 @@ static void android_os_Binder_init(JNIEnv* env, jobject obj) env->SetLongField(obj, gBinderOffsets.mObject, (jlong)jbh); } -static void android_os_Binder_destroy(JNIEnv* env, jobject obj) +static void android_os_Binder_destroyBinder(JNIEnv* env, jobject obj) { JavaBBinderHolder* jbh = (JavaBBinderHolder*) env->GetLongField(obj, gBinderOffsets.mObject); @@ -847,7 +847,7 @@ static void android_os_Binder_destroy(JNIEnv* env, jobject obj) } else { // Encountering an uninitialized binder is harmless. All it means is that // the Binder was only partially initialized when its finalizer ran and called - // destroy(). The Binder could be partially initialized for several reasons. + // destroyBinder(). The Binder could be partially initialized for several reasons. // For example, a Binder subclass constructor might have thrown an exception before // it could delegate to its superclass's constructor. Consequently init() would // not have been called and the holder pointer would remain NULL. @@ -872,7 +872,7 @@ static const JNINativeMethod gBinderMethods[] = { { "getThreadStrictModePolicy", "()I", (void*)android_os_Binder_getThreadStrictModePolicy }, { "flushPendingCommands", "()V", (void*)android_os_Binder_flushPendingCommands }, { "init", "()V", (void*)android_os_Binder_init }, - { "destroy", "()V", (void*)android_os_Binder_destroy }, + { "destroyBinder", "()V", (void*)android_os_Binder_destroyBinder }, { "blockUntilThreadAvailable", "()V", (void*)android_os_Binder_blockUntilThreadAvailable } }; |