diff options
-rw-r--r-- | libs/androidfw/AttributeResolution.cpp | 2 | ||||
-rw-r--r-- | libs/androidfw/ZipUtils.cpp | 2 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/AssetDir.h | 2 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/BackupHelpers.h | 4 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/ConfigDescription.h | 2 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/DisplayEventDispatcher.h | 2 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/ResourceTypes.h | 6 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/StringPiece.h | 4 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/TypeWrappers.h | 2 | ||||
-rw-r--r-- | libs/androidfw/include/androidfw/Util.h | 2 |
10 files changed, 14 insertions, 14 deletions
diff --git a/libs/androidfw/AttributeResolution.cpp b/libs/androidfw/AttributeResolution.cpp index 57e3491895e6..3dc1f2cd56c5 100644 --- a/libs/androidfw/AttributeResolution.cpp +++ b/libs/androidfw/AttributeResolution.cpp @@ -51,7 +51,7 @@ class XmlAttributeFinder class BagAttributeFinder : public BackTrackingAttributeFinder<BagAttributeFinder, const ResolvedBag::Entry*> { public: - BagAttributeFinder(const ResolvedBag* bag) + explicit BagAttributeFinder(const ResolvedBag* bag) : BackTrackingAttributeFinder(bag != nullptr ? bag->entries : nullptr, bag != nullptr ? bag->entries + bag->entry_count : nullptr) { } diff --git a/libs/androidfw/ZipUtils.cpp b/libs/androidfw/ZipUtils.cpp index 5d243da2097c..5be2105fe404 100644 --- a/libs/androidfw/ZipUtils.cpp +++ b/libs/androidfw/ZipUtils.cpp @@ -37,7 +37,7 @@ using namespace android; // TODO: This can go away once the only remaining usage in aapt goes away. class FileReader : public zip_archive::Reader { public: - FileReader(FILE* fp) : Reader(), mFp(fp), mCurrentOffset(0) { + explicit FileReader(FILE* fp) : Reader(), mFp(fp), mCurrentOffset(0) { } bool ReadAtOffset(uint8_t* buf, size_t len, uint32_t offset) const { diff --git a/libs/androidfw/include/androidfw/AssetDir.h b/libs/androidfw/include/androidfw/AssetDir.h index 7aef02dc4133..ce6e066d6a16 100644 --- a/libs/androidfw/include/androidfw/AssetDir.h +++ b/libs/androidfw/include/androidfw/AssetDir.h @@ -78,7 +78,7 @@ private: class FileInfo { public: FileInfo(void) {} - FileInfo(const String8& path) // useful for e.g. svect.indexOf + explicit FileInfo(const String8& path) // useful for e.g. svect.indexOf : mFileName(path), mFileType(kFileTypeUnknown) {} ~FileInfo(void) {} diff --git a/libs/androidfw/include/androidfw/BackupHelpers.h b/libs/androidfw/include/androidfw/BackupHelpers.h index fc1ad4717c16..2da247b77c0a 100644 --- a/libs/androidfw/include/androidfw/BackupHelpers.h +++ b/libs/androidfw/include/androidfw/BackupHelpers.h @@ -67,7 +67,7 @@ struct FileRec { class BackupDataWriter { public: - BackupDataWriter(int fd); + explicit BackupDataWriter(int fd); // does not close fd ~BackupDataWriter(); @@ -104,7 +104,7 @@ private: class BackupDataReader { public: - BackupDataReader(int fd); + explicit BackupDataReader(int fd); // does not close fd ~BackupDataReader(); diff --git a/libs/androidfw/include/androidfw/ConfigDescription.h b/libs/androidfw/include/androidfw/ConfigDescription.h index 29424c4462aa..6fa089aeb12c 100644 --- a/libs/androidfw/include/androidfw/ConfigDescription.h +++ b/libs/androidfw/include/androidfw/ConfigDescription.h @@ -82,7 +82,7 @@ struct ConfigDescription : public ResTable_config { static void ApplyVersionForCompatibility(ConfigDescription* config); ConfigDescription(); - ConfigDescription(const android::ResTable_config& o); // NOLINT(implicit) + ConfigDescription(const android::ResTable_config& o); // NOLINT(google-explicit-constructor) ConfigDescription(const ConfigDescription& o); ConfigDescription(ConfigDescription&& o) noexcept; diff --git a/libs/androidfw/include/androidfw/DisplayEventDispatcher.h b/libs/androidfw/include/androidfw/DisplayEventDispatcher.h index e1dfb9490c60..bf35aa3c15bb 100644 --- a/libs/androidfw/include/androidfw/DisplayEventDispatcher.h +++ b/libs/androidfw/include/androidfw/DisplayEventDispatcher.h @@ -22,7 +22,7 @@ namespace android { class DisplayEventDispatcher : public LooperCallback { public: - DisplayEventDispatcher(const sp<Looper>& looper, + explicit DisplayEventDispatcher(const sp<Looper>& looper, ISurfaceComposer::VsyncSource vsyncSource = ISurfaceComposer::eVsyncSourceApp); status_t initialize(); diff --git a/libs/androidfw/include/androidfw/ResourceTypes.h b/libs/androidfw/include/androidfw/ResourceTypes.h index cf2d8fb3251c..9b05d1f64e08 100644 --- a/libs/androidfw/include/androidfw/ResourceTypes.h +++ b/libs/androidfw/include/androidfw/ResourceTypes.h @@ -693,7 +693,7 @@ class ResXMLTree; class ResXMLParser { public: - ResXMLParser(const ResXMLTree& tree); + explicit ResXMLParser(const ResXMLTree& tree); enum event_code_t { BAD_DOCUMENT = -1, @@ -806,7 +806,7 @@ public: * The tree stores a clone of the specified DynamicRefTable, so any changes to the original * DynamicRefTable will not affect this tree after instantiation. **/ - ResXMLTree(const DynamicRefTable* dynamicRefTable); + explicit ResXMLTree(const DynamicRefTable* dynamicRefTable); ResXMLTree(); ~ResXMLTree(); @@ -1844,7 +1844,7 @@ public: class Theme { public: - Theme(const ResTable& table); + explicit Theme(const ResTable& table); ~Theme(); inline const ResTable& getResTable() const { return mTable; } diff --git a/libs/androidfw/include/androidfw/StringPiece.h b/libs/androidfw/include/androidfw/StringPiece.h index a33865f4d34f..921877dc4982 100644 --- a/libs/androidfw/include/androidfw/StringPiece.h +++ b/libs/androidfw/include/androidfw/StringPiece.h @@ -52,8 +52,8 @@ class BasicStringPiece { BasicStringPiece(); BasicStringPiece(const BasicStringPiece<TChar>& str); - BasicStringPiece(const std::basic_string<TChar>& str); // NOLINT(implicit) - BasicStringPiece(const TChar* str); // NOLINT(implicit) + BasicStringPiece(const std::basic_string<TChar>& str); // NOLINT(google-explicit-constructor) + BasicStringPiece(const TChar* str); // NOLINT(google-explicit-constructor) BasicStringPiece(const TChar* str, size_t len); BasicStringPiece<TChar>& operator=(const BasicStringPiece<TChar>& rhs); diff --git a/libs/androidfw/include/androidfw/TypeWrappers.h b/libs/androidfw/include/androidfw/TypeWrappers.h index 5cfe54e5759d..fb2fad619011 100644 --- a/libs/androidfw/include/androidfw/TypeWrappers.h +++ b/libs/androidfw/include/androidfw/TypeWrappers.h @@ -23,7 +23,7 @@ namespace android { struct TypeVariant { - TypeVariant(const ResTable_type* data); + explicit TypeVariant(const ResTable_type* data); class iterator { public: diff --git a/libs/androidfw/include/androidfw/Util.h b/libs/androidfw/include/androidfw/Util.h index 10d088e02829..aa1466fde778 100644 --- a/libs/androidfw/include/androidfw/Util.h +++ b/libs/androidfw/include/androidfw/Util.h @@ -46,7 +46,7 @@ class unique_cptr { using pointer = typename std::add_pointer<T>::type; constexpr unique_cptr() : ptr_(nullptr) {} - constexpr unique_cptr(std::nullptr_t) : ptr_(nullptr) {} + constexpr explicit unique_cptr(std::nullptr_t) : ptr_(nullptr) {} explicit unique_cptr(pointer ptr) : ptr_(ptr) {} unique_cptr(unique_cptr&& o) noexcept : ptr_(o.ptr_) { o.ptr_ = nullptr; } |