diff options
11 files changed, 40 insertions, 53 deletions
diff --git a/core/java/android/inputmethodservice/navigationbar/NavigationBarConstants.java b/core/java/android/inputmethodservice/navigationbar/NavigationBarConstants.java index 4bb66ed26cbc..93c54395f972 100644 --- a/core/java/android/inputmethodservice/navigationbar/NavigationBarConstants.java +++ b/core/java/android/inputmethodservice/navigationbar/NavigationBarConstants.java @@ -17,7 +17,6 @@ package android.inputmethodservice.navigationbar; import android.annotation.ColorInt; -import android.graphics.Color; final class NavigationBarConstants { private NavigationBarConstants() { @@ -28,13 +27,13 @@ final class NavigationBarConstants { // TODO(b/215443343): Handle this in the drawable then remove this constant. static final float NAVBAR_BACK_BUTTON_IME_OFFSET = 2.0f; - // Copied from "white" at packages/SettingsLib/res/values/colors.xml + // Copied from "light_mode_icon_color_single_tone" at packages/SettingsLib/res/values/colors.xml @ColorInt - static final int WHITE = Color.WHITE; + static final int LIGHT_MODE_ICON_COLOR_SINGLE_TONE = 0xffffffff; - // Copied from "black" at packages/SettingsLib/res/values/colors.xml + // Copied from "dark_mode_icon_color_single_tone" at packages/SettingsLib/res/values/colors.xml @ColorInt - static final int BLACK = Color.BLACK; + static final int DARK_MODE_ICON_COLOR_SINGLE_TONE = 0x99000000; // Copied from "navigation_bar_deadzone_hold" static final int NAVIGATION_BAR_DEADZONE_HOLD = 333; diff --git a/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java b/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java index b522e9bdca45..e28f34528f42 100644 --- a/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java +++ b/core/java/android/inputmethodservice/navigationbar/NavigationBarView.java @@ -16,8 +16,8 @@ package android.inputmethodservice.navigationbar; -import static android.inputmethodservice.navigationbar.NavigationBarConstants.BLACK; -import static android.inputmethodservice.navigationbar.NavigationBarConstants.WHITE; +import static android.inputmethodservice.navigationbar.NavigationBarConstants.DARK_MODE_ICON_COLOR_SINGLE_TONE; +import static android.inputmethodservice.navigationbar.NavigationBarConstants.LIGHT_MODE_ICON_COLOR_SINGLE_TONE; import static android.inputmethodservice.navigationbar.NavigationBarConstants.NAVBAR_BACK_BUTTON_IME_OFFSET; import static android.inputmethodservice.navigationbar.NavigationBarUtils.dpToPx; import static android.view.WindowManagerPolicyConstants.NAV_BAR_MODE_GESTURAL; @@ -83,8 +83,8 @@ public final class NavigationBarView extends FrameLayout { super(context, attrs); mLightContext = context; - mLightIconColor = WHITE; - mDarkIconColor = BLACK; + mLightIconColor = LIGHT_MODE_ICON_COLOR_SINGLE_TONE; + mDarkIconColor = DARK_MODE_ICON_COLOR_SINGLE_TONE; mConfiguration = new Configuration(); mTmpLastConfiguration = new Configuration(); diff --git a/packages/SettingsLib/res/values/colors.xml b/packages/SettingsLib/res/values/colors.xml index f89fe935df38..67139b510d85 100644 --- a/packages/SettingsLib/res/values/colors.xml +++ b/packages/SettingsLib/res/values/colors.xml @@ -14,8 +14,7 @@ limitations under the License. --> -<resources xmlns:android="http://schemas.android.com/apk/res/android" - xmlns:androidprv="http://schemas.android.com/apk/prv/res/android"> +<resources> <color name="disabled_text_color">#66000000</color> <!-- 38% black --> <color name="bt_color_icon_1">#b4a50e0e</color> <!-- 72% Material Red 900 --> @@ -34,8 +33,8 @@ <color name="bt_color_bg_6">#e9d2fd</color> <!-- Material Purple 100 --> <color name="bt_color_bg_7">#cbf0f8</color> <!-- Material Cyan 100 --> - <color name="black">@*android:color/black</color> - <color name="white">@*android:color/white</color> + <color name="dark_mode_icon_color_single_tone">#99000000</color> + <color name="light_mode_icon_color_single_tone">#ffffff</color> <color name="user_avatar_color_bg">?android:attr/colorBackgroundFloating</color> diff --git a/packages/SettingsLib/src/com/android/settingslib/graph/SignalDrawable.java b/packages/SettingsLib/src/com/android/settingslib/graph/SignalDrawable.java index 6c2bd412cfbd..ef0f6cbc6ed9 100644 --- a/packages/SettingsLib/src/com/android/settingslib/graph/SignalDrawable.java +++ b/packages/SettingsLib/src/com/android/settingslib/graph/SignalDrawable.java @@ -100,9 +100,9 @@ public class SignalDrawable extends DrawableWrapper { mCutoutHeightFraction = context.getResources().getFloat( com.android.internal.R.dimen.config_signalCutoutHeightFraction); mDarkModeFillColor = Utils.getColorStateListDefaultColor(context, - R.color.black); + R.color.dark_mode_icon_color_single_tone); mLightModeFillColor = Utils.getColorStateListDefaultColor(context, - R.color.white); + R.color.light_mode_icon_color_single_tone); mIntrinsicSize = context.getResources().getDimensionPixelSize(R.dimen.signal_icon_size); mTransparentPaint.setColor(context.getColor(android.R.color.transparent)); mTransparentPaint.setXfermode(new PorterDuffXfermode(PorterDuff.Mode.SRC_IN)); diff --git a/packages/SystemUI/res/values/colors.xml b/packages/SystemUI/res/values/colors.xml index ca55c2394203..0350cd7dab98 100644 --- a/packages/SystemUI/res/values/colors.xml +++ b/packages/SystemUI/res/values/colors.xml @@ -100,8 +100,8 @@ <!-- The color of the navigation bar icons. Need to be in sync with ic_sysbar_* --> <color name="navigation_bar_icon_color">#E5FFFFFF</color> - <color name="white">@*android:color/white</color> - <color name="black">@*android:color/black</color> + <color name="navigation_bar_home_handle_light_color">#EBffffff</color> + <color name="navigation_bar_home_handle_dark_color">#99000000</color> <!-- The shadow color for light navigation bar icons. --> <color name="nav_key_button_shadow_color">#30000000</color> diff --git a/packages/SystemUI/res/values/config.xml b/packages/SystemUI/res/values/config.xml index 84d5dcbae253..80b9ec7748b9 100644 --- a/packages/SystemUI/res/values/config.xml +++ b/packages/SystemUI/res/values/config.xml @@ -56,7 +56,7 @@ enabled for OLED devices to reduce/prevent burn in on the navigation bar (because of the black background and static button placements) and disabled for all other devices to prevent wasting cpu cycles on the dimming animation --> - <bool name="config_navigation_bar_enable_auto_dim_no_visible_wallpaper">false</bool> + <bool name="config_navigation_bar_enable_auto_dim_no_visible_wallpaper">true</bool> <!-- The maximum number of tiles in the QuickQSPanel --> <integer name="quick_qs_panel_max_tiles">4</integer> diff --git a/packages/SystemUI/res/values/styles.xml b/packages/SystemUI/res/values/styles.xml index 047578c43159..7475eb2eceaa 100644 --- a/packages/SystemUI/res/values/styles.xml +++ b/packages/SystemUI/res/values/styles.xml @@ -622,14 +622,14 @@ <style name="DualToneLightTheme"> <item name="iconBackgroundColor">@color/light_mode_icon_color_dual_tone_background</item> <item name="fillColor">@color/light_mode_icon_color_dual_tone_fill</item> - <item name="singleToneColor">@color/white</item> - <item name="homeHandleColor">@color/white</item> + <item name="singleToneColor">@color/light_mode_icon_color_single_tone</item> + <item name="homeHandleColor">@color/navigation_bar_home_handle_light_color</item> </style> <style name="DualToneDarkTheme"> <item name="iconBackgroundColor">@color/dark_mode_icon_color_dual_tone_background</item> <item name="fillColor">@color/dark_mode_icon_color_dual_tone_fill</item> - <item name="singleToneColor">@color/black</item> - <item name="homeHandleColor">@color/black</item> + <item name="singleToneColor">@color/dark_mode_icon_color_single_tone</item> + <item name="homeHandleColor">@color/navigation_bar_home_handle_dark_color</item> </style> <style name="QSHeaderDarkTheme"> <item name="iconBackgroundColor">@color/dark_mode_qs_icon_color_dual_tone_background</item> @@ -648,7 +648,7 @@ <item name="singleToneColor">?android:attr/textColorPrimary</item> </style> <style name="ScreenPinningRequestTheme" parent="@*android:style/ThemeOverlay.DeviceDefault.Accent"> - <item name="singleToneColor">@color/white</item> + <item name="singleToneColor">@color/light_mode_icon_color_single_tone</item> </style> <style name="TextAppearance.Volume"> diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/DarkIconDispatcherImpl.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/DarkIconDispatcherImpl.java index bd0097e8fc3f..398c1d43d4fc 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/DarkIconDispatcherImpl.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/DarkIconDispatcherImpl.java @@ -74,9 +74,9 @@ public class DarkIconDispatcherImpl implements SysuiDarkIconDispatcher, mLightModeIconColorSingleTone = Color.WHITE; } else { mDarkModeIconColorSingleTone = context.getColor( - com.android.settingslib.R.color.black); + com.android.settingslib.R.color.dark_mode_icon_color_single_tone); mLightModeIconColorSingleTone = context.getColor( - com.android.settingslib.R.color.white); + com.android.settingslib.R.color.light_mode_icon_color_single_tone); } mTransitionsController = lightBarTransitionsControllerFactory.create(this); diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/KeyguardStatusBarView.java b/packages/SystemUI/src/com/android/systemui/statusbar/phone/KeyguardStatusBarView.java index d0a62e77539f..84e601848b91 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/KeyguardStatusBarView.java +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/KeyguardStatusBarView.java @@ -455,8 +455,8 @@ public class KeyguardStatusBarView extends RelativeLayout { float luminance = Color.luminance(textColor); @ColorInt int iconColor = Utils.getColorStateListDefaultColor(mContext, luminance < 0.5 - ? com.android.settingslib.R.color.black - : com.android.settingslib.R.color.white); + ? com.android.settingslib.R.color.dark_mode_icon_color_single_tone + : com.android.settingslib.R.color.light_mode_icon_color_single_tone); @ColorInt int contrastColor = luminance < 0.5 ? DarkIconDispatcherImpl.DEFAULT_ICON_TINT : DarkIconDispatcherImpl.DEFAULT_INVERSE_ICON_TINT; @@ -467,7 +467,7 @@ public class KeyguardStatusBarView extends RelativeLayout { if (userSwitcherName != null) { userSwitcherName.setTextColor(Utils.getColorStateListDefaultColor( mContext, - com.android.settingslib.R.color.white)); + com.android.settingslib.R.color.light_mode_icon_color_single_tone)); } if (iconManager != null) { diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/phone/LetterboxAppearanceCalculator.kt b/packages/SystemUI/src/com/android/systemui/statusbar/phone/LetterboxAppearanceCalculator.kt index 824415eaea05..231a8c65a246 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/phone/LetterboxAppearanceCalculator.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/phone/LetterboxAppearanceCalculator.kt @@ -39,7 +39,7 @@ data class LetterboxAppearance( ) { override fun toString(): String { val appearanceString = - ViewDebug.flagsToString(InsetsFlags::class.java, "appearance", appearance) + ViewDebug.flagsToString(InsetsFlags::class.java, "appearance", appearance) return "LetterboxAppearance{$appearanceString, $appearanceRegions}" } } @@ -57,16 +57,14 @@ constructor( private val letterboxBackgroundProvider: LetterboxBackgroundProvider, ) : Dumpable { - private val darkAppearanceIconColor = - context.getColor( - // For a dark background status bar, use a *light* icon color. - com.android.settingslib.R.color.white - ) - private val lightAppearanceIconColor = - context.getColor( - // For a light background status bar, use a *dark* icon color. - com.android.settingslib.R.color.black - ) + private val darkAppearanceIconColor = context.getColor( + // For a dark background status bar, use a *light* icon color. + com.android.settingslib.R.color.light_mode_icon_color_single_tone + ) + private val lightAppearanceIconColor = context.getColor( + // For a light background status bar, use a *dark* icon color. + com.android.settingslib.R.color.dark_mode_icon_color_single_tone + ) init { dumpManager.registerCriticalDumpable(this) @@ -87,11 +85,7 @@ constructor( lastAppearanceRegions = originalAppearanceRegions lastLetterboxes = letterboxes return getLetterboxAppearanceInternal( - letterboxes, - originalAppearance, - originalAppearanceRegions, - statusBarBounds - ) + letterboxes, originalAppearance, originalAppearanceRegions, statusBarBounds) .also { lastLetterboxAppearance = it } } @@ -144,9 +138,7 @@ constructor( // full bounds of its window. // Here we want the bounds to be only for the inner bounds of the letterboxed app. AppearanceRegion( - appearanceRegion.appearance, - matchingLetterbox.letterboxInnerBounds - ) + appearanceRegion.appearance, matchingLetterbox.letterboxInnerBounds) } } @@ -156,8 +148,7 @@ constructor( ): LetterboxAppearance { return LetterboxAppearance( originalAppearance or APPEARANCE_SEMI_TRANSPARENT_STATUS_BARS, - originalAppearanceRegions - ) + originalAppearanceRegions) } @Appearance @@ -224,9 +215,7 @@ constructor( lastAppearanceRegion: $lastAppearanceRegions, lastLetterboxes: $lastLetterboxes, lastLetterboxAppearance: $lastLetterboxAppearance - """ - .trimIndent() - ) + """.trimIndent()) } } diff --git a/packages/SystemUI/tests/src/com/android/systemui/navigationbar/views/NavigationBarTransitionsTest.java b/packages/SystemUI/tests/src/com/android/systemui/navigationbar/views/NavigationBarTransitionsTest.java index b0265c07363f..3621ab975daf 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/navigationbar/views/NavigationBarTransitionsTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/navigationbar/views/NavigationBarTransitionsTest.java @@ -103,7 +103,7 @@ public class NavigationBarTransitionsTest extends SysuiTestCase { public void setIsLightsOut_AutoDim() { mTransitions.setAutoDim(true); - assertTrue(mTransitions.isLightsOut(BarTransitions.MODE_LIGHTS_OUT_TRANSPARENT)); + assertTrue(mTransitions.isLightsOut(BarTransitions.MODE_OPAQUE)); assertTrue(mTransitions.isLightsOut(BarTransitions.MODE_LIGHTS_OUT)); } |