diff options
| -rw-r--r-- | include/media/stagefright/OMXCodec.h | 2 | ||||
| -rwxr-xr-x | media/libstagefright/OMXCodec.cpp | 19 |
2 files changed, 11 insertions, 10 deletions
diff --git a/include/media/stagefright/OMXCodec.h b/include/media/stagefright/OMXCodec.h index 2932744f0e6b..8baf5ec4b360 100644 --- a/include/media/stagefright/OMXCodec.h +++ b/include/media/stagefright/OMXCodec.h @@ -303,7 +303,7 @@ private: bool flushPortAsync(OMX_U32 portIndex); void disablePortAsync(OMX_U32 portIndex); - void enablePortAsync(OMX_U32 portIndex); + status_t enablePortAsync(OMX_U32 portIndex); static size_t countBuffersWeOwn(const Vector<BufferInfo> &buffers); static bool isIntermediateState(State state); diff --git a/media/libstagefright/OMXCodec.cpp b/media/libstagefright/OMXCodec.cpp index 9ab470bb7319..6280f51c5db1 100755 --- a/media/libstagefright/OMXCodec.cpp +++ b/media/libstagefright/OMXCodec.cpp @@ -2452,13 +2452,16 @@ void OMXCodec::onCmdComplete(OMX_COMMANDTYPE cmd, OMX_U32 data) { mOutputPortSettingsHaveChanged = formatChanged; } - enablePortAsync(portIndex); - - status_t err = allocateBuffersOnPort(portIndex); - + status_t err = enablePortAsync(portIndex); if (err != OK) { - CODEC_LOGE("allocateBuffersOnPort failed (err = %d)", err); + CODEC_LOGE("enablePortAsync(%ld) failed (err = %d)", portIndex, err); setState(ERROR); + } else { + err = allocateBuffersOnPort(portIndex); + if (err != OK) { + CODEC_LOGE("allocateBuffersOnPort failed (err = %d)", err); + setState(ERROR); + } } } break; @@ -2773,16 +2776,14 @@ void OMXCodec::disablePortAsync(OMX_U32 portIndex) { freeBuffersOnPort(portIndex, true); } -void OMXCodec::enablePortAsync(OMX_U32 portIndex) { +status_t OMXCodec::enablePortAsync(OMX_U32 portIndex) { CHECK(mState == EXECUTING || mState == RECONFIGURING); CHECK_EQ((int)mPortStatus[portIndex], (int)DISABLED); mPortStatus[portIndex] = ENABLING; CODEC_LOGV("sending OMX_CommandPortEnable(%ld)", portIndex); - status_t err = - mOMX->sendCommand(mNode, OMX_CommandPortEnable, portIndex); - CHECK_EQ(err, (status_t)OK); + return mOMX->sendCommand(mNode, OMX_CommandPortEnable, portIndex); } void OMXCodec::fillOutputBuffers() { |