summaryrefslogtreecommitdiff
path: root/wifi/java
diff options
context:
space:
mode:
author Isaac Katzenelson <isaackatz@google.com> 2023-03-08 00:34:42 +0000
committer Isaac Katzenelson <isaackatz@google.com> 2023-03-08 17:45:11 +0000
commit61fcbaf7a3790b381af0e5272682d69c5e469ecb (patch)
tree858ed974e2b2579c12c23c22f6f072760a292104 /wifi/java
parent649a3e61e439136e9b2ab3c13cf0f55488130bc5 (diff)
Fix getters to return null on failure.
Per API review comment, changed getters for hotspot and known network to return null on failure. Fixed tests to correspond to the fix. Bug: 271178371 Test: atest SharedConnectivityManagerTest Change-Id: I6a1aac661d1d0f7a730d52a1ee92fd6ea2705cf5
Diffstat (limited to 'wifi/java')
-rw-r--r--wifi/java/src/android/net/wifi/sharedconnectivity/app/SharedConnectivityManager.java18
1 files changed, 10 insertions, 8 deletions
diff --git a/wifi/java/src/android/net/wifi/sharedconnectivity/app/SharedConnectivityManager.java b/wifi/java/src/android/net/wifi/sharedconnectivity/app/SharedConnectivityManager.java
index 684b385d60e8..604641520252 100644
--- a/wifi/java/src/android/net/wifi/sharedconnectivity/app/SharedConnectivityManager.java
+++ b/wifi/java/src/android/net/wifi/sharedconnectivity/app/SharedConnectivityManager.java
@@ -434,14 +434,15 @@ public class SharedConnectivityManager {
/**
* Gets the list of hotspot networks the user can select to connect to.
*
- * @return Returns a {@link List} of {@link HotspotNetwork} objects, empty list on failure.
+ * @return Returns a {@link List} of {@link HotspotNetwork} objects, null on failure.
*/
@RequiresPermission(anyOf = {android.Manifest.permission.NETWORK_SETTINGS,
android.Manifest.permission.NETWORK_SETUP_WIZARD})
- @NonNull
+ @SuppressWarnings("NullableCollection")
+ @Nullable
public List<HotspotNetwork> getHotspotNetworks() {
if (mService == null) {
- return List.of();
+ return null;
}
try {
@@ -449,20 +450,21 @@ public class SharedConnectivityManager {
} catch (RemoteException e) {
Log.e(TAG, "Exception in getHotspotNetworks", e);
}
- return List.of();
+ return null;
}
/**
* Gets the list of known networks the user can select to connect to.
*
- * @return Returns a {@link List} of {@link KnownNetwork} objects, empty list on failure.
+ * @return Returns a {@link List} of {@link KnownNetwork} objects, null on failure.
*/
@RequiresPermission(anyOf = {android.Manifest.permission.NETWORK_SETTINGS,
android.Manifest.permission.NETWORK_SETUP_WIZARD})
- @NonNull
+ @SuppressWarnings("NullableCollection")
+ @Nullable
public List<KnownNetwork> getKnownNetworks() {
if (mService == null) {
- return List.of();
+ return null;
}
try {
@@ -470,7 +472,7 @@ public class SharedConnectivityManager {
} catch (RemoteException e) {
Log.e(TAG, "Exception in getKnownNetworks", e);
}
- return List.of();
+ return null;
}
/**