diff options
| author | 2016-08-15 12:32:51 -0700 | |
|---|---|---|
| committer | 2016-08-15 12:32:51 -0700 | |
| commit | 470f8fcb5c0c59b28b5f73ee011a797b05085da7 (patch) | |
| tree | 94b3c5f77f57476c0f314edb53a01e90220cbfb0 /tools/aapt2/java | |
| parent | af34bd5caeeaed956f3f6728a076799b11fe9406 (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Add NOLINT to suppress wrong clang-tidy warnings on macros.
Test: build with WITH_TIDY=1
Change-Id: Ibfafb23d9be463b4072745a51a6d9f1812dcac45
Diffstat (limited to 'tools/aapt2/java')
| -rw-r--r-- | tools/aapt2/java/ClassDefinition.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/aapt2/java/ClassDefinition.h b/tools/aapt2/java/ClassDefinition.h index d45328fedba2..e84c2741e4ce 100644 --- a/tools/aapt2/java/ClassDefinition.h +++ b/tools/aapt2/java/ClassDefinition.h @@ -110,7 +110,7 @@ using StringMember = PrimitiveMember<std::string>; template <typename T> class PrimitiveArrayMember : public ClassMember { public: - PrimitiveArrayMember(const StringPiece& name) : + explicit PrimitiveArrayMember(const StringPiece& name) : mName(name.toString()) { } |