diff options
| author | 2016-08-10 14:15:30 -0700 | |
|---|---|---|
| committer | 2016-08-11 15:16:41 -0700 | |
| commit | 9b8528fee4eed35b8e887ded0851d08eb2b10db6 (patch) | |
| tree | 36df1cee89b3689454e6b09a6bfa5eabfb3214b1 /tools/aapt2/ResourceUtils.h | |
| parent | 7310353aeb771c109e5aea2c5415fa502eb13a7b (diff) | |
Fix clang-tidy warnings in aapt and aapt2.
* Add explicit keyword to conversion constructors.
* Add NOLINT(implicit) comments for implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: Id6d21961f313a1ad92b15a37fdaa5be9e8ab48e1
Diffstat (limited to 'tools/aapt2/ResourceUtils.h')
| -rw-r--r-- | tools/aapt2/ResourceUtils.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/aapt2/ResourceUtils.h b/tools/aapt2/ResourceUtils.h index 31b8e89850e5..a57d89dd0233 100644 --- a/tools/aapt2/ResourceUtils.h +++ b/tools/aapt2/ResourceUtils.h @@ -163,11 +163,11 @@ std::unique_ptr<BinaryPrimitive> tryParseFlagSymbol(const Attribute* enumAttr, */ std::unique_ptr<Item> parseItemForAttribute( const StringPiece& value, const Attribute* attr, - std::function<void(const ResourceName&)> onCreateReference = {}); + const std::function<void(const ResourceName&)>& onCreateReference = {}); std::unique_ptr<Item> parseItemForAttribute( const StringPiece& value, uint32_t typeMask, - std::function<void(const ResourceName&)> onCreateReference = {}); + const std::function<void(const ResourceName&)>& onCreateReference = {}); uint32_t androidTypeToAttributeTypeMask(uint16_t type); |