diff options
author | 2020-02-10 11:18:07 -0800 | |
---|---|---|
committer | 2020-02-10 11:26:40 -0800 | |
commit | dd5275dcc4ab0a4153d693e8c70457c341a9f7a0 (patch) | |
tree | d587fa61e4f5efc6f9bd20ee210e25ad4a9f81f5 /services/incremental/IncrementalService.cpp | |
parent | 6a1e0b72e3bf86c98211155dfd88d671b58d5e29 (diff) |
incfs: fix uninitialized values
Clang's static analyzer is flagging uninitialized struct fields that
we're passing around. In particular, it's not happy that we pass this
partially-initialized struct to a pure-virtual method. I tend to agree
that this may cause issues.
Assuming zero-init gives us reasonable values for all of:
IncFsNewFileParams{}.verification.rootHash
IncFsNewFileParams{}.verification.additionalData
IncFsNewFileParams{}.verification.signature
Bug: None
Test: TreeHugger
Change-Id: I61e556cd8c0e68cdaebd50b0a7be5d5e0a4fd8ff
Diffstat (limited to 'services/incremental/IncrementalService.cpp')
-rw-r--r-- | services/incremental/IncrementalService.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/services/incremental/IncrementalService.cpp b/services/incremental/IncrementalService.cpp index 3b513774b615..8012e74a6b3c 100644 --- a/services/incremental/IncrementalService.cpp +++ b/services/incremental/IncrementalService.cpp @@ -1180,7 +1180,7 @@ bool IncrementalService::configureNativeBinaries(StorageId storage, std::string_ } // Create new lib file without signature info - incfs::NewFileParams libFileParams; + incfs::NewFileParams libFileParams{}; libFileParams.size = uncompressedLen; libFileParams.verification.hashAlgorithm = INCFS_HASH_NONE; // Metadata of the new lib file is its relative path |