diff options
| author | 2016-02-26 16:48:22 -0800 | |
|---|---|---|
| committer | 2016-02-29 16:46:54 -0800 | |
| commit | bbd91e58444f092e1080f5a0a746fcd4b21ce113 (patch) | |
| tree | 0edaf8e8e0336102f26ff0df446f8b7f39076b2f /packages/Shell/src | |
| parent | 74db59042c7930ff79f3b848a4d216c979250cad (diff) | |
Make bugreport details dialog confirm to Material Guidelines for Dialogs.
Changes:
- Removed hints.
- Added TextViews for field labels.
- Added padding for inner dialog
- Adedd autoCorrect and capSentences to title and summary
- Changed strings.
- Set name to be selectAllOnFocus initially.
Also improved some logging statements.
BUG: 26324085
Change-Id: I32597a7c2839ca706dbbcf13660e976469ab8dd0
Diffstat (limited to 'packages/Shell/src')
| -rw-r--r-- | packages/Shell/src/com/android/shell/BugreportProgressService.java | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/packages/Shell/src/com/android/shell/BugreportProgressService.java b/packages/Shell/src/com/android/shell/BugreportProgressService.java index 36097a124ff9..0b5258895775 100644 --- a/packages/Shell/src/com/android/shell/BugreportProgressService.java +++ b/packages/Shell/src/com/android/shell/BugreportProgressService.java @@ -601,7 +601,8 @@ public class BugreportProgressService extends Service { // Most likely am killed Shell before user tapped the notification. Since system might // be too busy anwyays, it's better to ignore the notification and switch back to the // non-interactive mode (where the bugerport will be shared upon completion). - Log.d(TAG, "launchBugreportInfoDialog(" + id + "): cancel notification"); + Log.w(TAG, "launchBugreportInfoDialog(): canceling notification because id " + id + + " was not found"); // TODO: add test case to make sure notification is canceled. NotificationManager.from(mContext).cancel(TAG, id); return; @@ -627,7 +628,8 @@ public class BugreportProgressService extends Service { // Most likely am killed Shell before user tapped the notification. Since system might // be too busy anwyays, it's better to ignore the notification and switch back to the // non-interactive mode (where the bugerport will be shared upon completion). - Log.d(TAG, "takeScreenshot(" + id + ", " + delayed + "): cancel notification"); + Log.w(TAG, "takeScreenshot(): canceling notification because id " + id + + " was not found"); // TODO: add test case to make sure notification is canceled. NotificationManager.from(mContext).cancel(TAG, id); return; @@ -1268,6 +1270,9 @@ public class BugreportProgressService extends Service { if (hasFocus) { return; } + // Select-all is useful just initially, since the date-based filename is + // full of hyphens. + mInfoName.setSelectAllOnFocus(false); sanitizeName(); } }); @@ -1276,7 +1281,7 @@ public class BugreportProgressService extends Service { .setView(view) .setTitle(dialogTitle) .setCancelable(false) - .setPositiveButton(context.getString(com.android.internal.R.string.ok), + .setPositiveButton(context.getString(R.string.save), null) .setNegativeButton(context.getString(com.android.internal.R.string.cancel), new DialogInterface.OnClickListener() |