Add @hide IMM#hideSoftInputFromView as an optimization

It seems that it is relatively a common pattern used in the Framework
code when trying to hide a software keyboard.

  var imm = view.getSystemService(InputMethodManager.class);
  if (imm != null && imm.isActive(view)) {
    imm.hideSoftInputFromWindow(view.getWindowToken(), 0);
  }

The above code can be easily optimized by introducing a counterpart of

  InputMethodManager#showSoftInput(View view, int flags);

so that the hide request can be issued when and only when the
specified view has already established a connection to the IME. The
optimized code would look like as follows.

  var imm = view.getSystemService(InputMethodManager.class);
  if (imm != null) {
    imm.hideSoftInputFromView(view, 0);
  }

Major advantages of such an approach are:

 * IMM#checkFocus() can never be called.
 * IMM needs to take a lock only once.

With above, this CL introduces IMM#hideSoftInputFromView() as @hide
method so that we can start making sure that such an approach works
well.

Fix: 296466613
Test: atest CtsInputMethodTestCases:EditTextImeSupportTest
Change-Id: I01e5a29c0f82d068751774a2c58a1bd7b7b7f91a

1 files changed, 1 insertions, 3 deletions

diff --git a/packages/PrintSpooler/src/com/android/printspooler/widget/PrintContentView.java b/packages/PrintSpooler/src/com/android/printspooler/widget/PrintContentView.java
index b0aa8f19f24b..6ecffa4752cf 100644
--- a/packages/PrintSpooler/src/com/android/printspooler/widget/PrintContentView.java
+++ b/packages/PrintSpooler/src/com/android/printspooler/widget/PrintContentView.java
@@ -383,9 +383,7 @@ public final class PrintContentView extends ViewGroup implements View.OnClickLis
         if (focused != null && focused.isFocused()) {
             InputMethodManager imm = (InputMethodManager) mContext.getSystemService(
                     Context.INPUT_METHOD_SERVICE);
-            if (imm.isActive(focused)) {
-                imm.hideSoftInputFromWindow(getWindowToken(), 0);
-            }
+            imm.hideSoftInputFromView(focused, 0);
             focused.clearFocus();
         }
     }