summaryrefslogtreecommitdiff
path: root/native
diff options
context:
space:
mode:
author Prabir Pradhan <prabirmsp@google.com> 2023-04-24 16:12:38 +0000
committer Prabir Pradhan <prabirmsp@google.com> 2023-05-02 16:02:36 +0000
commitf5c06a171c6eb51c6c914540b36a8211036fe735 (patch)
tree86b19fa10e8692c6810499a63e757b34b1c2f70e /native
parentd160effd39d04a4638ffd23a9681a407efc78891 (diff)
Clean up KeyEvent JNI APIs
Directly return a KeyEvent from KeyEvent_toNative, and change the KeyEvent parameter from a pointer to a reference in KeyEvent_fromNative. Bug: 279927189 Bug: 245989146 Test: Presubmit Change-Id: I9c98700ea4645c6c4cb975fabfa25d1ff959bfc3
Diffstat (limited to 'native')
-rw-r--r--native/android/input.cpp7
1 files changed, 2 insertions, 5 deletions
diff --git a/native/android/input.cpp b/native/android/input.cpp
index 1bff97dfdada..64e8efeaa4e8 100644
--- a/native/android/input.cpp
+++ b/native/android/input.cpp
@@ -87,11 +87,8 @@ int64_t AKeyEvent_getDownTime(const AInputEvent* key_event) {
const AInputEvent* AKeyEvent_fromJava(JNIEnv* env, jobject keyEvent) {
std::unique_ptr<KeyEvent> event = std::make_unique<KeyEvent>();
- android::status_t ret = android::android_view_KeyEvent_toNative(env, keyEvent, event.get());
- if (ret == android::OK) {
- return event.release();
- }
- return nullptr;
+ *event = android::android_view_KeyEvent_toNative(env, keyEvent);
+ return event.release();
}
int64_t AKeyEvent_getEventTime(const AInputEvent* key_event) {