summaryrefslogtreecommitdiff
path: root/native/android
diff options
context:
space:
mode:
author Arpit Singh <arpitks@google.com> 2024-02-21 17:25:23 +0000
committer Arpit Singh <arpitks@google.com> 2024-02-21 18:35:53 +0000
commit43c34c8991e5d2a11296d9449b3348189df8f616 (patch)
tree7205c707a011af8c658f8a0f5f22f2d6d4fc7021 /native/android
parent3d8cc938500d687fa071cbd91d245fe10daba59f (diff)
Use ScopedLocalRef in InputEvent jni function
This CL updates some jni functions that manipulate Key and Motion events to use ScopedLocalRef instead of plain jobject for better life-cycle tracking. Test: presubmit Bug: 324375527 Change-Id: I154b0606d3c0912f0df7a890faf7246b575863f5
Diffstat (limited to 'native/android')
-rw-r--r--native/android/input.cpp6
1 files changed, 4 insertions, 2 deletions
diff --git a/native/android/input.cpp b/native/android/input.cpp
index 4708e69447ec..53699bc706ea 100644
--- a/native/android/input.cpp
+++ b/native/android/input.cpp
@@ -321,11 +321,13 @@ jobject AInputEvent_toJava(JNIEnv* env, const AInputEvent* aInputEvent) {
case AINPUT_EVENT_TYPE_MOTION:
return android::android_view_MotionEvent_obtainAsCopy(env,
static_cast<const MotionEvent&>(
- *aInputEvent));
+ *aInputEvent))
+ .release();
case AINPUT_EVENT_TYPE_KEY:
return android::android_view_KeyEvent_obtainAsCopy(env,
static_cast<const KeyEvent&>(
- *aInputEvent));
+ *aInputEvent))
+ .release();
default:
LOG_ALWAYS_FATAL("Unexpected event type %d in AInputEvent_toJava.", eventType);
}