diff options
| author | 2021-08-19 00:40:13 +0000 | |
|---|---|---|
| committer | 2021-08-19 00:40:13 +0000 | |
| commit | cb8f9e3429a6c736939ccec826a779d690ef9a9c (patch) | |
| tree | 29db77c5f4631c2e218b1161d2a3e80b236a8148 /libs | |
| parent | 773a3783902e531c6826ac8f9ac53506c07a9be2 (diff) | |
| parent | 304793a811cdaec2f867070d7f791226ca52fc24 (diff) | |
Merge "Rename ProcResult stdout and stderr fields"
Diffstat (limited to 'libs')
| -rw-r--r-- | libs/androidfw/PosixUtils.cpp | 4 | ||||
| -rw-r--r-- | libs/androidfw/include/androidfw/PosixUtils.h | 4 | ||||
| -rw-r--r-- | libs/androidfw/tests/PosixUtils_test.cpp | 4 |
3 files changed, 6 insertions, 6 deletions
diff --git a/libs/androidfw/PosixUtils.cpp b/libs/androidfw/PosixUtils.cpp index 4ec525a01da5..026912883a73 100644 --- a/libs/androidfw/PosixUtils.cpp +++ b/libs/androidfw/PosixUtils.cpp @@ -114,10 +114,10 @@ std::unique_ptr<ProcResult> ExecuteBinary(const std::vector<std::string>& argv) std::unique_ptr<ProcResult> result(new ProcResult()); result->status = status; const auto out = ReadFile(stdout[0]); - result->stdout = out ? *out : ""; + result->stdout_str = out ? *out : ""; close(stdout[0]); const auto err = ReadFile(stderr[0]); - result->stderr = err ? *err : ""; + result->stderr_str = err ? *err : ""; close(stderr[0]); return result; } diff --git a/libs/androidfw/include/androidfw/PosixUtils.h b/libs/androidfw/include/androidfw/PosixUtils.h index 8fc3ee2733c7..bb2084740a44 100644 --- a/libs/androidfw/include/androidfw/PosixUtils.h +++ b/libs/androidfw/include/androidfw/PosixUtils.h @@ -23,8 +23,8 @@ namespace util { struct ProcResult { int status; - std::string stdout; - std::string stderr; + std::string stdout_str; + std::string stderr_str; }; // Fork, exec and wait for an external process. Return nullptr if the process could not be launched, diff --git a/libs/androidfw/tests/PosixUtils_test.cpp b/libs/androidfw/tests/PosixUtils_test.cpp index cf97f87a4163..c7b3eba1451f 100644 --- a/libs/androidfw/tests/PosixUtils_test.cpp +++ b/libs/androidfw/tests/PosixUtils_test.cpp @@ -30,14 +30,14 @@ TEST(PosixUtilsTest, AbsolutePathToBinary) { const auto result = ExecuteBinary({"/bin/date", "--help"}); ASSERT_THAT(result, NotNull()); ASSERT_EQ(result->status, 0); - ASSERT_EQ(result->stdout.find("usage: date "), 0); + ASSERT_EQ(result->stdout_str.find("usage: date "), 0); } TEST(PosixUtilsTest, RelativePathToBinary) { const auto result = ExecuteBinary({"date", "--help"}); ASSERT_THAT(result, NotNull()); ASSERT_EQ(result->status, 0); - ASSERT_EQ(result->stdout.find("usage: date "), 0); + ASSERT_EQ(result->stdout_str.find("usage: date "), 0); } TEST(PosixUtilsTest, BadParameters) { |